Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104958/?format=api
{ "id": 104958, "url": "http://patchwork.dpdk.org/api/patches/104958/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211206221922.644187-8-stephend@silicom-usa.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211206221922.644187-8-stephend@silicom-usa.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211206221922.644187-8-stephend@silicom-usa.com", "date": "2021-12-06T22:19:21", "name": "[v2,7/7] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "041eb92e12e2769907eb41831fc3bf6eb23ecdcc", "submitter": { "id": 2437, "url": "http://patchwork.dpdk.org/api/people/2437/?format=api", "name": "Stephen Douthit", "email": "stephend@silicom-usa.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211206221922.644187-8-stephend@silicom-usa.com/mbox/", "series": [ { "id": 20881, "url": "http://patchwork.dpdk.org/api/series/20881/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20881", "date": "2021-12-06T22:19:14", "name": "ixgbe SFP handling fixes", "version": 2, "mbox": "http://patchwork.dpdk.org/series/20881/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104958/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104958/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E607A034F;\n\tMon, 6 Dec 2021 23:20:35 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6D73542744;\n\tMon, 6 Dec 2021 23:20:01 +0100 (CET)", "from EUR05-DB8-obe.outbound.protection.outlook.com\n (mail-db8eur05on2108.outbound.protection.outlook.com [40.107.20.108])\n by mails.dpdk.org (Postfix) with ESMTP id 78E3041C3D\n for <dev@dpdk.org>; Mon, 6 Dec 2021 23:19:57 +0100 (CET)", "from AM0PR04MB4083.eurprd04.prod.outlook.com (2603:10a6:208:64::29)\n by AM0PR04MB6596.eurprd04.prod.outlook.com (2603:10a6:208:173::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec\n 2021 22:19:56 +0000", "from AM0PR04MB4083.eurprd04.prod.outlook.com\n ([fe80::f4db:d40d:a746:7bfc]) by AM0PR04MB4083.eurprd04.prod.outlook.com\n ([fe80::f4db:d40d:a746:7bfc%7]) with mapi id 15.20.4755.022; Mon, 6 Dec 2021\n 22:19:56 +0000", "from lappy.adi.eng (173.14.114.227) by\n MN2PR20CA0031.namprd20.prod.outlook.com (2603:10b6:208:e8::44) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.4755.19 via Frontend Transport; Mon, 6 Dec 2021 22:19:55 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=joy7EKexSZ4bMfemkgdizazn/QledFBvdpDfxCXQTWoGjRcz5S1w7dfnLQeI5K8oOfbBgnZ37a+BDYN2nqqk5StGuYlwSSMi4YzVHrDnMC0H68BPHJhIJU7XTpBcvE4SmhiSpMo9mcy2N6soOPkgJcKFkagK/Ufy/L+WnHHuxdA1mBMY2adgGkgDQGQ2JLJ9inWs4/Ji3SFRqaQl47Nmah/IBHjTWmU2Ayk6qkNpcoZCjhPaO8xmAfi7mR7uoChMGYxm2mWyM3R6PUtoROUWQoTPCLO6wLFAeoGCxvq/ug5ER1OLK9hu92LN9G1siEKl3ZCN1jDKcVyKfankaWKs7A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=W/qS6nt4ZP5zaFSNM8uhgBoE0AYFIw0QJIFIPHLMqn0=;\n b=UVN2pGrVh75quRq1RIrsljxeE2blaFAa5z5Cgsy2tqwunXqGxgmZdpQgwleZFMtzlQ0pD2H1e4tiOlKTH5fas2h2csRZeCPHH4MfNj4+80Q7O3tavEmdwefsr2UDa0jqdj3K6gTl3bPfojSsuXdls8ouxFp1bd+/IlfGPl6QP7PVHrXqVjjYvVzbZLBKuZKr7bbTBUWhewQnXpiDGVjE/SPij2/z5wpvMibjwbswhWRuOahwov8fvl2kgGl2L/+DSwYIXuzyGOd7iW5l4if9Zp4iyqWFLT69MbV3lXi1S+Bmgl90s2XYoeJuRdkvDbuLjbOHN5JblC+SJrT8POp7lQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=silicom-usa.com; dmarc=pass action=none\n header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=W/qS6nt4ZP5zaFSNM8uhgBoE0AYFIw0QJIFIPHLMqn0=;\n b=WLoadyGuv5khQjZZRHczJpGB7iBUZvIF/1GVr1hfnJDz1EZMevv7iraeMBbWW0rN8nAztKdxRbDp4bmPJ7nkTbxDKf49qcI+sJTHHM5Rev2o+zdj6uuhdNy1JeqnEw183s0XBBLlh6+QWHNmgV+tapS0Cm0mMnLUV6P8R2mCMZQ=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=silicom-usa.com;", "From": "Stephen Douthit <stephend@silicom-usa.com>", "To": "Haiyue Wang <haiyue.wang@intel.com>", "Cc": "dev@dpdk.org, wenw@silicom-usa.com,\n Stephen Douthit <stephend@silicom-usa.com>", "Subject": "[PATCH v2 7/7] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550\n devices", "Date": "Mon, 6 Dec 2021 17:19:21 -0500", "Message-Id": "<20211206221922.644187-8-stephend@silicom-usa.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20211206221922.644187-1-stephend@silicom-usa.com>", "References": "<20211206221922.644187-1-stephend@silicom-usa.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "MN2PR20CA0031.namprd20.prod.outlook.com\n (2603:10b6:208:e8::44) To AM0PR04MB4083.eurprd04.prod.outlook.com\n (2603:10a6:208:64::29)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "d61e95f7-de27-4a6b-18e9-08d9b906887c", "X-MS-TrafficTypeDiagnostic": "AM0PR04MB6596:EE_", "X-Microsoft-Antispam-PRVS": "\n <AM0PR04MB659623AEE0CBC2D7E7DD83C2946D9@AM0PR04MB6596.eurprd04.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:9508;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ZL5EJ2XauggwL8A2AeE56YGBeRHYeKmnIcr/bPNafAXdWYTFR+zrr13B8VB1gqifCjos6t4UtVxQjNiK/p7rCqNq/PIurs8SF4JeANYHsVF4NgG3x0ka91k8bXbF+it2jou1TxIIKZmZ9domGMUaPZLdBArT/EGGNGZ2MNk4AJuHcZJaLqY/i4fSOnKj1H1wFIn8kup+9zQ/JiR8hBxgoqYweQXl5H/rUDyLI84w/3ixFhLnnOi4XymNPGdIKsx3G2tz6TBEOE2wX8eC1RKj1408P4S2Uz2m+h6n5cEIGmHCeCnOmv/MzwyR/A66fHh1tuYmK8ww599+9sFRWiLxaEVafDUmJgRLAxpHfCImaatV5rGwcAVBgmcXL1uwMyFhb64+rvqrF4w2G2cVTtOj2JBnYk8bMKCuFEpqFFJ3nQUWRTr89Za5oYOD8rHR4PUVAaEHGAXW48SgOKnc4xBfePSpTZ79cckM8KPFhcNDa0z7fdKD9VyjxmvGoWzG1SZAhtQY8g1Y5x0hkaxFbWy/+mvp5MX6lqKYJs8ZX2onpPfv439It3UI69ThOxBx9OF1zL2xYp6kRzKxFBgK4TR/f23CMvzH/p2/lqLyRn3QAMGoduBVqMe/RKXZI5b/sVoACz4uCD05thRcR+akfYyw+9HEBobR2FE90cpJWepNO88FOvnXor+1AmNutYQbK+9WfBQIJcQrAs2cXF41kisjxg==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR04MB4083.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(4636009)(366004)(8676002)(4326008)(66946007)(6506007)(8936002)(6666004)(2616005)(52116002)(66476007)(66556008)(86362001)(956004)(107886003)(6486002)(6512007)(2906002)(316002)(83380400001)(1076003)(36756003)(38100700002)(38350700002)(26005)(5660300002)(186003)(508600001)(6916009);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n h2PdCe3mq08m6X8cE1mm2vsSYH03scO1eLeH3Q58yurm1ttcU7ildOo30pOF9tqdx/Y3fXHZTMfrhurqObgnqokCaXVbKaWW+cy6bGp4fE+syWq/saKU1eIomVbSJbK8PDfqf3y+uwOvDFnVeBxWYNyD1XWQMVIXUDHsTYaDWfnhTtZNNntyfeF8IcF29+0+kj4ipBAbEEJgePTZimBY0R6RY/hzEeGU+ZMozhYxlozI2QqfKEsxdntdFj1JgSQulO0oKznQwGCj9yYHmPj3tEUg178g6VNzNauTWt9fDQcwAI6Fn+CEnDKkoCLkaWTMwmFFa/K4N5nTPU+y+1bRNWrcEUIzEaAXAh4m7fWERmxEZJM8tqAAaD4BW9+BzqqxfYAno5ihVaRbrH6wY/kgLKFRskjQdIgjRkHC/cIO4l2WZo+yJyO6586lqMeKu8HXYic3MXRu0566uEJOy5pK13r8Ck3UnpaQJjaclaMx26tbBjHjHVVJjLjHCjGUWpzODWByb39ReYz6Fr475ywhQerFwUhF6NdebCGZhNwjoCfm9l3iH2mHf1c711HHAXjcp0LC/CvY0LYup8BRvtqHWSGWh4+qfGXOq74iwfcSSpzpLu9n4zA9WhZIB3mq/CNVGNKYu11LeSZt+djmA1fMJYCPfXJ1nRxqk5pASS2h+3PGA/FnU5QLt6nXW1jfXi8euOJrEtvdjezBWDbxvB3bpgBGfLUv7+8ynJAK2I6JR6CDjMQINScjg3k5/YMcwAjcFwDNYD7wTo3qSGEGltDhQ4YD7NXwpOit3HXR5zU+6yXPa2znTzlth22s8f4zutOJ85U2+v++T5wbPTdzsE7+lYFgVSQ3vYdLBnG+USE8AK2qemeF1VjOGueC4WYJ/Kvc5SsbGEcTo22idIBGr8QsEvGicsZaw5PtrLkkn9I9EEtbilxoiwZUbC05NGMJfKnk0iY0CwHhFyY9Iv67bk+X0DaPcDH+FLhDsCra4De8b7gqOhR9ymaABAiTPiWt0qOlTBQTY27NWjDa4BVi4aaCM5RcmiWH/QJogWaPaA0Wrv5jy+ch/t1jzd3/ERjLak3YJaQbSpZ9Dpg/8ZfREwrST+zcqKn8VqFN2OTtSIOH+kC6vEVNXz9zc9ceXR+hfY1nXfN3qLgRMBzgyceU5cZhqDtvxjUNLxUzQnBDkAgRUTDCHikfWbjlFlFiWSd46BpMrx2C4ZvCcG2M1oQK6DSUgbq+2qUVlqCqisxsc0xIHp7Y6HoOaUuHpbEXDQ6x40OvlteRdi55+3nK+H+lEr7jIEBPQ9L+dMjtjWYk98J62N28qkmU4ybOoYiiacqS3hPwPZkJk7VxRhCO3SeEBPQYfxhjDKXgHssHQmP/Tr67ztX1ojRXLOyECd6HosspMxXnfAcgNJH04b+m871i+g+Zd/TYvg06cArEfSGUE2e0LULyZOysWg4h68hpsrBXOVxW6eQLGnyYJrhc962v9W0MyH3v4x+Qk6TQz7/7jhOeXilBpFdVcidVw/Nv6Dm7Fr2rooZOoTFvlf3ikY1hDzcup/3OGszfR8bxfcz87JW5eMlj7Imdgc/KwpSJj4Zh8V3LEVcRU5IgE9J0rV3cUh/OKFSiMlxIrF7iKUmXNcNiKuulqdT9jZF0iK4Qx0SS+2WsDX1tidvPVSfm7uwLfr8mPxsQhQibI+/XVEPw/OkHFns=", "X-OriginatorOrg": "silicom-usa.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n d61e95f7-de27-4a6b-18e9-08d9b906887c", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR04MB4083.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "06 Dec 2021 22:19:56.1871 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "c9e326d8-ce47-4930-8612-cc99d3c87ad1", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n le+tyvui/1hC+kpra/K5VvdMvwJe4naoEzShWdCtic21C7E6hp2szWK2gispqsLytlftBz4wupVIhk7udOay34y/E+D3aOvfPIT1NIOvHxw=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR04MB6596", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "1G Cu SFPs are not officially supported on the X552/X553 family of devices\nbut treat them as 1G SX modules since they usually work. Print a warning\nthough since support isn't validated, similar to what already happens for\nother unofficially supported SFPs enabled via the allow_unsupported_sfps\nparameter inherited from the mainline Linux driver.\n\nSigned-off-by: Stephen Douthit <stephend@silicom-usa.com>\n---\n drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++-\n 1 file changed, 13 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c\nindex 8810d1658e..8d1bc6c80d 100644\n--- a/drivers/net/ixgbe/base/ixgbe_x550.c\n+++ b/drivers/net/ixgbe/base/ixgbe_x550.c\n@@ -1538,9 +1538,21 @@ STATIC s32 ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool *linear)\n \tcase ixgbe_sfp_type_1g_lha_core1:\n \t\t*linear = false;\n \t\tbreak;\n-\tcase ixgbe_sfp_type_unknown:\n+\t/* Copper SFPs are not officially supported for x550em devices, but can\n+\t * often be made to work at fixed 1G speeds. Pretend they're 1g_sx\n+\t * modules here to allow g.Fast DSL SFPs to work.\n+\t */\n \tcase ixgbe_sfp_type_1g_cu_core0:\n+\t\tEWARN(hw, \"Pretending that unsupported 1g_cu SFP is 1g_sx\\n\");\n+\t\t*linear = false;\n+\t\thw->phy.sfp_type = ixgbe_sfp_type_1g_sx_core0;\n+\t\tbreak;\n \tcase ixgbe_sfp_type_1g_cu_core1:\n+\t\tEWARN(hw, \"Pretending that unsupported 1g_cu SFP is 1g_sx\\n\");\n+\t\t*linear = false;\n+\t\thw->phy.sfp_type = ixgbe_sfp_type_1g_sx_core1;\n+\t\tbreak;\n+\tcase ixgbe_sfp_type_unknown:\n \tdefault:\n \t\treturn IXGBE_ERR_SFP_NOT_SUPPORTED;\n \t}\n", "prefixes": [ "v2", "7/7" ] }