Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104967/?format=api
{ "id": 104967, "url": "http://patchwork.dpdk.org/api/patches/104967/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1638859858-734-14-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1638859858-734-14-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1638859858-734-14-git-send-email-anoobj@marvell.com", "date": "2021-12-07T06:50:46", "name": "[13/25] crypto/cnxk: use struct sizes for ctx writes", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a54e99a0df635e721cbb06a2bf1a06993d9281a4", "submitter": { "id": 1205, "url": "http://patchwork.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1638859858-734-14-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 20882, "url": "http://patchwork.dpdk.org/api/series/20882/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20882", "date": "2021-12-07T06:50:34", "name": "New features and improvements in cnxk crypto PMD", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20882/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104967/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104967/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 47DBAA034F;\n\tTue, 7 Dec 2021 07:52:12 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2D5C342730;\n\tTue, 7 Dec 2021 07:51:56 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id A186E426DC\n for <dev@dpdk.org>; Tue, 7 Dec 2021 07:51:54 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 1B75a0L1014936\n for <dev@dpdk.org>; Mon, 6 Dec 2021 22:51:54 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3ct1hyg7eh-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 06 Dec 2021 22:51:54 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Mon, 6 Dec 2021 22:51:52 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 6 Dec 2021 22:51:52 -0800", "from HY-LT1002.marvell.com (HY-LT1002.marvell.com [10.28.176.218])\n by maili.marvell.com (Postfix) with ESMTP id E6CFD3F7071;\n Mon, 6 Dec 2021 22:51:49 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=6jNBhTKdZpCiYpzmg4yTdYvM00tL5KoiGtP83OoJWec=;\n b=CPzuxb7jAY8V18AlRXl6g24VMhdyGmcT1H7KKsxcKJ0562SFDStmGwF/CpKD0R2c0iBx\n INKuj9WtAKaI9YaSKClYHcVfqkBwWhlFDhbnNZZi7TFGq28eXr7kLu4vg99x0aAutj2o\n lYxLT6ZY/u77gyqw0SyKvaIbshxXVFjxQXl1OSzbSPREsnN2MApMjFvUZlf78kNq2wUy\n Yb+rlQMExg0mwE0gO1nrJuxDZbwAPLLBldeoiATpeL7ZhY0qLsnZVjM4kbEeOFRuM+cQ\n ixdDa5OJeZFoC4Z/uHZM+s47MKI+Elvm/7SnqUMZpycHamRwXIgtnZjTUwAxbO/jj4h7 iQ==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Jerin Jacob <jerinj@marvell.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Archana Muniganti\n <marchana@marvell.com>,\n Tejasree Kondoj <ktejasree@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH 13/25] crypto/cnxk: use struct sizes for ctx writes", "Date": "Tue, 7 Dec 2021 12:20:46 +0530", "Message-ID": "<1638859858-734-14-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1638859858-734-1-git-send-email-anoobj@marvell.com>", "References": "<1638859858-734-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "XePx76IJZkFseq5TofYzoy0KCNfa_RWS", "X-Proofpoint-GUID": "XePx76IJZkFseq5TofYzoy0KCNfa_RWS", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513\n definitions=2021-12-07_02,2021-12-06_02,2021-12-02_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "CTX writes only require the lengths are 8B aligned. Use the struct size\ndirectly.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\n drivers/crypto/cnxk/cn10k_ipsec.c | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/crypto/cnxk/cn10k_ipsec.c b/drivers/crypto/cnxk/cn10k_ipsec.c\nindex b4acbac..0832b53 100644\n--- a/drivers/crypto/cnxk/cn10k_ipsec.c\n+++ b/drivers/crypto/cnxk/cn10k_ipsec.c\n@@ -52,14 +52,12 @@ cn10k_ipsec_outb_sa_create(struct roc_cpt *roc_cpt, struct roc_cpt_lf *lf,\n \tout_sa = &sa->out_sa;\n \n \t/* Allocate memory to be used as dptr for CPT ucode WRITE_SA op */\n-\tsa_dptr = plt_zmalloc(ROC_NIX_INL_OT_IPSEC_OUTB_HW_SZ, 0);\n+\tsa_dptr = plt_zmalloc(sizeof(struct roc_ot_ipsec_outb_sa), 8);\n \tif (sa_dptr == NULL) {\n \t\tplt_err(\"Couldn't allocate memory for SA dptr\");\n \t\treturn -ENOMEM;\n \t}\n \n-\tmemset(sa_dptr, 0, sizeof(struct roc_ot_ipsec_outb_sa));\n-\n \t/* Translate security parameters to SA */\n \tret = cnxk_ot_ipsec_outb_sa_fill(sa_dptr, ipsec_xfrm, crypto_xfrm);\n \tif (ret) {\n@@ -133,7 +131,7 @@ cn10k_ipsec_outb_sa_create(struct roc_cpt *roc_cpt, struct roc_cpt_lf *lf,\n \n \t/* Write session using microcode opcode */\n \tret = roc_cpt_ctx_write(lf, sa_dptr, out_sa,\n-\t\t\t\tROC_NIX_INL_OT_IPSEC_OUTB_HW_SZ);\n+\t\t\t\tsizeof(struct roc_ot_ipsec_outb_sa));\n \tif (ret) {\n \t\tplt_err(\"Could not write outbound session to hardware\");\n \t\tgoto sa_dptr_free;\n@@ -169,14 +167,12 @@ cn10k_ipsec_inb_sa_create(struct roc_cpt *roc_cpt, struct roc_cpt_lf *lf,\n \tin_sa = &sa->in_sa;\n \n \t/* Allocate memory to be used as dptr for CPT ucode WRITE_SA op */\n-\tsa_dptr = plt_zmalloc(ROC_NIX_INL_OT_IPSEC_INB_HW_SZ, 0);\n+\tsa_dptr = plt_zmalloc(sizeof(struct roc_ot_ipsec_inb_sa), 8);\n \tif (sa_dptr == NULL) {\n \t\tplt_err(\"Couldn't allocate memory for SA dptr\");\n \t\treturn -ENOMEM;\n \t}\n \n-\tmemset(sa_dptr, 0, sizeof(struct roc_ot_ipsec_inb_sa));\n-\n \t/* Translate security parameters to SA */\n \tret = cnxk_ot_ipsec_inb_sa_fill(sa_dptr, ipsec_xfrm, crypto_xfrm);\n \tif (ret) {\n@@ -225,7 +221,7 @@ cn10k_ipsec_inb_sa_create(struct roc_cpt *roc_cpt, struct roc_cpt_lf *lf,\n \n \t/* Write session using microcode opcode */\n \tret = roc_cpt_ctx_write(lf, sa_dptr, in_sa,\n-\t\t\t\tROC_NIX_INL_OT_IPSEC_INB_HW_SZ);\n+\t\t\t\tsizeof(struct roc_ot_ipsec_inb_sa));\n \tif (ret) {\n \t\tplt_err(\"Could not write inbound session to hardware\");\n \t\tgoto sa_dptr_free;\n", "prefixes": [ "13/25" ] }