Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104969/?format=api
http://patchwork.dpdk.org/api/patches/104969/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1638859858-734-16-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1638859858-734-16-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1638859858-734-16-git-send-email-anoobj@marvell.com", "date": "2021-12-07T06:50:48", "name": "[15/25] crypto/cnxk: add skip for unsupported cases", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "65d2d5d97ff014b4fd7dbdfb98fe00e8103e4974", "submitter": { "id": 1205, "url": "http://patchwork.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1638859858-734-16-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 20882, "url": "http://patchwork.dpdk.org/api/series/20882/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20882", "date": "2021-12-07T06:50:34", "name": "New features and improvements in cnxk crypto PMD", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20882/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104969/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104969/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 66CA3A034F;\n\tTue, 7 Dec 2021 07:52:23 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BF30441152;\n\tTue, 7 Dec 2021 07:52:02 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id AD94D42738\n for <dev@dpdk.org>; Tue, 7 Dec 2021 07:52:00 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 1B75aClh015652\n for <dev@dpdk.org>; Mon, 6 Dec 2021 22:52:00 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3ct1hyg7f4-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 06 Dec 2021 22:52:00 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Mon, 6 Dec 2021 22:51:58 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 6 Dec 2021 22:51:58 -0800", "from HY-LT1002.marvell.com (HY-LT1002.marvell.com [10.28.176.218])\n by maili.marvell.com (Postfix) with ESMTP id AF1BB3F7071;\n Mon, 6 Dec 2021 22:51:56 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=DejYeIoUnIlPzloXx0hgfCsGoLdyL3dnFZG6LgV0zEo=;\n b=A9Q4iGxKtqcA7otg3gJcWc7oS82k5JKqzB7z+Dng9+BP9Cy6VHpSICJwh/vE/9ZOIrkp\n Ll8qfKNwJrpJKdtfwRfPBqKhhN//Kz4ZSdOjgAo5c74sKpwoQE1R3z1MNMp1ed/Sew/R\n 3NOn7jUwhbkJA6W5IyQOyWvgVJ92Vmhozh1YsPqmLun2+5dtEmtMWncM7QccH0RoBiBh\n 43OmN8ddWqAhXODKAtc0DUR/xlxFDST6isTgaqW7nDZwFK5Q44yVvpBNghwds4nfwoG5\n qZKjj17UFQQsyzLl4Qz2WO4DvGByMPr2njaMFINKNg9hXUFTpJ42fcP1Yor5/R5MOyIQ gw==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Jerin Jacob <jerinj@marvell.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Archana Muniganti\n <marchana@marvell.com>,\n Tejasree Kondoj <ktejasree@marvell.com>, <dev@dpdk.org>", "Subject": "[PATCH 15/25] crypto/cnxk: add skip for unsupported cases", "Date": "Tue, 7 Dec 2021 12:20:48 +0530", "Message-ID": "<1638859858-734-16-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1638859858-734-1-git-send-email-anoobj@marvell.com>", "References": "<1638859858-734-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "rS1nDaM09XXksEsP8oLtrWLDtB-NoPJ-", "X-Proofpoint-GUID": "rS1nDaM09XXksEsP8oLtrWLDtB-NoPJ-", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513\n definitions=2021-12-07_02,2021-12-06_02,2021-12-02_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add skip for transport mode tests that are not supported. Also, updated the\ntransport mode path to configure IP version as v4.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\n drivers/crypto/cnxk/cn9k_ipsec.c | 53 +++++++++++++++++++++++++++++++++++-----\n 1 file changed, 47 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/crypto/cnxk/cn9k_ipsec.c b/drivers/crypto/cnxk/cn9k_ipsec.c\nindex 395b0d5..3c6c8e9 100644\n--- a/drivers/crypto/cnxk/cn9k_ipsec.c\n+++ b/drivers/crypto/cnxk/cn9k_ipsec.c\n@@ -141,11 +141,10 @@ ipsec_sa_ctl_set(struct rte_security_ipsec_xform *ipsec,\n \t\t\treturn -EINVAL;\n \t}\n \n-\tctl->inner_ip_ver = ctl->outer_ip_ver;\n-\n-\tif (ipsec->mode == RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT)\n+\tif (ipsec->mode == RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT) {\n \t\tctl->ipsec_mode = ROC_IE_SA_MODE_TRANSPORT;\n-\telse if (ipsec->mode == RTE_SECURITY_IPSEC_SA_MODE_TUNNEL)\n+\t\tctl->outer_ip_ver = ROC_IE_SA_IP_VERSION_4;\n+\t} else if (ipsec->mode == RTE_SECURITY_IPSEC_SA_MODE_TUNNEL)\n \t\tctl->ipsec_mode = ROC_IE_SA_MODE_TUNNEL;\n \telse\n \t\treturn -EINVAL;\n@@ -548,7 +547,8 @@ cn9k_ipsec_inb_sa_create(struct cnxk_cpt_qp *qp,\n }\n \n static inline int\n-cn9k_ipsec_xform_verify(struct rte_security_ipsec_xform *ipsec)\n+cn9k_ipsec_xform_verify(struct rte_security_ipsec_xform *ipsec,\n+\t\t\tstruct rte_crypto_sym_xform *crypto)\n {\n \tif (ipsec->life.bytes_hard_limit != 0 ||\n \t ipsec->life.bytes_soft_limit != 0 ||\n@@ -556,6 +556,47 @@ cn9k_ipsec_xform_verify(struct rte_security_ipsec_xform *ipsec)\n \t ipsec->life.packets_soft_limit != 0)\n \t\treturn -ENOTSUP;\n \n+\tif (ipsec->mode == RTE_SECURITY_IPSEC_SA_MODE_TRANSPORT) {\n+\t\tenum rte_crypto_sym_xform_type type = crypto->type;\n+\n+\t\tif (type == RTE_CRYPTO_SYM_XFORM_AEAD) {\n+\t\t\tif ((crypto->aead.algo == RTE_CRYPTO_AEAD_AES_GCM) &&\n+\t\t\t (crypto->aead.key.length == 32)) {\n+\t\t\t\tplt_err(\"Transport mode AES-256-GCM is not supported\");\n+\t\t\t\treturn -ENOTSUP;\n+\t\t\t}\n+\t\t} else {\n+\t\t\tstruct rte_crypto_cipher_xform *cipher;\n+\t\t\tstruct rte_crypto_auth_xform *auth;\n+\n+\t\t\tif (crypto->type == RTE_CRYPTO_SYM_XFORM_CIPHER) {\n+\t\t\t\tcipher = &crypto->cipher;\n+\t\t\t\tauth = &crypto->next->auth;\n+\t\t\t} else {\n+\t\t\t\tcipher = &crypto->next->cipher;\n+\t\t\t\tauth = &crypto->auth;\n+\t\t\t}\n+\n+\t\t\tif ((cipher->algo == RTE_CRYPTO_CIPHER_AES_CBC) &&\n+\t\t\t (auth->algo == RTE_CRYPTO_AUTH_SHA256_HMAC)) {\n+\t\t\t\tplt_err(\"Transport mode AES-CBC SHA1 HMAC 256 is not supported\");\n+\t\t\t\treturn -ENOTSUP;\n+\t\t\t}\n+\n+\t\t\tif ((cipher->algo == RTE_CRYPTO_CIPHER_AES_CBC) &&\n+\t\t\t (auth->algo == RTE_CRYPTO_AUTH_SHA384_HMAC)) {\n+\t\t\t\tplt_err(\"Transport mode AES-CBC SHA2 HMAC 384 is not supported\");\n+\t\t\t\treturn -ENOTSUP;\n+\t\t\t}\n+\n+\t\t\tif ((cipher->algo == RTE_CRYPTO_CIPHER_AES_CBC) &&\n+\t\t\t (auth->algo == RTE_CRYPTO_AUTH_SHA512_HMAC)) {\n+\t\t\t\tplt_err(\"Transport mode AES-CBC SHA2 HMAC 512 is not supported\");\n+\t\t\t\treturn -ENOTSUP;\n+\t\t\t}\n+\t\t}\n+\t}\n+\n \treturn 0;\n }\n \n@@ -580,7 +621,7 @@ cn9k_ipsec_session_create(void *dev,\n \tif (ret)\n \t\treturn ret;\n \n-\tret = cn9k_ipsec_xform_verify(ipsec_xform);\n+\tret = cn9k_ipsec_xform_verify(ipsec_xform, crypto_xform);\n \tif (ret)\n \t\treturn ret;\n \n", "prefixes": [ "15/25" ] }{ "id": 104969, "url": "