Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105023/?format=api
{ "id": 105023, "url": "http://patchwork.dpdk.org/api/patches/105023/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/patch/1638953699-8512-1-git-send-email-juraj.linkes@pantheon.tech/", "project": { "id": 3, "url": "http://patchwork.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<1638953699-8512-1-git-send-email-juraj.linkes@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dts/1638953699-8512-1-git-send-email-juraj.linkes@pantheon.tech", "date": "2021-12-08T08:54:59", "name": "[v2] framework/tester: fix pylama errors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3bc90c10af237912168eacfae5e2ea3bb962104b", "submitter": { "id": 1626, "url": "http://patchwork.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dts/patch/1638953699-8512-1-git-send-email-juraj.linkes@pantheon.tech/mbox/", "series": [ { "id": 20891, "url": "http://patchwork.dpdk.org/api/series/20891/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/list/?series=20891", "date": "2021-12-08T08:54:59", "name": "[v2] framework/tester: fix pylama errors", "version": 2, "mbox": "http://patchwork.dpdk.org/series/20891/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105023/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/105023/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0B970A00C5;\n\tWed, 8 Dec 2021 09:55:04 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C3F3F410E8;\n\tWed, 8 Dec 2021 09:55:03 +0100 (CET)", "from lb.pantheon.sk (lb.pantheon.sk [46.229.239.20])\n by mails.dpdk.org (Postfix) with ESMTP id 12D1C406FF\n for <dts@dpdk.org>; Wed, 8 Dec 2021 09:55:03 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n by lb.pantheon.sk (Postfix) with ESMTP id C699F1376FB;\n Wed, 8 Dec 2021 09:55:01 +0100 (CET)", "from lb.pantheon.sk ([127.0.0.1])\n by localhost (lb.pantheon.sk [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id p_XEpOXNTOrQ; Wed, 8 Dec 2021 09:55:00 +0100 (CET)", "from service-node1.lab.pantheon.local (unknown [46.229.239.141])\n by lb.pantheon.sk (Postfix) with ESMTP id 6CADF1376EB;\n Wed, 8 Dec 2021 09:55:00 +0100 (CET)" ], "X-Virus-Scanned": "amavisd-new at siecit.sk", "From": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "To": "lijuan.tu@intel.com,\n\tohilyard@iol.unh.edu", "Cc": "dts@dpdk.org, =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "Subject": "[PATCH v2] framework/tester: fix pylama errors", "Date": "Wed, 8 Dec 2021 09:54:59 +0100", "Message-Id": "<1638953699-8512-1-git-send-email-juraj.linkes@pantheon.tech>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1637761862-4247-1-git-send-email-juraj.linkes@pantheon.tech>", "References": "<1637761862-4247-1-git-send-email-juraj.linkes@pantheon.tech>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "Pylama found the following errors:\nframework/tester.py:247: [E] E1136 Value 'self.duts' is unsubscriptable [pylint]\nframework/tester.py:259: [E] E1133 Non-iterable value self.duts is used in an iterating context [pylint]\nframework/tester.py:348: [E] E1101 Instance of 'Exception' has no 'message' member [pylint]\nframework/tester.py:372: [E] E1101 Instance of 'Exception' has no 'message' member [pylint]\n\nSigned-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>\n---\nLijuan, please add additional people to review if needed.\n---\n framework/tester.py | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/framework/tester.py b/framework/tester.py\nindex 9dba4e4d..cb3d2015 100644\n--- a/framework/tester.py\n+++ b/framework/tester.py\n@@ -85,7 +85,7 @@ class Tester(Crb):\n check_crb_python_version(self)\n \n self.bgProcIsRunning = False\n- self.duts = None\n+ self.duts = []\n self.inBg = 0\n self.scapyCmds = []\n self.bgCmds = []\n@@ -345,7 +345,7 @@ class Tester(Crb):\n self.send_expect(\"ifconfig %s up\" % itf, \"# \")\n \n except Exception as e:\n- self.logger.error(\" !!! Restore ITF: \" + e.message)\n+ self.logger.error(f\" !!! Restore ITF: {e}\")\n \n sleep(2)\n \n@@ -369,7 +369,7 @@ class Tester(Crb):\n self.enable_ipv6(itf)\n self.send_expect(\"ifconfig %s up\" % itf, \"# \")\n except Exception as e:\n- self.logger.error(\" !!! Restore ITF: \" + e.message)\n+ self.logger.error(f\" !!! Restore ITF: {e}\")\n \n sleep(2)\n \n", "prefixes": [ "v2" ] }