Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105041/?format=api
{ "id": 105041, "url": "http://patchwork.dpdk.org/api/patches/105041/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211209091342.27017-2-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211209091342.27017-2-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211209091342.27017-2-ndabilpuram@marvell.com", "date": "2021-12-09T09:13:36", "name": "[2/8] common/cnxk: use for loop in shaper profiles cleanup", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "94167efc191d645a3faf98a7615339993775b460", "submitter": { "id": 1202, "url": "http://patchwork.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211209091342.27017-2-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 20897, "url": "http://patchwork.dpdk.org/api/series/20897/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20897", "date": "2021-12-09T09:13:35", "name": "[1/8] common/cnxk: fix shift offset for tl3 length disable", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20897/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105041/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/105041/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C0B2FA00C2;\n\tThu, 9 Dec 2021 10:13:59 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 75D3441153;\n\tThu, 9 Dec 2021 10:13:55 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id DDC5A4114F\n for <dev@dpdk.org>; Thu, 9 Dec 2021 10:13:53 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 1B97bVtI009761\n for <dev@dpdk.org>; Thu, 9 Dec 2021 01:13:53 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3cudjt0anp-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 09 Dec 2021 01:13:53 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Thu, 9 Dec 2021 01:13:50 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Thu, 9 Dec 2021 01:13:50 -0800", "from hyd1588t430.marvell.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id D8CCB3F7054;\n Thu, 9 Dec 2021 01:13:48 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=OXdDSggP02nKgXDagyv+YW3IWIVjV4pD113LnQDJrDs=;\n b=N/ARAjEtJ6gyMEcx14iLhE8yLE9o1dOPEJJEUsjUX4KISnJgy+ALMvwfQNm1Jdu1uJic\n XQgWrW4elh57gdPdOXRvOZZrEceTksxlciiFPiZSKLYE/LxBcl0Mt4xBY9shWeqYWCge\n eJc/wO58Kfj3UUBITRlaWbOQkHfV/ojmjaNhcl8AH/8BjNmogtpkC9+kXDPF4Fc+pVeb\n pf7TXLYcJaUX0iPw+CmS5B0eetj00/ev8J41VzLy2NP+57beBIPgawfxsE5/BniIqt/s\n bx4pYFKhLs1vFLhbsoPrzJJvzFo53OtwGd3ltC9TITFsk/HWFUI63Vt3+dALkoitKc3P 6g==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Kiran\n Kumar K\" <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Satha Rao <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>, Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>,\n Shijith Thotton <sthotton@marvell.com>", "Subject": "[PATCH 2/8] common/cnxk: use for loop in shaper profiles cleanup", "Date": "Thu, 9 Dec 2021 14:43:36 +0530", "Message-ID": "<20211209091342.27017-2-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20211209091342.27017-1-ndabilpuram@marvell.com>", "References": "<20211209091342.27017-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "4XI0upMOH6miyX_1-EWKBbzNDEVM2KMd", "X-Proofpoint-GUID": "4XI0upMOH6miyX_1-EWKBbzNDEVM2KMd", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513\n definitions=2021-12-09_04,2021-12-08_01,2021-12-02_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\n\nIn shaper profiles cleanup, KW reports infinite loop although existing\nloop condition is alright. False positive may be due to tqh_first not\nchecked in loop, hence switching to FOREACH_SAFE to make KW happy.\n\nSigned-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\nSigned-off-by: Shijith Thotton <sthotton@marvell.com>\n---\n drivers/common/cnxk/roc_nix_tm.c | 8 ++++----\n drivers/common/cnxk/roc_platform.h | 2 ++\n 2 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_nix_tm.c b/drivers/common/cnxk/roc_nix_tm.c\nindex b3d8ebd..fe9e83f 100644\n--- a/drivers/common/cnxk/roc_nix_tm.c\n+++ b/drivers/common/cnxk/roc_nix_tm.c\n@@ -17,16 +17,16 @@ bitmap_ctzll(uint64_t slab)\n void\n nix_tm_clear_shaper_profiles(struct nix *nix)\n {\n-\tstruct nix_tm_shaper_profile *shaper_profile;\n+\tstruct nix_tm_shaper_profile *shaper_profile, *tmp;\n+\tstruct nix_tm_shaper_profile_list *list;\n \n-\tshaper_profile = TAILQ_FIRST(&nix->shaper_profile_list);\n-\twhile (shaper_profile != NULL) {\n+\tlist = &nix->shaper_profile_list;\n+\tPLT_TAILQ_FOREACH_SAFE(shaper_profile, list, shaper, tmp) {\n \t\tif (shaper_profile->ref_cnt)\n \t\t\tplt_warn(\"Shaper profile %u has non zero references\",\n \t\t\t\t shaper_profile->id);\n \t\tTAILQ_REMOVE(&nix->shaper_profile_list, shaper_profile, shaper);\n \t\tnix_tm_shaper_profile_free(shaper_profile);\n-\t\tshaper_profile = TAILQ_FIRST(&nix->shaper_profile_list);\n \t}\n }\n \ndiff --git a/drivers/common/cnxk/roc_platform.h b/drivers/common/cnxk/roc_platform.h\nindex 61d4781..3648e84 100644\n--- a/drivers/common/cnxk/roc_platform.h\n+++ b/drivers/common/cnxk/roc_platform.h\n@@ -19,6 +19,7 @@\n #include <rte_pci.h>\n #include <rte_spinlock.h>\n #include <rte_string_fns.h>\n+#include <rte_tailq.h>\n #include <rte_telemetry.h>\n \n #include \"roc_bits.h\"\n@@ -53,6 +54,7 @@\n #define BITMASK_ULL\t\t GENMASK_ULL\n #define PLT_ALIGN_CEIL\t\t RTE_ALIGN_CEIL\n #define PLT_INIT\t\t RTE_INIT\n+#define PLT_TAILQ_FOREACH_SAFE\t RTE_TAILQ_FOREACH_SAFE\n \n /** Divide ceil */\n #define PLT_DIV_CEIL(x, y)\t\t\t\\\n", "prefixes": [ "2/8" ] }