Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105044/?format=api
{ "id": 105044, "url": "http://patchwork.dpdk.org/api/patches/105044/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211209091342.27017-5-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211209091342.27017-5-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211209091342.27017-5-ndabilpuram@marvell.com", "date": "2021-12-09T09:13:39", "name": "[5/8] common/cnxk: always use single qint with NIX", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "bddfbcd9336368ae785494e4165103e1d3401fea", "submitter": { "id": 1202, "url": "http://patchwork.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211209091342.27017-5-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 20897, "url": "http://patchwork.dpdk.org/api/series/20897/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20897", "date": "2021-12-09T09:13:35", "name": "[1/8] common/cnxk: fix shift offset for tl3 length disable", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20897/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105044/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/105044/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9EFEEA00C2;\n\tThu, 9 Dec 2021 10:14:21 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 02AE9426F8;\n\tThu, 9 Dec 2021 10:14:05 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 83A9F426F0\n for <dev@dpdk.org>; Thu, 9 Dec 2021 10:14:03 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 1B97bk6b009998\n for <dev@dpdk.org>; Thu, 9 Dec 2021 01:14:03 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3cudjt0app-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 09 Dec 2021 01:14:02 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Thu, 9 Dec 2021 01:14:01 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Thu, 9 Dec 2021 01:14:00 -0800", "from hyd1588t430.marvell.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id A539B3F7054;\n Thu, 9 Dec 2021 01:13:58 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=qvv5dyP+M9MvC0qPjGODJfZ/RFsjL7Ag1T+DTyR1N1w=;\n b=d1/soCIxUdo61zcrWgRMkinLgQbke3IOeCwz5l8+LHCfcyvdCLxvslagc2HX8Mai4iMG\n PpIrikXkmbzTvEKySkRLjCCT4OnlueP2f4QxjftK8iUyj6VKuF90PJG/Kn6SMjX04AJi\n LV5sLqBdzi9dx9Ujt/Kx3asYRo2oe2hZBZ6EoXU+HWlTgmdnxiX/O9i6cASTcvkVku9C\n dty8CXnDmXZxanyXDPfMAR1BVo68ZTRmi0sZz4SSV1uXE46XzWKNRPP+6RDoo916+SsG\n sLQLughOcIZqUB4AVPXfs07HpWeBGOzRrzLNXzO1qMqq//RKMzkpWif1SPTz/7doirFD 0g==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Kiran\n Kumar K\" <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Satha Rao <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>, Harman Kalra <hkalra@marvell.com>", "Subject": "[PATCH 5/8] common/cnxk: always use single qint with NIX", "Date": "Thu, 9 Dec 2021 14:43:39 +0530", "Message-ID": "<20211209091342.27017-5-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20211209091342.27017-1-ndabilpuram@marvell.com>", "References": "<20211209091342.27017-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "_BmMFQtDYMNt70KFlTYqvnho92z88s0y", "X-Proofpoint-GUID": "_BmMFQtDYMNt70KFlTYqvnho92z88s0y", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513\n definitions=2021-12-09_04,2021-12-08_01,2021-12-02_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Harman Kalra <hkalra@marvell.com>\n\nAn errata exists whereby, in certain cases NIX may use an\nincorrect QINT_IDX for SQ interrupts. As a result, the\ninterrupt may not be delivered to software, or may not be\nassociated with the correct SQ.\nWhen NIX uses an incorrect QINT_IDX :\n1. NIX_LF_QINT(0..63)_CNT[COUNT] will be incremented for\nincorrect QINT.\n2. NIX_LF_QINT(0..63)_INT[INTR] will be set for incorrect\nQINT.\n\nSigned-off-by: Harman Kalra <hkalra@marvell.com>\n---\n drivers/common/cnxk/roc_nix_queue.c | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_nix_queue.c b/drivers/common/cnxk/roc_nix_queue.c\nindex c8c8401..4455fc1 100644\n--- a/drivers/common/cnxk/roc_nix_queue.c\n+++ b/drivers/common/cnxk/roc_nix_queue.c\n@@ -680,7 +680,11 @@ sq_cn9k_init(struct nix *nix, struct roc_nix_sq *sq, uint32_t rr_quantum,\n \taq->sq.sq_int_ena |= BIT(NIX_SQINT_MNQ_ERR);\n \n \t/* Many to one reduction */\n-\taq->sq.qint_idx = sq->qid % nix->qints;\n+\t/* Assigning QINT 0 to all the SQs, an errata exists where NIXTX can\n+\t * send incorrect QINT_IDX when reporting queue interrupt (QINT). This\n+\t * might result in software missing the interrupt.\n+\t */\n+\taq->sq.qint_idx = 0;\n }\n \n static int\n@@ -779,8 +783,11 @@ sq_init(struct nix *nix, struct roc_nix_sq *sq, uint32_t rr_quantum,\n \taq->sq.sq_int_ena |= BIT(NIX_SQINT_SEND_ERR);\n \taq->sq.sq_int_ena |= BIT(NIX_SQINT_MNQ_ERR);\n \n-\t/* Many to one reduction */\n-\taq->sq.qint_idx = sq->qid % nix->qints;\n+\t/* Assigning QINT 0 to all the SQs, an errata exists where NIXTX can\n+\t * send incorrect QINT_IDX when reporting queue interrupt (QINT). This\n+\t * might result in software missing the interrupt.\n+\t */\n+\taq->sq.qint_idx = 0;\n }\n \n static int\n", "prefixes": [ "5/8" ] }