Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105049/?format=api
{ "id": 105049, "url": "http://patchwork.dpdk.org/api/patches/105049/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211208095626.85026-1-kevinx.liu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211208095626.85026-1-kevinx.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211208095626.85026-1-kevinx.liu@intel.com", "date": "2021-12-08T09:56:26", "name": "net/ice: fix error forwarding IPv6 VXLAN packet", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dfc75b2744aa78cffaa7554ff133bdc4739d7505", "submitter": { "id": 2440, "url": "http://patchwork.dpdk.org/api/people/2440/?format=api", "name": "Kevin Liu", "email": "kevinx.liu@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211208095626.85026-1-kevinx.liu@intel.com/mbox/", "series": [ { "id": 20899, "url": "http://patchwork.dpdk.org/api/series/20899/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20899", "date": "2021-12-08T09:56:26", "name": "net/ice: fix error forwarding IPv6 VXLAN packet", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20899/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105049/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/105049/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A3A92A0093;\n\tThu, 9 Dec 2021 12:03:37 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 72A7741153;\n\tThu, 9 Dec 2021 12:03:32 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 6B342406FF\n for <dev@dpdk.org>; Wed, 8 Dec 2021 11:02:37 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Dec 2021 02:02:35 -0800", "from dpdk.cd.intel.com (HELO intel-cd-odc-kevin.cd.intel.com)\n ([10.240.178.210])\n by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Dec 2021 02:02:33 -0800" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10191\"; a=\"324057189\"", "E=Sophos;i=\"5.87,297,1631602800\"; d=\"scan'208\";a=\"324057189\"", "E=Sophos;i=\"5.87,297,1631602800\"; d=\"scan'208\";a=\"502993056\"" ], "From": "Kevin Liu <kevinx.liu@intel.com>", "To": "dev@dpdk.org", "Cc": "robinx.zhang@intel.com, jie1x.wang@intel.com,\n Kevin Liu <kevinx.liu@intel.com>", "Subject": "[PATCH] net/ice: fix error forwarding IPv6 VXLAN packet", "Date": "Wed, 8 Dec 2021 09:56:26 +0000", "Message-Id": "<20211208095626.85026-1-kevinx.liu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Thu, 09 Dec 2021 12:03:29 +0100", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In ice_txd_enable_offload(), when set tunnel packet Tx checksum\noffload enable, td_offset should be set with outer l2/l3 len instead\nof inner l2/l3 len.\n\nThis patch fix the bug that the checksum engine can forward tunnle\npackets.\n\nFixes: 28f9002ab67f (\"net/ice: add Tx AVX512 offload path\")\n\nSigned-off-by: Kevin Liu <kevinx.liu@intel.com>\n---\n drivers/net/ice/ice_rxtx_vec_common.h | 52 +++++++++++++++++++--------\n 1 file changed, 37 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_rxtx_vec_common.h b/drivers/net/ice/ice_rxtx_vec_common.h\nindex dfe60c81d9..8ff01046e1 100644\n--- a/drivers/net/ice/ice_rxtx_vec_common.h\n+++ b/drivers/net/ice/ice_rxtx_vec_common.h\n@@ -364,23 +364,45 @@ ice_txd_enable_offload(struct rte_mbuf *tx_pkt,\n \tuint32_t td_offset = 0;\n \n \t/* Tx Checksum Offload */\n-\t/* SET MACLEN */\n-\ttd_offset |= (tx_pkt->l2_len >> 1) <<\n+\t/*Tunnel package usage outer len enable L2/L3 checksum offload*/\n+\tif (ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) {\n+\t\t/* SET MACLEN */\n+\t\ttd_offset |= (tx_pkt->outer_l2_len >> 1) <<\n \t\t\tICE_TX_DESC_LEN_MACLEN_S;\n \n-\t/* Enable L3 checksum offload */\n-\tif (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {\n-\t\ttd_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4_CSUM;\n-\t\ttd_offset |= (tx_pkt->l3_len >> 2) <<\n-\t\t\tICE_TX_DESC_LEN_IPLEN_S;\n-\t} else if (ol_flags & RTE_MBUF_F_TX_IPV4) {\n-\t\ttd_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4;\n-\t\ttd_offset |= (tx_pkt->l3_len >> 2) <<\n-\t\t\tICE_TX_DESC_LEN_IPLEN_S;\n-\t} else if (ol_flags & RTE_MBUF_F_TX_IPV6) {\n-\t\ttd_cmd |= ICE_TX_DESC_CMD_IIPT_IPV6;\n-\t\ttd_offset |= (tx_pkt->l3_len >> 2) <<\n-\t\t\tICE_TX_DESC_LEN_IPLEN_S;\n+\t\t/* Enable L3 checksum offload */\n+\t\tif (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {\n+\t\t\ttd_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4_CSUM;\n+\t\t\ttd_offset |= (tx_pkt->outer_l3_len >> 2) <<\n+\t\t\t\tICE_TX_DESC_LEN_IPLEN_S;\n+\t\t} else if (ol_flags & RTE_MBUF_F_TX_IPV4) {\n+\t\t\ttd_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4;\n+\t\t\ttd_offset |= (tx_pkt->outer_l3_len >> 2) <<\n+\t\t\t\tICE_TX_DESC_LEN_IPLEN_S;\n+\t\t} else if (ol_flags & RTE_MBUF_F_TX_IPV6) {\n+\t\t\ttd_cmd |= ICE_TX_DESC_CMD_IIPT_IPV6;\n+\t\t\ttd_offset |= (tx_pkt->outer_l3_len >> 2) <<\n+\t\t\t\tICE_TX_DESC_LEN_IPLEN_S;\n+\t\t}\n+\t} else {\n+\t\t/* SET MACLEN */\n+\t\ttd_offset |= (tx_pkt->l2_len >> 1) <<\n+\t\t\tICE_TX_DESC_LEN_MACLEN_S;\n+\n+\t\t/* Enable L3 checksum offload */\n+\t\tif (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) {\n+\t\t\ttd_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4_CSUM;\n+\t\t\ttd_offset |= (tx_pkt->l3_len >> 2) <<\n+\t\t\t\tICE_TX_DESC_LEN_IPLEN_S;\n+\t\t} else if (ol_flags & RTE_MBUF_F_TX_IPV4) {\n+\t\t\ttd_cmd |= ICE_TX_DESC_CMD_IIPT_IPV4;\n+\t\t\ttd_offset |= (tx_pkt->l3_len >> 2) <<\n+\t\t\t\tICE_TX_DESC_LEN_IPLEN_S;\n+\t\t} else if (ol_flags & RTE_MBUF_F_TX_IPV6) {\n+\t\t\ttd_cmd |= ICE_TX_DESC_CMD_IIPT_IPV6;\n+\t\t\ttd_offset |= (tx_pkt->l3_len >> 2) <<\n+\t\t\t\tICE_TX_DESC_LEN_IPLEN_S;\n+\t\t}\n \t}\n \n \t/* Enable L4 checksum offloads */\n", "prefixes": [] }