Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105050/?format=api
{ "id": 105050, "url": "http://patchwork.dpdk.org/api/patches/105050/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211209162727.12295-1-sean.morrissey@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211209162727.12295-1-sean.morrissey@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211209162727.12295-1-sean.morrissey@intel.com", "date": "2021-12-09T16:27:27", "name": "[v1] app/testpmd: fix dereference before null check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "abe99cb9e141fe0005c7b8ed4a91b1f3a0d52087", "submitter": { "id": 1359, "url": "http://patchwork.dpdk.org/api/people/1359/?format=api", "name": "Sean Morrissey", "email": "sean.morrissey@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211209162727.12295-1-sean.morrissey@intel.com/mbox/", "series": [ { "id": 20900, "url": "http://patchwork.dpdk.org/api/series/20900/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20900", "date": "2021-12-09T16:27:27", "name": "[v1] app/testpmd: fix dereference before null check", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20900/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105050/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/105050/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A108EA0093;\n\tThu, 9 Dec 2021 17:29:29 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6F846410F3;\n\tThu, 9 Dec 2021 17:29:29 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id AEAEF40041;\n Thu, 9 Dec 2021 17:29:27 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Dec 2021 08:28:01 -0800", "from silpixa00401215.ir.intel.com ([10.55.128.96])\n by orsmga001.jf.intel.com with ESMTP; 09 Dec 2021 08:27:45 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1639067368; x=1670603368;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=sgmBDMEK5q+XWeTXHOq14hUwmgFGG1Qo0IqVU4lPHfc=;\n b=I5VcM+DvmOLIoAr6O8DyZLP/1zDMlMAFc8Amqo+F5qmWh+VMfkdoQlRD\n /8L63ztPyfKvONNElrc8LtCmKA9cZzZ8xM++S8wX7zi1psYkXb7TsP9F0\n Oc6T31rZ5nlxJqE0VCAsfa0v4UtNyg1+RynjWXs1ojhKgb1O866bV6S/D\n aMyUvROgqkF3sKVRpGEa+5iTz6tWhfzoBXIRb7ye+Cvx8eLTRX5fwfyAh\n Zr5npSTkzYIARNKBbH9dhuNGQyn6RCOOZfkvicX25iz68irHfAgH6OZKd\n tYctMucpsIZYZ8QtHdwRE4YjI69wCSsr/JehaixJNJVMt8ydV0bgfe7uN w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10193\"; a=\"238366502\"", "E=Sophos;i=\"5.88,192,1635231600\"; d=\"scan'208\";a=\"238366502\"", "E=Sophos;i=\"5.88,192,1635231600\"; d=\"scan'208\";a=\"543650521\"" ], "X-ExtLoop1": "1", "From": "Sean Morrissey <sean.morrissey@intel.com>", "To": "Ori Kam <orika@nvidia.com>, Xiaoyun Li <xiaoyun.li@intel.com>,\n Aman Singh <aman.deep.singh@intel.com>", "Cc": "dev@dpdk.org, Sean Morrissey <sean.morrissey@intel.com>, stable@dpdk.org,\n wei.zhao1@intel.com", "Subject": "[PATCH v1] app/testpmd: fix dereference before null check", "Date": "Thu, 9 Dec 2021 16:27:27 +0000", "Message-Id": "<20211209162727.12295-1-sean.morrissey@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Assign 'left' variable only after null check on 'size'\nas function returns if 'size' is null.\n\nCoverity issue: 374381\nFixes: 169a9fed1f4 (\"app/testpmd: fix hex string parser support for flow API\")\nCc: stable@dpdk.org\nCc: wei.zhao1@intel.com\n\nSigned-off-by: Sean Morrissey <sean.morrissey@intel.com>\n---\n app/test-pmd/cmdline_flow.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex bbe3dc0115..5bb7abcced 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -7702,7 +7702,6 @@ parse_string(struct context *ctx, const struct token *token,\n static int\n parse_hex_string(const char *src, uint8_t *dst, uint32_t *size)\n {\n-\tuint32_t left = *size;\n \tconst uint8_t *head = dst;\n \n \t/* Check input parameters */\n@@ -7712,6 +7711,8 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size)\n \t\t(*size == 0))\n \t\treturn -1;\n \n+\tuint32_t left = *size;\n+\n \t/* Convert chars to bytes */\n \twhile (left) {\n \t\tchar tmp[3], *end = tmp;\n", "prefixes": [ "v1" ] }