Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105313/?format=api
{ "id": 105313, "url": "http://patchwork.dpdk.org/api/patches/105313/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1640116650-3475-3-git-send-email-rsanford@akamai.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1640116650-3475-3-git-send-email-rsanford@akamai.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1640116650-3475-3-git-send-email-rsanford@akamai.com", "date": "2021-12-21T19:57:24", "name": "[v2,2/8] net/bonding: fix bonded dev configuring slave dev", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "6ccadb7810a5cec28ff8c9a5998d4fcf1a2310a2", "submitter": { "id": 7, "url": "http://patchwork.dpdk.org/api/people/7/?format=api", "name": "Robert Sanford", "email": "rsanford2@gmail.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1640116650-3475-3-git-send-email-rsanford@akamai.com/mbox/", "series": [ { "id": 21001, "url": "http://patchwork.dpdk.org/api/series/21001/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21001", "date": "2021-12-21T19:57:22", "name": "net/bonding: fixes and LACP short timeout", "version": 2, "mbox": "http://patchwork.dpdk.org/series/21001/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105313/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/105313/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EA6E3A034C;\n\tTue, 21 Dec 2021 20:58:18 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2D95241101;\n\tTue, 21 Dec 2021 20:58:08 +0100 (CET)", "from mail-qt1-f171.google.com (mail-qt1-f171.google.com\n [209.85.160.171])\n by mails.dpdk.org (Postfix) with ESMTP id 7C9454003C\n for <dev@dpdk.org>; Tue, 21 Dec 2021 20:58:05 +0100 (CET)", "by mail-qt1-f171.google.com with SMTP id t11so13949925qtw.3\n for <dev@dpdk.org>; Tue, 21 Dec 2021 11:58:05 -0800 (PST)", "from ubuntu.localdomain\n (99-153-167-175.lightspeed.ftldfl.sbcglobal.net. [99.153.167.175])\n by smtp.gmail.com with ESMTPSA id h3sm14684401qko.78.2021.12.21.11.58.04\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Tue, 21 Dec 2021 11:58:04 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=4wHsRwq95ZrXDb40QSqc4h0hEj5ymKpB9KPN2TKm8f4=;\n b=PzFWlgiB0ZH2Xwkt7y94ba0QRbR0V5lQZk0eMPa54eiS582Ie2WGE9NJmbFElgzKyW\n JyHjoPTmsw3k7n0kIH5CqfRfKDIOOYQskMGlTjsBA3mSn2X7xWZyt1rfKB1b/4vKZvdE\n JBoOmT/r9UPZbJsYx5kbsi43Nsqsu2RFeEAbczEBrkSGT+7trGnqCmZQ35xU2/OLONd8\n czCZTXaxJNLdQCivUUqcAUidegHAPhRkxOqhC7JAciGwL+6HXFza1rp7LbOc7NFehDtV\n 82IKPyOe1Axy1L0kpd+Tb28oBja6oVSg7Nm8kURcva5McKvTf7Nwgws0vUUf2aYdsVi5\n 6Z9g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=4wHsRwq95ZrXDb40QSqc4h0hEj5ymKpB9KPN2TKm8f4=;\n b=WqUAp2bARYl5nOUoQiu6sJgoExmeH9JM4yS40x2mXoVbA1LghEqA1E8tE4Rq+cd9FV\n wxQcm7P9Jx4gZ8sQcKElZWib46kQ9TBayXUgTprbNOzfpmL2NrY6SRolMiRYzZe3gf5p\n AP4QeBpTgxkZIHU6hHixurfiteIIq9tC6vK0Tj9+yv4VNdgtZyZqLyvu+QzEsnmh0mXb\n xMy4cH7G+CDYw/8rg5VT5Y9n7uu33K/+RhnzHG43WIqwP6CKyTah0kJm/CzKrIy4C96b\n g0NgyGWJ8ODqSye9o9+5lSofrhERE6krxX/N8ge3APqVZHQd5EdwwzX0SIqbfFX3YseG\n 6qvA==", "X-Gm-Message-State": "AOAM5314xNjeMRG5cZqPsrlNkO6kWajITt+duXFmKQbKBG4gm90uxg+V\n HGFzXSCbh7zahAXmrcgbwr2Hebex+bxpsQ==", "X-Google-Smtp-Source": "\n ABdhPJynfZAek2t+dCNee8TBpS0CUJQTqrpitJaLgMPcO7IdwZRIoQrBAWa1lP8eIIWpm1MIkxYClA==", "X-Received": "by 2002:a05:622a:1194:: with SMTP id\n m20mr3616974qtk.65.1640116684891;\n Tue, 21 Dec 2021 11:58:04 -0800 (PST)", "From": "Robert Sanford <rsanford2@gmail.com>", "X-Google-Original-From": "Robert Sanford <rsanford@akamai.com>", "To": "dev@dpdk.org", "Cc": "chas3@att.com,\n\thumin29@huawei.com,\n\tbruce.richardson@intel.com", "Subject": "[PATCH v2 2/8] net/bonding: fix bonded dev configuring slave dev", "Date": "Tue, 21 Dec 2021 14:57:24 -0500", "Message-Id": "<1640116650-3475-3-git-send-email-rsanford@akamai.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1640116650-3475-1-git-send-email-rsanford@akamai.com>", "References": "<1639592401-56845-2-git-send-email-rsanford@akamai.com>\n <1640116650-3475-1-git-send-email-rsanford@akamai.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- Replace directly overwriting of slave port's private rte_eth_conf\n by copying it, and then updating it via rte_eth_dev_configure().\n\nSigned-off-by: Robert Sanford <rsanford@akamai.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 30 ++++++++++++++++--------------\n 1 file changed, 16 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex f6003b0..b9e7439 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -1691,6 +1691,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,\n \tstruct rte_flow_error flow_error;\n \n \tstruct bond_dev_private *internals = bonded_eth_dev->data->dev_private;\n+\tstruct rte_eth_conf dev_conf;\n \n \t/* Stop slave */\n \terrval = rte_eth_dev_stop(slave_eth_dev->data->port_id);\n@@ -1698,34 +1699,36 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,\n \t\tRTE_BOND_LOG(ERR, \"rte_eth_dev_stop: port %u, err (%d)\",\n \t\t\t slave_eth_dev->data->port_id, errval);\n \n+\t/* Start with a copy of slave's current rte_eth_conf. */\n+\tdev_conf = slave_eth_dev->data->dev_conf;\n+\tdev_conf.rx_adv_conf.rss_conf.rss_key = NULL;\n+\n \t/* Enable interrupts on slave device if supported */\n-\tif (slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)\n-\t\tslave_eth_dev->data->dev_conf.intr_conf.lsc = 1;\n+\tdev_conf.intr_conf.lsc =\n+\t\t(slave_eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) ? 1 : 0;\n \n \t/* If RSS is enabled for bonding, try to enable it for slaves */\n \tif (bonded_eth_dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS_FLAG) {\n \t\t/* rss_key won't be empty if RSS is configured in bonded dev */\n-\t\tslave_eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key_len =\n-\t\t\t\t\tinternals->rss_key_len;\n-\t\tslave_eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_key =\n-\t\t\t\t\tinternals->rss_key;\n+\t\tdev_conf.rx_adv_conf.rss_conf.rss_key_len =\n+\t\t\t\tinternals->rss_key_len;\n+\t\tdev_conf.rx_adv_conf.rss_conf.rss_key = internals->rss_key;\n \n-\t\tslave_eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf =\n+\t\tdev_conf.rx_adv_conf.rss_conf.rss_hf =\n \t\t\t\tbonded_eth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf;\n-\t\tslave_eth_dev->data->dev_conf.rxmode.mq_mode =\n+\t\tdev_conf.rxmode.mq_mode =\n \t\t\t\tbonded_eth_dev->data->dev_conf.rxmode.mq_mode;\n \t}\n \n \tif (bonded_eth_dev->data->dev_conf.rxmode.offloads &\n \t\t\tRTE_ETH_RX_OFFLOAD_VLAN_FILTER)\n-\t\tslave_eth_dev->data->dev_conf.rxmode.offloads |=\n+\t\tdev_conf.rxmode.offloads |=\n \t\t\t\tRTE_ETH_RX_OFFLOAD_VLAN_FILTER;\n \telse\n-\t\tslave_eth_dev->data->dev_conf.rxmode.offloads &=\n+\t\tdev_conf.rxmode.offloads &=\n \t\t\t\t~RTE_ETH_RX_OFFLOAD_VLAN_FILTER;\n \n-\tslave_eth_dev->data->dev_conf.rxmode.mtu =\n-\t\t\tbonded_eth_dev->data->dev_conf.rxmode.mtu;\n+\tdev_conf.rxmode.mtu = bonded_eth_dev->data->dev_conf.rxmode.mtu;\n \n \tnb_rx_queues = bonded_eth_dev->data->nb_rx_queues;\n \tnb_tx_queues = bonded_eth_dev->data->nb_tx_queues;\n@@ -1747,8 +1750,7 @@ slave_configure(struct rte_eth_dev *bonded_eth_dev,\n \n \t/* Configure device */\n \terrval = rte_eth_dev_configure(slave_eth_dev->data->port_id,\n-\t\t\tnb_rx_queues, nb_tx_queues,\n-\t\t\t&(slave_eth_dev->data->dev_conf));\n+\t\t\tnb_rx_queues, nb_tx_queues, &dev_conf);\n \tif (errval != 0) {\n \t\tRTE_BOND_LOG(ERR, \"Cannot configure slave device: port %u, err (%d)\",\n \t\t\t\tslave_eth_dev->data->port_id, errval);\n", "prefixes": [ "v2", "2/8" ] }