Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105314/?format=api
{ "id": 105314, "url": "http://patchwork.dpdk.org/api/patches/105314/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1640116650-3475-4-git-send-email-rsanford@akamai.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1640116650-3475-4-git-send-email-rsanford@akamai.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1640116650-3475-4-git-send-email-rsanford@akamai.com", "date": "2021-12-21T19:57:25", "name": "[v2,3/8] net/bonding: change mbuf pool and ring creation", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "0b5e643dce4fd77d0c649fbcb8233874a07f9fb1", "submitter": { "id": 7, "url": "http://patchwork.dpdk.org/api/people/7/?format=api", "name": "Robert Sanford", "email": "rsanford2@gmail.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1640116650-3475-4-git-send-email-rsanford@akamai.com/mbox/", "series": [ { "id": 21001, "url": "http://patchwork.dpdk.org/api/series/21001/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21001", "date": "2021-12-21T19:57:22", "name": "net/bonding: fixes and LACP short timeout", "version": 2, "mbox": "http://patchwork.dpdk.org/series/21001/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105314/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/105314/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 56B72A034C;\n\tTue, 21 Dec 2021 20:58:24 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2D0F841147;\n\tTue, 21 Dec 2021 20:58:09 +0100 (CET)", "from mail-qt1-f177.google.com (mail-qt1-f177.google.com\n [209.85.160.177])\n by mails.dpdk.org (Postfix) with ESMTP id 3A0DB406A2\n for <dev@dpdk.org>; Tue, 21 Dec 2021 20:58:06 +0100 (CET)", "by mail-qt1-f177.google.com with SMTP id a1so13896655qtx.11\n for <dev@dpdk.org>; Tue, 21 Dec 2021 11:58:06 -0800 (PST)", "from ubuntu.localdomain\n (99-153-167-175.lightspeed.ftldfl.sbcglobal.net. [99.153.167.175])\n by smtp.gmail.com with ESMTPSA id h3sm14684401qko.78.2021.12.21.11.58.04\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Tue, 21 Dec 2021 11:58:05 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references;\n bh=//DyR/b5J0MzHHvenuvPZsKSZMid4AwTriLPC1Lsw04=;\n b=HkxRD/42bEn0AtqBsrPVsLbZiVDPwke/llum+wrNGTmNU9goY9BnUoQsJwplsqGxjG\n G91CFP2PJXIRVNM09gYktjCTvU7zE+uonKXxBEsUE3FAjncXBCK+OZxneB6oEpt/3nF/\n 1Pk+qRIb2JqcQ1RcchcH9C1ClWM3wVSqOYtrh3ABRWzE11HGoGX/Sc8bnsRNZ2AiILFZ\n bcNqgm9Rw4M/pzvJlbchZOKcHp0hpLrG5/GuUVcHNLWTsPyVOdjNFi5CRYAUfsqDAbeq\n e8Z3V8BRBw0BSPgPz/MLvmur/YLOjK2NNQWBHe4JZ6wa/t/It6aJykPYKxXNQlBxwqf8\n r8TQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references;\n bh=//DyR/b5J0MzHHvenuvPZsKSZMid4AwTriLPC1Lsw04=;\n b=MgZocUSv184BLfZSjr7fpa23xa4PzHqRAlZvNXZE86hn2B9CFfl0uXC3k/wy9oqJQB\n i5jO8a30DlST5siEAnT/lhfXMFED7y+xrmrjsVATDF+g68K3hUXv7zcLwP/GYVWQJp0P\n jRXd8EcKju0PuzKK0Hw5EjD8VBvXvKhzx/iu4UJoz6mM0fjKmviaKQgiNFnBKAmfiJks\n wAZfKwi3sRTaf6pQtEGiivg9TUsoTHLO0quyiAgvGwj/M00SD1PP7IpT1aNNqWTnQ91t\n qtt4XokBB9IR9P+/VsZYKVVCrZBm7EIc+4DWHkX9ExsXNKgo562mtCjr+/0dEVS6oG1X\n gRkQ==", "X-Gm-Message-State": "AOAM532gJg5H6qiss28jVBPk9mLrnEtiuphQ9eBFIxwh3qPX35gU/cjI\n HnQFlM7TGTnex717+9o5VspcQ2RlntioUQ==", "X-Google-Smtp-Source": "\n ABdhPJxmI6Ev464DhjBLMd6EuHKIYOqdB6TyVsSggnfrEKMXog0ZejlR9NiSh/mFHGrTBf7BZQ6neQ==", "X-Received": "by 2002:a05:622a:50d:: with SMTP id\n l13mr3721677qtx.75.1640116685625;\n Tue, 21 Dec 2021 11:58:05 -0800 (PST)", "From": "Robert Sanford <rsanford2@gmail.com>", "X-Google-Original-From": "Robert Sanford <rsanford@akamai.com>", "To": "dev@dpdk.org", "Cc": "chas3@att.com,\n\thumin29@huawei.com,\n\tbruce.richardson@intel.com", "Subject": "[PATCH v2 3/8] net/bonding: change mbuf pool and ring creation", "Date": "Tue, 21 Dec 2021 14:57:25 -0500", "Message-Id": "<1640116650-3475-4-git-send-email-rsanford@akamai.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1640116650-3475-1-git-send-email-rsanford@akamai.com>", "References": "<1639592401-56845-2-git-send-email-rsanford@akamai.com>\n <1640116650-3475-1-git-send-email-rsanford@akamai.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- Turn off mbuf pool caching to avoid mbufs lingering in pool caches.\n At most, we transmit one LACPDU per second, per port.\n LACP tx_machine() performs the \"get\", and runs in the context of the\n interrupt thread (no default cache).\n PMD typically \"puts\" no more than one LACPDU per second, on average.\n- Create rings with RING_F_EXACT_SZ flag, so that they are the desired\n size, and not one less than requested.\n\nSigned-off-by: Robert Sanford <rsanford@akamai.com>\n---\n drivers/net/bonding/rte_eth_bond_8023ad.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c\nindex 43231bc..9ed2a46 100644\n--- a/drivers/net/bonding/rte_eth_bond_8023ad.c\n+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c\n@@ -1101,9 +1101,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev,\n \t}\n \n \tsnprintf(mem_name, RTE_DIM(mem_name), \"slave_port%u_pool\", slave_id);\n-\tport->mbuf_pool = rte_pktmbuf_pool_create(mem_name, total_tx_desc,\n-\t\tRTE_MEMPOOL_CACHE_MAX_SIZE >= 32 ?\n-\t\t\t32 : RTE_MEMPOOL_CACHE_MAX_SIZE,\n+\tport->mbuf_pool = rte_pktmbuf_pool_create(mem_name, total_tx_desc, 0,\n \t\t0, element_size, socket_id);\n \n \t/* Any memory allocation failure in initialization is critical because\n@@ -1115,7 +1113,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev,\n \n \tsnprintf(mem_name, RTE_DIM(mem_name), \"slave_%u_rx\", slave_id);\n \tport->rx_ring = rte_ring_create(mem_name,\n-\t\t\trte_align32pow2(BOND_MODE_8023AX_SLAVE_RX_PKTS), socket_id, 0);\n+\t\tBOND_MODE_8023AX_SLAVE_RX_PKTS, socket_id, RING_F_EXACT_SZ);\n \n \tif (port->rx_ring == NULL) {\n \t\trte_panic(\"Slave %u: Failed to create rx ring '%s': %s\\n\", slave_id,\n@@ -1125,7 +1123,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev,\n \t/* TX ring is at least one pkt longer to make room for marker packet. */\n \tsnprintf(mem_name, RTE_DIM(mem_name), \"slave_%u_tx\", slave_id);\n \tport->tx_ring = rte_ring_create(mem_name,\n-\t\t\trte_align32pow2(BOND_MODE_8023AX_SLAVE_TX_PKTS + 1), socket_id, 0);\n+\t\tBOND_MODE_8023AX_SLAVE_TX_PKTS + 1, socket_id, RING_F_EXACT_SZ);\n \n \tif (port->tx_ring == NULL) {\n \t\trte_panic(\"Slave %u: Failed to create tx ring '%s': %s\\n\", slave_id,\n", "prefixes": [ "v2", "3/8" ] }