Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105323/?format=api
{ "id": 105323, "url": "http://patchwork.dpdk.org/api/patches/105323/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211222081138.1617225-1-junfeng.guo@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211222081138.1617225-1-junfeng.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211222081138.1617225-1-junfeng.guo@intel.com", "date": "2021-12-22T08:11:38", "name": "[v3] net/ice: fix pattern check for FDIR parser", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8838cb111876c8922d3ef824a747ca90d123d6ff", "submitter": { "id": 1785, "url": "http://patchwork.dpdk.org/api/people/1785/?format=api", "name": "Junfeng Guo", "email": "junfeng.guo@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211222081138.1617225-1-junfeng.guo@intel.com/mbox/", "series": [ { "id": 21005, "url": "http://patchwork.dpdk.org/api/series/21005/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21005", "date": "2021-12-22T08:11:38", "name": "[v3] net/ice: fix pattern check for FDIR parser", "version": 3, "mbox": "http://patchwork.dpdk.org/series/21005/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105323/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/105323/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8481EA034E;\n\tWed, 22 Dec 2021 09:18:36 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1711B40DDA;\n\tWed, 22 Dec 2021 09:18:36 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 0B4B540687;\n Wed, 22 Dec 2021 09:18:33 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Dec 2021 00:18:33 -0800", "from dpdk-junfengguo-v1.sh.intel.com ([10.67.119.216])\n by fmsmga001.fm.intel.com with ESMTP; 22 Dec 2021 00:18:30 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1640161114; x=1671697114;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=NhvD4Y8Yq5Fn+S1iiD1MsXq3YkZrfnOYXvqiDxVxeDw=;\n b=gIPInU4JgeObWfvZX5EpRMSsbuyqyfCWoTEVRvdkqUPLJerwaR5aGuCJ\n sl6gvsIx2GRYhDSqFBMItT7MW3z3YN7emzD+aNmB3Lx/Dnx6SKYHmxjq9\n Y8iCzk/rvOF6wYTX6jdCCIzXyfDjwTyMmDvl9PYiky+KO7T9ZZGMFacks\n oSy1LErDofrtJKEqFMoQHtdtvnFAColivNvwaGIwgnTPsCdsXroMTh4EZ\n O+W3O0vTFGn5wW4AjP9XiZBqqj/qpCJ13Qpp+YlY0ajyc8Elv0ZwgVHew\n 8ZUr3diSo67i4a4YhAHeN+r1x3ezVFMSTlF8AFEthLDHV04+sqQvLXac6 g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10205\"; a=\"240380688\"", "E=Sophos;i=\"5.88,225,1635231600\"; d=\"scan'208\";a=\"240380688\"", "E=Sophos;i=\"5.88,225,1635231600\"; d=\"scan'208\";a=\"664206879\"" ], "X-ExtLoop1": "1", "From": "Junfeng Guo <junfeng.guo@intel.com>", "To": "qi.z.zhang@intel.com,\n\tjingjing.wu@intel.com,\n\tbeilei.xing@intel.com", "Cc": "dev@dpdk.org, stable@dpdk.org, ferruh.yigit@intel.com,\n junfeng.guo@intel.com", "Subject": "[PATCH v3] net/ice: fix pattern check for FDIR parser", "Date": "Wed, 22 Dec 2021 16:11:38 +0800", "Message-Id": "<20211222081138.1617225-1-junfeng.guo@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211222080852.1604018-1-junfeng.guo@intel.com>", "References": "<20211222080852.1604018-1-junfeng.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "FDIR rules with masks are not supported in current code. Thus add\npattern check for IPv4/UDP/TCP/SCTP addr/port to terminate the FDIR\nprogramming stage.\n\nFixes: 1b71ed2cdd5d (\"net/ice: refactor flow pattern parser\")\nCc: stable@dpdk.org\n\nSigned-off-by: Junfeng Guo <junfeng.guo@intel.com>\n---\n drivers/net/ice/ice_fdir_filter.c | 32 +++++++++++++++++++++++++++++++\n 1 file changed, 32 insertions(+)", "diff": "diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c\nindex 13a2ac42df..287032a6a7 100644\n--- a/drivers/net/ice/ice_fdir_filter.c\n+++ b/drivers/net/ice/ice_fdir_filter.c\n@@ -2037,6 +2037,14 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,\n \t\t\t\treturn -rte_errno;\n \t\t\t}\n \n+\t\t\t/* Mask for IPv4 src/dst addrs not supported */\n+\t\t\tif (!ipv4_mask->hdr.src_addr &&\n+\t\t\t\tipv4_mask->hdr.src_addr != UINT32_MAX)\n+\t\t\t\treturn -rte_errno;\n+\t\t\tif (!ipv4_mask->hdr.dst_addr &&\n+\t\t\t\tipv4_mask->hdr.dst_addr != UINT32_MAX)\n+\t\t\t\treturn -rte_errno;\n+\n \t\t\tif (ipv4_mask->hdr.dst_addr == UINT32_MAX)\n \t\t\t\t*input_set |= ICE_INSET_IPV4_DST;\n \t\t\tif (ipv4_mask->hdr.src_addr == UINT32_MAX)\n@@ -2178,6 +2186,14 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,\n \t\t\t\treturn -rte_errno;\n \t\t\t}\n \n+\t\t\t/* Mask for TCP src/dst ports not supported */\n+\t\t\tif (!tcp_mask->hdr.src_port &&\n+\t\t\t\ttcp_mask->hdr.src_port != UINT16_MAX)\n+\t\t\t\treturn -rte_errno;\n+\t\t\tif (!tcp_mask->hdr.dst_port &&\n+\t\t\t\ttcp_mask->hdr.dst_port != UINT16_MAX)\n+\t\t\t\treturn -rte_errno;\n+\n \t\t\tif (tcp_mask->hdr.src_port == UINT16_MAX)\n \t\t\t\t*input_set |= ICE_INSET_TCP_SRC_PORT;\n \t\t\tif (tcp_mask->hdr.dst_port == UINT16_MAX)\n@@ -2217,6 +2233,14 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,\n \t\t\t\treturn -rte_errno;\n \t\t\t}\n \n+\t\t\t/* Mask for UDP src/dst ports not supported */\n+\t\t\tif (!udp_mask->hdr.src_port &&\n+\t\t\t\tudp_mask->hdr.src_port != UINT16_MAX)\n+\t\t\t\treturn -rte_errno;\n+\t\t\tif (!udp_mask->hdr.dst_port &&\n+\t\t\t\tudp_mask->hdr.dst_port != UINT16_MAX)\n+\t\t\t\treturn -rte_errno;\n+\n \t\t\tif (udp_mask->hdr.src_port == UINT16_MAX)\n \t\t\t\t*input_set |= ICE_INSET_UDP_SRC_PORT;\n \t\t\tif (udp_mask->hdr.dst_port == UINT16_MAX)\n@@ -2254,6 +2278,14 @@ ice_fdir_parse_pattern(__rte_unused struct ice_adapter *ad,\n \t\t\t\treturn -rte_errno;\n \t\t\t}\n \n+\t\t\t/* Mask for SCTP src/dst ports not supported */\n+\t\t\tif (!sctp_mask->hdr.src_port &&\n+\t\t\t\tsctp_mask->hdr.src_port != UINT16_MAX)\n+\t\t\t\treturn -rte_errno;\n+\t\t\tif (!sctp_mask->hdr.dst_port &&\n+\t\t\t\tsctp_mask->hdr.dst_port != UINT16_MAX)\n+\t\t\t\treturn -rte_errno;\n+\n \t\t\tif (sctp_mask->hdr.src_port == UINT16_MAX)\n \t\t\t\t*input_set |= ICE_INSET_SCTP_SRC_PORT;\n \t\t\tif (sctp_mask->hdr.dst_port == UINT16_MAX)\n", "prefixes": [ "v3" ] }