Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105327/?format=api
{ "id": 105327, "url": "http://patchwork.dpdk.org/api/patches/105327/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1640190018-7025-1-git-send-email-rsanford@akamai.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1640190018-7025-1-git-send-email-rsanford@akamai.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1640190018-7025-1-git-send-email-rsanford@akamai.com", "date": "2021-12-22T16:20:18", "name": "ring: update Doxygen comments re RING_F_EXACT_SZ", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fae1a09f6a5a7a5172d3e94040010866937a8553", "submitter": { "id": 7, "url": "http://patchwork.dpdk.org/api/people/7/?format=api", "name": "Robert Sanford", "email": "rsanford2@gmail.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1640190018-7025-1-git-send-email-rsanford@akamai.com/mbox/", "series": [ { "id": 21009, "url": "http://patchwork.dpdk.org/api/series/21009/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21009", "date": "2021-12-22T16:20:18", "name": "ring: update Doxygen comments re RING_F_EXACT_SZ", "version": 1, "mbox": "http://patchwork.dpdk.org/series/21009/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105327/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/105327/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2ABF1A034E;\n\tWed, 22 Dec 2021 17:20:55 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A03F940040;\n\tWed, 22 Dec 2021 17:20:54 +0100 (CET)", "from mail-qt1-f175.google.com (mail-qt1-f175.google.com\n [209.85.160.175])\n by mails.dpdk.org (Postfix) with ESMTP id 61FD24003C\n for <dev@dpdk.org>; Wed, 22 Dec 2021 17:20:53 +0100 (CET)", "by mail-qt1-f175.google.com with SMTP id q14so2356752qtx.10\n for <dev@dpdk.org>; Wed, 22 Dec 2021 08:20:53 -0800 (PST)", "from ubuntu.localdomain\n (99-153-167-175.lightspeed.ftldfl.sbcglobal.net. [99.153.167.175])\n by smtp.gmail.com with ESMTPSA id e20sm2109387qty.14.2021.12.22.08.20.51\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 22 Dec 2021 08:20:52 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id;\n bh=nirkYtraLYweYWl0ePT+stf58JXZuP2XyDjXeqe7VLw=;\n b=PEBBLEQKIpGNEJ83I1+pBAswpKE57wd3nHkWeXC2vizvBoXBOu63CNh8vR3fyVDyUz\n y88Ee7WruaFJBji9P8fRAmrGuYOZGoikIf3C8gl8lGRa0tkvFWGNgmQ3bBsFlNx6gPtm\n 223Kjh6vfXuDmIqcioT9TYPxwS6ERDFaP7tmK8YxhDIxZSIviIedBqzYue0i0Qky+iox\n BP8zuMf3aYxa87grnEUrgeLanNnw44Fuo6Ilr+SiOHqce95+e7xoV1oWw11uVnyLZAOd\n x9/1Y10nGNX7gll8iBzXc4TB0Q3z3xY45obtz320ihm1+MPOfCfWdER95rUO49c3aQij\n vHWA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id;\n bh=nirkYtraLYweYWl0ePT+stf58JXZuP2XyDjXeqe7VLw=;\n b=DjeoIlmcQDTwxfGyzmqSHaTrON78CXUFGaDsooBlB+Ah1T5aLRR6+FtteX3E1aIiej\n qVAkeWLOGt+UR2ZZsvDK2YenWNCxFQkuR7SrhizKtbdge9S1E8EE5DRmE2CsKeJ9iWYU\n kMWsHBeNepIgByxPSS4E79XeerFYFSsmCNfqXhSR4q0riiC7x0ZgaP+9he8pRjZe+lXs\n eI5si3E+db25+xzYY/o9WyUg3Sk7ZTejBEfuwFLcu9eS3qldVLLBGJab7oqHuF52RftZ\n UG1PTb1GdQP2iyVsVzBF+1MzxESk7J10vEt4Uaqft6ygWUytuxtPwYzVm6kw47OaiBg+\n Siyw==", "X-Gm-Message-State": "AOAM531k3bwWxbF5jv58cPTeJgI+QggKTYoCJyg4gx7e6qo/bRGHK+9W\n w6sRs9+iUc6ixg8olBSacfcF4GS0BZewBg==", "X-Google-Smtp-Source": "\n ABdhPJxYz1nrwOzPPgz8pBZ4Betby7TaqyLHeq1cDC4iuS53/tJ1wWzt2XPyHdBEXbULMk+krI3ERA==", "X-Received": "by 2002:ac8:7fc5:: with SMTP id b5mr2756603qtk.492.1640190052548;\n Wed, 22 Dec 2021 08:20:52 -0800 (PST)", "From": "Robert Sanford <rsanford2@gmail.com>", "X-Google-Original-From": "Robert Sanford <rsanford@akamai.com>", "To": "dev@dpdk.org", "Cc": "honnappa.nagarahalli@arm.com,\n\tkonstantin.ananyev@intel.com", "Subject": "[PATCH] ring: update Doxygen comments re RING_F_EXACT_SZ", "Date": "Wed, 22 Dec 2021 11:20:18 -0500", "Message-Id": "<1640190018-7025-1-git-send-email-rsanford@akamai.com>", "X-Mailer": "git-send-email 2.7.4", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "- Add RING_F_EXACT_SZ description to rte_ring_init and\n rte_ring_create param comments.\n- Fix ring size comments.\n\nSigned-off-by: Robert Sanford <rsanford@akamai.com>\n---\n lib/ring/rte_ring.h | 24 ++++++++++++++++++++----\n lib/ring/rte_ring_elem.h | 2 +-\n 2 files changed, 21 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/ring/rte_ring.h b/lib/ring/rte_ring.h\nindex da17ed6..ab6b424 100644\n--- a/lib/ring/rte_ring.h\n+++ b/lib/ring/rte_ring.h\n@@ -68,7 +68,7 @@ ssize_t rte_ring_get_memsize(unsigned int count);\n *\n * The ring size is set to *count*, which must be a power of two. Water\n * marking is disabled by default. The real usable ring size is\n- * *count-1* instead of *count* to differentiate a free ring from an\n+ * *count-1* instead of *count* to differentiate a full ring from an\n * empty ring.\n *\n * The ring is not added in RTE_TAILQ_RING global list. Indeed, the\n@@ -80,7 +80,8 @@ ssize_t rte_ring_get_memsize(unsigned int count);\n * @param name\n * The name of the ring.\n * @param count\n- * The number of elements in the ring (must be a power of 2).\n+ * The number of elements in the ring (must be a power of 2,\n+ * unless RING_F_EXACT_SZ is set in flags).\n * @param flags\n * An OR of the following:\n * - One of mutually exclusive flags that define producer behavior:\n@@ -107,6 +108,13 @@ ssize_t rte_ring_get_memsize(unsigned int count);\n * is \"multi-consumer HTS mode\".\n * If none of these flags is set, then default \"multi-consumer\"\n * behavior is selected.\n+ * - RING_F_EXACT_SZ: If this flag is set, the ring will hold exactly the\n+ * requested number of entries, and the requested size will be rounded up\n+ * to the next power of two, but the usable space will be exactly that\n+ * requested. Worst case, if a power-of-2 size is requested, half the\n+ * ring space will be wasted.\n+ * Without this flag set, the ring size requested must be a power of 2,\n+ * and the usable space will be that size - 1.\n * @return\n * 0 on success, or a negative value on error.\n */\n@@ -121,7 +129,7 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count,\n *\n * The new ring size is set to *count*, which must be a power of\n * two. Water marking is disabled by default. The real usable ring size\n- * is *count-1* instead of *count* to differentiate a free ring from an\n+ * is *count-1* instead of *count* to differentiate a full ring from an\n * empty ring.\n *\n * The ring is added in RTE_TAILQ_RING list.\n@@ -129,7 +137,8 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count,\n * @param name\n * The name of the ring.\n * @param count\n- * The size of the ring (must be a power of 2).\n+ * The size of the ring (must be a power of 2,\n+ * unless RING_F_EXACT_SZ is set in flags).\n * @param socket_id\n * The *socket_id* argument is the socket identifier in case of\n * NUMA. The value can be *SOCKET_ID_ANY* if there is no NUMA\n@@ -160,6 +169,13 @@ int rte_ring_init(struct rte_ring *r, const char *name, unsigned int count,\n * is \"multi-consumer HTS mode\".\n * If none of these flags is set, then default \"multi-consumer\"\n * behavior is selected.\n+ * - RING_F_EXACT_SZ: If this flag is set, the ring will hold exactly the\n+ * requested number of entries, and the requested size will be rounded up\n+ * to the next power of two, but the usable space will be exactly that\n+ * requested. Worst case, if a power-of-2 size is requested, half the\n+ * ring space will be wasted.\n+ * Without this flag set, the ring size requested must be a power of 2,\n+ * and the usable space will be that size - 1.\n * @return\n * On success, the pointer to the new allocated ring. NULL on error with\n * rte_errno set appropriately. Possible errno values include:\ndiff --git a/lib/ring/rte_ring_elem.h b/lib/ring/rte_ring_elem.h\nindex 4bd016c..fb1edc9 100644\n--- a/lib/ring/rte_ring_elem.h\n+++ b/lib/ring/rte_ring_elem.h\n@@ -51,7 +51,7 @@ ssize_t rte_ring_get_memsize_elem(unsigned int esize, unsigned int count);\n *\n * The new ring size is set to *count*, which must be a power of\n * two. Water marking is disabled by default. The real usable ring size\n- * is *count-1* instead of *count* to differentiate a free ring from an\n+ * is *count-1* instead of *count* to differentiate a full ring from an\n * empty ring.\n *\n * The ring is added in RTE_TAILQ_RING list.\n", "prefixes": [] }