Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105434/?format=api
{ "id": 105434, "url": "http://patchwork.dpdk.org/api/patches/105434/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/da0dc3b3ba2695d1ff1798fc6c921da6079f00d3.1640585898.git.wangyunjian@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<da0dc3b3ba2695d1ff1798fc6c921da6079f00d3.1640585898.git.wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/da0dc3b3ba2695d1ff1798fc6c921da6079f00d3.1640585898.git.wangyunjian@huawei.com", "date": "2021-12-27T10:49:33", "name": "app/testpmd: log the largest free block when dumping socket memory", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "2a3bb7c88248d833497ae8e358c018527df5bf1b", "submitter": { "id": 551, "url": "http://patchwork.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/da0dc3b3ba2695d1ff1798fc6c921da6079f00d3.1640585898.git.wangyunjian@huawei.com/mbox/", "series": [ { "id": 21029, "url": "http://patchwork.dpdk.org/api/series/21029/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21029", "date": "2021-12-27T10:49:33", "name": "app/testpmd: log the largest free block when dumping socket memory", "version": 1, "mbox": "http://patchwork.dpdk.org/series/21029/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105434/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/105434/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E2DB7A0350;\n\tMon, 27 Dec 2021 11:49:56 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 94F8440683;\n\tMon, 27 Dec 2021 11:49:55 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 22D5B4067B\n for <dev@dpdk.org>; Mon, 27 Dec 2021 11:49:53 +0100 (CET)", "from dggpemm500020.china.huawei.com (unknown [172.30.72.53])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JMvVM3FphzZcDC;\n Mon, 27 Dec 2021 18:46:35 +0800 (CST)", "from dggpemm500008.china.huawei.com (7.185.36.136) by\n dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2308.20; Mon, 27 Dec 2021 18:49:51 +0800", "from localhost (10.174.242.157) by dggpemm500008.china.huawei.com\n (7.185.36.136) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 27 Dec\n 2021 18:49:50 +0800" ], "From": "Yunjian Wang <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<xiaoyun.li@intel.com>, <aman.deep.singh@intel.com>,\n <xuemingl@nvidia.com>, <dingxiaoxiong@huawei.com>, <xudingke@huawei.com>,\n Yunjian Wang <wangyunjian@huawei.com>", "Subject": "[dpdk-dev] [PATCH] app/testpmd: log the largest free block when\n dumping socket memory", "Date": "Mon, 27 Dec 2021 18:49:33 +0800", "Message-ID": "\n <da0dc3b3ba2695d1ff1798fc6c921da6079f00d3.1640585898.git.wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.174.242.157]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n dggpemm500008.china.huawei.com (7.185.36.136)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add log print of the largest free block in dump_socket_mem.\nIt is useful to also log when dumping socket memory.\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n app/test-pmd/cmdline.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\nindex 6e10afeedd..d7bddf065a 100644\n--- a/app/test-pmd/cmdline.c\n+++ b/app/test-pmd/cmdline.c\n@@ -9825,6 +9825,7 @@ dump_socket_mem(FILE *f)\n \tsize_t total = 0;\n \tsize_t alloc = 0;\n \tsize_t free = 0;\n+\tsize_t greatest_free_size = 0;\n \tunsigned int n_alloc = 0;\n \tunsigned int n_free = 0;\n \tstatic size_t last_allocs;\n@@ -9840,22 +9841,27 @@ dump_socket_mem(FILE *f)\n \t\tfree += socket_stats.heap_freesz_bytes;\n \t\tn_alloc += socket_stats.alloc_count;\n \t\tn_free += socket_stats.free_count;\n+\t\tgreatest_free_size = RTE_MAX(greatest_free_size, socket_stats.greatest_free_size);\n \t\tfprintf(f,\n-\t\t\t\"Socket %u: size(M) total: %.6lf alloc: %.6lf(%.3lf%%) free: %.6lf \\tcount alloc: %-4u free: %u\\n\",\n+\t\t\t\"Socket %u: size(M) total: %.6lf alloc: %.6lf(%.3lf%%) free: %.6lf max: %.6lf \\t\"\n+\t\t\t\"count alloc: %-4u free: %u\\n\",\n \t\t\ti,\n \t\t\t(double)socket_stats.heap_totalsz_bytes / (1024 * 1024),\n \t\t\t(double)socket_stats.heap_allocsz_bytes / (1024 * 1024),\n \t\t\t(double)socket_stats.heap_allocsz_bytes * 100 /\n \t\t\t(double)socket_stats.heap_totalsz_bytes,\n \t\t\t(double)socket_stats.heap_freesz_bytes / (1024 * 1024),\n+\t\t\t(double)socket_stats.greatest_free_size / (1024 * 1024),\n \t\t\tsocket_stats.alloc_count,\n \t\t\tsocket_stats.free_count);\n \t}\n \tfprintf(f,\n-\t\t\"Total : size(M) total: %.6lf alloc: %.6lf(%.3lf%%) free: %.6lf \\tcount alloc: %-4u free: %u\\n\",\n+\t\t\"Total : size(M) total: %.6lf alloc: %.6lf(%.3lf%%) free: %.6lf max: %.6lf \\t\"\n+\t\t\"count alloc: %-4u free: %u\\n\",\n \t\t(double)total / (1024 * 1024), (double)alloc / (1024 * 1024),\n \t\ttotal ? ((double)alloc * 100 / (double)total) : 0,\n \t\t(double)free / (1024 * 1024),\n+\t\t(double)greatest_free_size / (1024 * 1024),\n \t\tn_alloc, n_free);\n \tif (last_allocs)\n \t\tfprintf(stdout, \"Memory total change: %.6lf(M), allocation change: %.6lf(M)\\n\",\n", "prefixes": [] }