Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105458/?format=api
{ "id": 105458, "url": "http://patchwork.dpdk.org/api/patches/105458/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211228091058.3620177-7-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211228091058.3620177-7-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211228091058.3620177-7-g.singh@nxp.com", "date": "2021-12-28T09:10:56", "name": "[v2,6/8] crypto/dpaa2_sec: add useful debug prints in sec dequeue", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "0c9a2006d10abb1819d8668907f8f8fe0d9dc77c", "submitter": { "id": 1068, "url": "http://patchwork.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211228091058.3620177-7-g.singh@nxp.com/mbox/", "series": [ { "id": 21031, "url": "http://patchwork.dpdk.org/api/series/21031/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21031", "date": "2021-12-28T09:10:50", "name": "NXP crypto drivers changes", "version": 2, "mbox": "http://patchwork.dpdk.org/series/21031/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105458/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/105458/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 33917A034F;\n\tTue, 28 Dec 2021 10:12:05 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4E8B94114F;\n\tTue, 28 Dec 2021 10:11:43 +0100 (CET)", "from EUR02-AM5-obe.outbound.protection.outlook.com\n (mail-eopbgr00044.outbound.protection.outlook.com [40.107.0.44])\n by mails.dpdk.org (Postfix) with ESMTP id A38234114F\n for <dev@dpdk.org>; Tue, 28 Dec 2021 10:11:41 +0100 (CET)", "from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14)\n by AM6PR04MB6135.eurprd04.prod.outlook.com (2603:10a6:20b:bf::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4823.21; Tue, 28 Dec\n 2021 09:11:35 +0000", "from AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::4c23:c171:682e:9085]) by AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::4c23:c171:682e:9085%4]) with mapi id 15.20.4823.023; Tue, 28 Dec 2021\n 09:11:35 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Tb4z1R9Jk9RLDOe2sFKtyVqVOW45FHGPP9pP66vq3B8fIiC8bfGBbEw+PXxh9Iz2gd1BR1lzuxbCugwPuyqQBK9/KtDIhHdu6cfNkeF44+q47PBxHnltieCVxhR6c3wMENhGTaxdXp8yUfnTngb/YkjktRO2dhq972QbVNSkLQLb27mCZvtSw7fLHCKVKbNkd4udhnDGinwChwKLSWsYvVtIOVwU9UwnMJmXSOvhrTzQmiQvuHBq5aXXET1IIDyHk4nEyOZB5sRI1KpxxGxom8okyXUhHJOp+wXhkc6SLgiFJYCyIQ229Ob0mtlNKt5UzHxkX/cftt7bP3+73IF34w==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=V7cEuJQXjU0srJ6cYd8/Qt74TY6AFMJOAW75aHcqTMY=;\n b=S7uvbYCDPX8nRqLiczvwCQf8DOfRGAOJeNK6PifSAZM5pCLruyToudC7pkYXIhvq3VRjLKo3MdxoNnuQCYs+qCOPJwbNUyf8mEG7+sVPFGRsNkLS8bfxzgaNbrQGpHL1N3CZY0EtH4gO4D+3tBeZypX3/Lm9J8pkWtVrJsXhKmtC+dp/WtZApK7ngxl2t5UDEsj4hGR8ktZHMRv/jRc2mnM1VDVwIRqXX6+a023AXH9yfyJJ7thj8HGmBv1lnd42fLLPZ9XS849Mp5tlGkL2kUSpGy50jWvazQ3w/GuBpAOetFxdhRZtZU7bWz35gVnM5CKXuC/MEKev+HlUJpfW+A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=V7cEuJQXjU0srJ6cYd8/Qt74TY6AFMJOAW75aHcqTMY=;\n b=O2WCe53bR/3CuEyGNGMq0WO6HsueLzOvMl7OCDC6AM7fJx8RZ02j0sCzZ+DQHVvCfZv95ktT2cJA/Nrgq8bokjiJlQu5HbAdXTuj1grerdei147eZz/EjPZDxor1zrWpradbbeCjhwzRZkzpjo3snZbTfN7j+KkA8ZzsMpyPq1Y=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;", "From": "Gagandeep Singh <g.singh@nxp.com>", "To": "gakhil@marvell.com,\n\tdev@dpdk.org", "Cc": "Gagandeep Singh <g.singh@nxp.com>", "Subject": "[PATCH v2 6/8] crypto/dpaa2_sec: add useful debug prints in sec\n dequeue", "Date": "Tue, 28 Dec 2021 14:40:56 +0530", "Message-Id": "<20211228091058.3620177-7-g.singh@nxp.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211228091058.3620177-1-g.singh@nxp.com>", "References": "<20211220102710.3083370-1-g.singh@nxp.com>\n <20211228091058.3620177-1-g.singh@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SG2PR06CA0118.apcprd06.prod.outlook.com\n (2603:1096:1:1d::20) To AS8PR04MB8198.eurprd04.prod.outlook.com\n (2603:10a6:20b:3b0::14)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "6bc434e7-789d-48cb-a38a-08d9c9e20be4", "X-MS-TrafficTypeDiagnostic": "AM6PR04MB6135:EE_", "X-Microsoft-Antispam-PRVS": "\n <AM6PR04MB6135A330F9E6176AFC448F97E1439@AM6PR04MB6135.eurprd04.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:1824;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n CShRGox3wyod9gmjBjKJ29Nk5tOwbuWPEtXWAsHahOJFYNVr9/IcTdSISZSkZ//BWcltIBlI7fmXn5ZrfdF0a8YKoVOVM0J/hDI6KRa47pIuv5YHpIODvpuGqmkjMVQpXy+Qd1T5xCMvCCx9zz7yb047Ewc67L6JVB4CGc3HCM214M5LiAnV6SxswgHFblF4jW1oQFmAXktKycPM9lib5OrXhloiezHz9EWSAqu2VR4Y4uMMTHhY82TKJNfjyDSugLy9HM87eq7+A+g1PF3fb7gmKHzugrqDI7OGbuLQbY5KQw6BycY/5JfSjxKvEmUvtFKq0jkUTV7cbV2M8CkdWB2bMaNUdAg7lFoW8zJS7olksdM3Oqnx+1GtKC9N3pjpAgNbTh+6a47OQW4Ey2ltHo4Cj/zVanueyyZrR0tWTM4fYOXhIQ3YXNaipcsqAeMbMXHDw9w5XiKjwBXk+YmfAaRzAQQBy0a4zHjgz+SCpsWjElgMY2cdJ+Bf9BGdbzGCX2H1g595y2CcvHCvXQ+ZqTjU9gjnsDVC+NpquW1UEWGyWdybhRT/qoNonMCanAEWjKsle2QEQpj7vigG8XhRk7kEmUaSwiMavMYMlcEeTzZuI3dOAdi5xaNNS+q+BSFhavfL1SL3CRAEUuU9DfCiPl2nn7jNdh/6bHVzUpJCpJHU+sIFN9Py1Pn71ur2aaCFK4HepPeKtu6LEIHWe1s6Bw==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(4636009)(366004)(316002)(8676002)(2616005)(6486002)(4326008)(6506007)(66556008)(66476007)(6512007)(6666004)(55236004)(38100700002)(38350700002)(36756003)(52116002)(83380400001)(2906002)(1076003)(66946007)(86362001)(26005)(5660300002)(8936002)(186003)(508600001);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n h6oMMcXldHMRU65F51An8AY6EFWOexeBvPx1BvcodKCJ6ssr4ClzWaupJu4R/xy1vDL2zDwYitxi8qQUurrGIzXoFzUjGKcPsePO5KRDYGzXce8g5O45PVLgB0GToNrz62hODn2Xk103mPuyrJf6LWg/oHuJn6oKBgh1ztXP+a/kN/YK7zxeoinA8o/LhVKWEx7M8bBQ0gRQ3kq9m2mMhUalEuZOkbw+2ZF5zZu9L+jiBJkYkPSW1N2IRYIPvOKMBng1jgAKJC37xDjilsqhPG+oc8Nv6Vl3iW4YhkXNgUqe2QiIcjgfO42DgPi+GVMmcqpra2z/BJOjpVpNcDYFfKTVLA8pjalySbNUXnCodW7qKV/LVmWYyCfD/ApzIhkFV8UCABZKLqYl9JKzUMcAhXmz18UacRW5GKcvurBGYT4vWsvYHkklwFbJTgVbKiKEQjzFfvEsnxovkHtJZ8J+8aQJ/9oKGar2Lwhgua+HVcOz9jnGq2UjsUtDThmNjI2KopuRC4lIBUbx0rLuFHbkAYl6MzCPY/t+zzG4amPVVcOYbETlG1Od9mpksDdaK6HqF0/0OINsDYxJv1Gb8lnukI1FAAugMNYE9pHsPXxK8jqYCD1uqfNFyfitEJF5SEy5pC3IIPC3BFK3ZOGxRyBMCb7huVlj7pH4zT5OTr1DE1q5ZNIlok6fH+3gMfMyYKWCHrfsK0l17+ExnafxyBCcOsKynwjWM3nL2fTZT03v7cARkr7mbJlmIpbihv4Tf9V5ShZxI1lMF8iWmZYJJXwPHp+p9JZwmBL3hImuEAPplEQZXU/JudTslUvjLxz7x1kQGpe5WyPRqbP7C35EN/xTi1Hx5om5Mlx2xawx6Ih4MI4FfzELImaF/8qCJ1tVc6H2atwKznJQ5lGXdxetAzvIwg1mqKspAvLkz1YJyNd4lae0V6Q2RlnBRGSxkc7MhcmaLrNx9+0oIPHep20MSREzSywxrtHUPx2R5JEHyayDjamzhdFTfZlUgM1KPJnvsPwRwqE/sXIAZsaV4JfFDiaP9Oy3X4nSBJbed1SCbsdy75sRghNvbgYYXHdR1rNZE8CmAu+nA/YR101256gE9x8i2MaK5+HU6LqORkz5uytwDzwkAE9icDrzw5c+NCR8BXzjKpJxOj07KdOZ1c3bkelMroG4wtid0sLQusUEFwjyK01xL1dPmWBCsETIOc83vJCCCqgmfr+QL/HIdpKixFtu2mR5hLtm+IkhtP2AKulYUWkQh7RTf2JQii0924DfLhAdh6LQKkWXbYP/YhrZDsZbTYO2qseX/fsBJhx2uc8mHvJQWpUJZG42UGMQKKl0SipmNNORzr8jD2xeWzDxgvmfVR87BzTnAv3+ZkHglxcJOlfPBolqAdnPkf4diwlXbKaRV1wEy7jTTy9HoIANtWNZuYAOW56E/LSJBKCYMMXuPr+6qL0ozQqu2FzqxAGKxcOY/GGKT5LrPTaYi7v4DONDgLTPc4QMHz/xfWsP/CSmiEILoG4IGIElRYUxoZgegIbZyNbKqvrVaDSUniIQZms9EbSHKJYfkoAJEikrrpsJX6w=", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 6bc434e7-789d-48cb-a38a-08d9c9e20be4", "X-MS-Exchange-CrossTenant-AuthSource": "AS8PR04MB8198.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Dec 2021 09:11:35.1773 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n Q+z2eGCgwYLGsp9yAAAHbSKM2ntJaSJYc4QLwJftumapwPIHEnlomJYmSQcQT7bk", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM6PR04MB6135", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Few useful debug prints added in dequeue function.\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n doc/guides/cryptodevs/dpaa2_sec.rst | 10 ++\n drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 136 +++++++++++++++++++-\n 2 files changed, 144 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/cryptodevs/dpaa2_sec.rst b/doc/guides/cryptodevs/dpaa2_sec.rst\nindex 06de988d51..875d918068 100644\n--- a/doc/guides/cryptodevs/dpaa2_sec.rst\n+++ b/doc/guides/cryptodevs/dpaa2_sec.rst\n@@ -175,3 +175,13 @@ For enabling logs, use the following EAL parameter:\n \n Using ``crypto.dpaa2`` as log matching criteria, all Crypto PMD logs can be\n enabled which are lower than logging ``level``.\n+\n+Enabling debug prints\n+---------------------\n+\n+Use dev arg option ``drv_dump_mode=x`` to dump useful debug prints on HW sec\n+error. There are 3 dump modes available 0, 1 and 2. Mode 0 means no dump print\n+on error, mode 1 means dump HW error code and mode 2 means dump HW error code\n+along with other useful debugging information like session, queue, descriptor\n+data.\n+e.g. ``fslmc:dpseci.1,drv_dump_mode=1``\ndiff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\nindex 99f5157abe..b65416097c 100644\n--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c\n@@ -28,6 +28,7 @@\n #include <fsl_dpopr.h>\n #include <fsl_dpseci.h>\n #include <fsl_mc_sys.h>\n+#include <rte_hexdump.h>\n \n #include \"dpaa2_sec_priv.h\"\n #include \"dpaa2_sec_event.h\"\n@@ -50,7 +51,17 @@\n \n #define NO_PREFETCH 0\n \n+#define DRIVER_DUMP_MODE \"drv_dump_mode\"\n+\n+/* DPAA2_SEC_DP_DUMP levels */\n+enum dpaa2_sec_dump_levels {\n+\tDPAA2_SEC_DP_NO_DUMP,\n+\tDPAA2_SEC_DP_ERR_DUMP,\n+\tDPAA2_SEC_DP_FULL_DUMP\n+};\n+\n uint8_t cryptodev_driver_id;\n+uint8_t dpaa2_sec_dp_dump = DPAA2_SEC_DP_ERR_DUMP;\n \n #ifdef RTE_LIB_SECURITY\n static inline int\n@@ -1784,6 +1795,83 @@ dpaa2_sec_enqueue_burst_ordered(void *qp, struct rte_crypto_op **ops,\n \treturn num_tx;\n }\n \n+static void\n+dpaa2_sec_dump(struct rte_crypto_op *op)\n+{\n+\tint i;\n+\tdpaa2_sec_session *sess = NULL;\n+\tstruct ctxt_priv *priv;\n+\tuint8_t bufsize;\n+\tstruct rte_crypto_sym_op *sym_op;\n+\n+\tif (op->sess_type == RTE_CRYPTO_OP_WITH_SESSION)\n+\t\tsess = (dpaa2_sec_session *)get_sym_session_private_data(\n+\t\t\top->sym->session, cryptodev_driver_id);\n+#ifdef RTE_LIBRTE_SECURITY\n+\telse if (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION)\n+\t\tsess = (dpaa2_sec_session *)get_sec_session_private_data(\n+\t\t\top->sym->sec_session);\n+#endif\n+\n+\tif (sess == NULL)\n+\t\tgoto mbuf_dump;\n+\n+\tpriv = (struct ctxt_priv *)sess->ctxt;\n+\tprintf(\"\\n****************************************\\n\"\n+\t\t\"session params:\\n\\tContext type:\\t%d\\n\\tDirection:\\t%s\\n\"\n+\t\t\"\\tCipher alg:\\t%d\\n\\tAuth alg:\\t%d\\n\\tAead alg:\\t%d\\n\"\n+\t\t\"\\tCipher key len:\\t%zd\\n\", sess->ctxt_type,\n+\t\t(sess->dir == DIR_ENC) ? \"DIR_ENC\" : \"DIR_DEC\",\n+\t\tsess->cipher_alg, sess->auth_alg, sess->aead_alg,\n+\t\tsess->cipher_key.length);\n+\t\trte_hexdump(stdout, \"cipher key\", sess->cipher_key.data,\n+\t\t\t\tsess->cipher_key.length);\n+\t\trte_hexdump(stdout, \"auth key\", sess->auth_key.data,\n+\t\t\t\tsess->auth_key.length);\n+\tprintf(\"\\tAuth key len:\\t%zd\\n\\tIV len:\\t\\t%d\\n\\tIV offset:\\t%d\\n\"\n+\t\t\"\\tdigest length:\\t%d\\n\\tstatus:\\t\\t%d\\n\\taead auth only\"\n+\t\t\" len:\\t%d\\n\\taead cipher text:\\t%d\\n\",\n+\t\tsess->auth_key.length, sess->iv.length, sess->iv.offset,\n+\t\tsess->digest_length, sess->status,\n+\t\tsess->ext_params.aead_ctxt.auth_only_len,\n+\t\tsess->ext_params.aead_ctxt.auth_cipher_text);\n+#ifdef RTE_LIBRTE_SECURITY\n+\tprintf(\"PDCP session params:\\n\"\n+\t\t\"\\tDomain:\\t\\t%d\\n\\tBearer:\\t\\t%d\\n\\tpkt_dir:\\t%d\\n\\thfn_ovd:\"\n+\t\t\"\\t%d\\n\\tsn_size:\\t%d\\n\\thfn_ovd_offset:\\t%d\\n\\thfn:\\t\\t%d\\n\"\n+\t\t\"\\thfn_threshold:\\t0x%x\\n\", sess->pdcp.domain,\n+\t\tsess->pdcp.bearer, sess->pdcp.pkt_dir, sess->pdcp.hfn_ovd,\n+\t\tsess->pdcp.sn_size, sess->pdcp.hfn_ovd_offset, sess->pdcp.hfn,\n+\t\tsess->pdcp.hfn_threshold);\n+\n+#endif\n+\tbufsize = (uint8_t)priv->flc_desc[0].flc.word1_sdl;\n+\tprintf(\"Descriptor Dump:\\n\");\n+\tfor (i = 0; i < bufsize; i++)\n+\t\tprintf(\"\\tDESC[%d]:0x%x\\n\", i, priv->flc_desc[0].desc[i]);\n+\n+\tprintf(\"\\n\");\n+mbuf_dump:\n+\tsym_op = op->sym;\n+\tif (sym_op->m_src) {\n+\t\tprintf(\"Source mbuf:\\n\");\n+\t\trte_pktmbuf_dump(stdout, sym_op->m_src, sym_op->m_src->data_len);\n+\t}\n+\tif (sym_op->m_dst) {\n+\t\tprintf(\"Destination mbuf:\\n\");\n+\t\trte_pktmbuf_dump(stdout, sym_op->m_dst, sym_op->m_dst->data_len);\n+\t}\n+\n+\tprintf(\"Session address = %p\\ncipher offset: %d, length: %d\\n\"\n+\t\t\"auth offset: %d, length: %d\\n aead offset: %d, length: %d\\n\"\n+\t\t, sym_op->session,\n+\t\tsym_op->cipher.data.offset, sym_op->cipher.data.length,\n+\t\tsym_op->auth.data.offset, sym_op->auth.data.length,\n+\t\tsym_op->aead.data.offset, sym_op->aead.data.length);\n+\tprintf(\"\\n\");\n+\n+}\n+\n static uint16_t\n dpaa2_sec_dequeue_burst(void *qp, struct rte_crypto_op **ops,\n \t\t\tuint16_t nb_ops)\n@@ -1865,8 +1953,13 @@ dpaa2_sec_dequeue_burst(void *qp, struct rte_crypto_op **ops,\n \n \t\tif (unlikely(fd->simple.frc)) {\n \t\t\t/* TODO Parse SEC errors */\n-\t\t\tDPAA2_SEC_DP_ERR(\"SEC returned Error - %x\\n\",\n-\t\t\t\t fd->simple.frc);\n+\t\t\tif (dpaa2_sec_dp_dump > DPAA2_SEC_DP_NO_DUMP) {\n+\t\t\t\tDPAA2_SEC_DP_ERR(\"SEC returned Error - %x\\n\",\n+\t\t\t\t\t\t fd->simple.frc);\n+\t\t\t\tif (dpaa2_sec_dp_dump > DPAA2_SEC_DP_ERR_DUMP)\n+\t\t\t\t\tdpaa2_sec_dump(ops[num_rx]);\n+\t\t\t}\n+\n \t\t\tdpaa2_qp->rx_vq.err_pkts += 1;\n \t\t\tops[num_rx]->status = RTE_CRYPTO_OP_STATUS_ERROR;\n \t\t} else {\n@@ -4132,6 +4225,42 @@ dpaa2_sec_uninit(const struct rte_cryptodev *dev)\n \treturn 0;\n }\n \n+static int\n+check_devargs_handler(__rte_unused const char *key, const char *value,\n+\t\t __rte_unused void *opaque)\n+{\n+\tdpaa2_sec_dp_dump = atoi(value);\n+\tif (dpaa2_sec_dp_dump > DPAA2_SEC_DP_FULL_DUMP) {\n+\t\tDPAA2_SEC_WARN(\"WARN: DPAA2_SEC_DP_DUMP_LEVEL is not \"\n+\t\t\t \"supported, changing to FULL error prints\\n\");\n+\t\tdpaa2_sec_dp_dump = DPAA2_SEC_DP_FULL_DUMP;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static void\n+dpaa2_sec_get_devargs(struct rte_devargs *devargs, const char *key)\n+{\n+\tstruct rte_kvargs *kvlist;\n+\n+\tif (!devargs)\n+\t\treturn;\n+\n+\tkvlist = rte_kvargs_parse(devargs->args, NULL);\n+\tif (!kvlist)\n+\t\treturn;\n+\n+\tif (!rte_kvargs_count(kvlist, key)) {\n+\t\trte_kvargs_free(kvlist);\n+\t\treturn;\n+\t}\n+\n+\trte_kvargs_process(kvlist, key,\n+\t\t\tcheck_devargs_handler, NULL);\n+\trte_kvargs_free(kvlist);\n+}\n+\n static int\n dpaa2_sec_dev_init(struct rte_cryptodev *cryptodev)\n {\n@@ -4233,6 +4362,7 @@ dpaa2_sec_dev_init(struct rte_cryptodev *cryptodev)\n \t\tgoto init_error;\n \t}\n \n+\tdpaa2_sec_get_devargs(cryptodev->device->devargs, DRIVER_DUMP_MODE);\n \tDPAA2_SEC_INFO(\"driver %s: created\", cryptodev->data->name);\n \treturn 0;\n \n@@ -4331,4 +4461,6 @@ static struct cryptodev_driver dpaa2_sec_crypto_drv;\n RTE_PMD_REGISTER_DPAA2(CRYPTODEV_NAME_DPAA2_SEC_PMD, rte_dpaa2_sec_driver);\n RTE_PMD_REGISTER_CRYPTO_DRIVER(dpaa2_sec_crypto_drv,\n \t\trte_dpaa2_sec_driver.driver, cryptodev_driver_id);\n+RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_DPAA2_SEC_PMD,\n+\t\tDRIVER_DUMP_MODE \"=<int>\");\n RTE_LOG_REGISTER(dpaa2_logtype_sec, pmd.crypto.dpaa2, NOTICE);\n", "prefixes": [ "v2", "6/8" ] }