Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 105583,
    "url": "http://patchwork.dpdk.org/api/patches/105583/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220103150813.1694888-9-gakhil@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220103150813.1694888-9-gakhil@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20220103150813.1694888-9-gakhil@marvell.com",
    "date": "2022-01-03T15:08:13",
    "name": "[8/8] app/test: add IP reassembly negative cases",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "9095fdbb678180ab091dc0c6e897745f4215da87",
    "submitter": {
        "id": 2094,
        "url": "http://patchwork.dpdk.org/api/people/2094/?format=api",
        "name": "Akhil Goyal",
        "email": "gakhil@marvell.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220103150813.1694888-9-gakhil@marvell.com/mbox/",
    "series": [
        {
            "id": 21052,
            "url": "http://patchwork.dpdk.org/api/series/21052/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21052",
            "date": "2022-01-03T15:08:05",
            "name": "ethdev: introduce IP reassembly offload",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/21052/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/105583/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/105583/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CF349A04A3;\n\tMon,  3 Jan 2022 16:09:27 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 056D141141;\n\tMon,  3 Jan 2022 16:09:08 +0100 (CET)",
            "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 46D7941174\n for <dev@dpdk.org>; Mon,  3 Jan 2022 16:09:06 +0100 (CET)",
            "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 203CKtES014034;\n Mon, 3 Jan 2022 07:09:04 -0800",
            "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3dbmvswfah-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 03 Jan 2022 07:09:04 -0800",
            "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 3 Jan 2022 07:09:03 -0800",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 3 Jan 2022 07:09:03 -0800",
            "from localhost.localdomain (unknown [10.28.48.55])\n by maili.marvell.com (Postfix) with ESMTP id 9E7293F7095;\n Mon,  3 Jan 2022 07:08:59 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=Y3XXfLyQOlxkDNwYxWk9L7VMMB2vaN4nnTo5QEmYcTw=;\n b=Lj+dX2cbxRx4jw1T5lAjXBLrcQOdZLHxaY5dNSH9dC6oNAsXu5Aqkq+M2FRIjFuQ0ZHe\n TB4ecuPGra9M5okZVh3SSBp3JAzzrt/CHFb6EDugzOp3GMXrse0Qn8NZyNYmPbMNtEKb\n OUBsJ3r8IjmiHrIhoOpD3neRL06/LoWGGV9P+HZG+jfF9Ny1IEpwSyY6XpSfOdDd7Oqz\n e5D90w9732kx00Hf8mAa0gB7zBBTL35rmuI7NNl8nvI6qnq5wfBupKHljvTganfoKbib\n Kf8MlQepgp91zEchJZ3ASqzdHYh1HoZIuufkxxZ3t6kPmuzQ88cMy4ZrerqCuKMBA5y4 0w==",
        "From": "Akhil Goyal <gakhil@marvell.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<anoobj@marvell.com>, <radu.nicolau@intel.com>,\n <declan.doherty@intel.com>,\n <hemant.agrawal@nxp.com>, <matan@nvidia.com>,\n <konstantin.ananyev@intel.com>, <thomas@monjalon.net>,\n <ferruh.yigit@intel.com>, <andrew.rybchenko@oktetlabs.ru>,\n <olivier.matz@6wind.com>, <rosen.xu@intel.com>, Akhil Goyal\n <gakhil@marvell.com>",
        "Subject": "[PATCH 8/8] app/test: add IP reassembly negative cases",
        "Date": "Mon, 3 Jan 2022 20:38:13 +0530",
        "Message-ID": "<20220103150813.1694888-9-gakhil@marvell.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20220103150813.1694888-1-gakhil@marvell.com>",
        "References": "<20210823100259.1619886-1-gakhil@marvell.com>\n <20220103150813.1694888-1-gakhil@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-ORIG-GUID": "3Lnl4Wf_gp5NxwTuxJ_o5Avj9o_EmdL6",
        "X-Proofpoint-GUID": "3Lnl4Wf_gp5NxwTuxJ_o5Avj9o_EmdL6",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513\n definitions=2022-01-03_06,2022-01-01_01,2021-12-02_01",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "test_inline_ipsec testsuite is added with cases where the IP reassembly\nis incomplete and software will need to reassemble them later.\nThe failure cases added are:\n- all fragments are not received.\n- same fragment is received more than once.\n- out of order fragments.\n\nSigned-off-by: Akhil Goyal <gakhil@marvell.com>\n---\n app/test/test_inline_ipsec.c | 53 ++++++++++++++++++++++++++++++++++++\n 1 file changed, 53 insertions(+)",
    "diff": "diff --git a/app/test/test_inline_ipsec.c b/app/test/test_inline_ipsec.c\nindex 3f3731760d..0d74e23359 100644\n--- a/app/test/test_inline_ipsec.c\n+++ b/app/test/test_inline_ipsec.c\n@@ -936,6 +936,50 @@ test_reassembly_ipv6_5frag(void) {\n \t\t\tRTE_SECURITY_IPSEC_TUNNEL_IPV6);\n }\n \n+static int\n+test_reassembly_incomplete(void) {\n+\t/* Negative test case, not sending all fragments. */\n+\tstruct reassembly_vector ipv4_incomplete_case = {\n+\t\t\t\t.sa_data = &conf_aes_128_gcm,\n+\t\t\t\t.full_pkt = &pkt_ipv4_udp_p2,\n+\t\t\t\t.frags[0] = &pkt_ipv4_udp_p2_f1,\n+\t\t\t\t.frags[1] = &pkt_ipv4_udp_p2_f2,\n+\t\t\t\t.frags[2] = NULL,\n+\t\t\t\t.frags[3] = NULL,\n+\t};\n+\treturn test_reassembly(&ipv4_incomplete_case,\n+\t\t\tRTE_SECURITY_IPSEC_TUNNEL_IPV4);\n+}\n+\n+static int\n+test_reassembly_overlap(void) {\n+\t/* Negative test case, sending 1 fragment twice. */\n+\tstruct reassembly_vector ipv4_overlap_case = {\n+\t\t\t\t.sa_data = &conf_aes_128_gcm,\n+\t\t\t\t.full_pkt = &pkt_ipv4_udp_p2,\n+\t\t\t\t.frags[0] = &pkt_ipv4_udp_p2_f1,\n+\t\t\t\t.frags[1] = &pkt_ipv4_udp_p2_f2,\n+\t\t\t\t.frags[2] = &pkt_ipv4_udp_p2_f2, /* overlap */\n+\t\t\t\t.frags[3] = &pkt_ipv4_udp_p2_f3,\n+\t};\n+\treturn test_reassembly(&ipv4_overlap_case,\n+\t\t\tRTE_SECURITY_IPSEC_TUNNEL_IPV4);\n+}\n+\n+static int\n+test_reassembly_out_of_order(void) {\n+\t/* Negative test case, sending 1 fragment twice. */\n+\tstruct reassembly_vector ipv4_ooo_case = {\n+\t\t\t\t.sa_data = &conf_aes_128_gcm,\n+\t\t\t\t.full_pkt = &pkt_ipv4_udp_p2,\n+\t\t\t\t.frags[0] = &pkt_ipv4_udp_p2_f4,\n+\t\t\t\t.frags[1] = &pkt_ipv4_udp_p2_f3,\n+\t\t\t\t.frags[2] = &pkt_ipv4_udp_p2_f1,\n+\t\t\t\t.frags[3] = &pkt_ipv4_udp_p2_f2,\n+\t};\n+\treturn test_reassembly(&ipv4_ooo_case,\n+\t\t\tRTE_SECURITY_IPSEC_TUNNEL_IPV4);\n+}\n \n static struct unit_test_suite inline_ipsec_testsuite  = {\n \t.suite_name = \"Inline IPsec Ethernet Device Unit Test Suite\",\n@@ -969,6 +1013,15 @@ static struct unit_test_suite inline_ipsec_testsuite  = {\n \t\tTEST_CASE_ST(ut_setup_inline_ipsec,\n \t\t\t\tut_teardown_inline_ipsec,\n \t\t\t\ttest_reassembly_ipv6_5frag),\n+\t\tTEST_CASE_ST(ut_setup_inline_ipsec,\n+\t\t\t\tut_teardown_inline_ipsec,\n+\t\t\t\ttest_reassembly_incomplete),\n+\t\tTEST_CASE_ST(ut_setup_inline_ipsec,\n+\t\t\t\tut_teardown_inline_ipsec,\n+\t\t\t\ttest_reassembly_overlap),\n+\t\tTEST_CASE_ST(ut_setup_inline_ipsec,\n+\t\t\t\tut_teardown_inline_ipsec,\n+\t\t\t\ttest_reassembly_out_of_order),\n \n \t\tTEST_CASES_END() /**< NULL terminate unit test array */\n \t}\n",
    "prefixes": [
        "8/8"
    ]
}