Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105648/?format=api
{ "id": 105648, "url": "http://patchwork.dpdk.org/api/patches/105648/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220105180153.73311-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220105180153.73311-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220105180153.73311-1-stephen@networkplumber.org", "date": "2022-01-05T18:01:53", "name": "[RFC] eal: remove size for eal_set_runtime_dir", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4ece4ed27558095e480b76bcbb89b35b5c80470d", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220105180153.73311-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 21075, "url": "http://patchwork.dpdk.org/api/series/21075/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21075", "date": "2022-01-05T18:01:53", "name": "[RFC] eal: remove size for eal_set_runtime_dir", "version": 1, "mbox": "http://patchwork.dpdk.org/series/21075/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105648/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/105648/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0B7D6A034D;\n\tWed, 5 Jan 2022 19:01:57 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6166B40E50;\n\tWed, 5 Jan 2022 19:01:57 +0100 (CET)", "from mail-pj1-f51.google.com (mail-pj1-f51.google.com\n [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 2803040E03\n for <dev@dpdk.org>; Wed, 5 Jan 2022 19:01:56 +0100 (CET)", "by mail-pj1-f51.google.com with SMTP id\n g11-20020a17090a7d0b00b001b2c12c7273so3805503pjl.0\n for <dev@dpdk.org>; Wed, 05 Jan 2022 10:01:56 -0800 (PST)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n l145sm45802261pfd.117.2022.01.05.10.01.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 05 Jan 2022 10:01:54 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=irhfJAfzBduThNA9m2ZPnttXoehaNt4Ki3vnrhSTuVU=;\n b=yJODoL6kNLH4VqzZJfVF4mc3slcnU7zXikpprEaLzBRWZG+ZZvIWetL5WziUJ5Kwj9\n XPmCu1Wl1xDBnxCwTVvnUVeCyOPqkoJkupa2wNVn0zuIrMeOL0G81e+42hoKAdJLiC6M\n qJQ/DsMd0jVZ1xa5VtVmIwJginZeMQUJ/VFn5C8EaTMRbJ5nIo+CyNjPmL8EgS6wPzAw\n 2skOu5QaEqcIoEM5QDPnWKTzDYoyo9t5a52uwvFfKAwGmuFHijaio1NNhbXE5MkESUp+\n Qxxj32gBGZBfwlljMW7iA6l70Sgkb3EvQ+6zL5HP/k2IqEn8IlRyI8RzjqQ+M1ul2p0A\n gigg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=irhfJAfzBduThNA9m2ZPnttXoehaNt4Ki3vnrhSTuVU=;\n b=eN1CR0LUW5URfOLs5gFibaznTSxhpcLzv1AFwessb83rDT1m2G8s97QqHcnxxmUuE1\n s3o71UU0m5wNYtgMU5OtEpLJaFKtsdKAAPCJENm08ZuqUMj2d/VaPT2CPgCspFclODnU\n NovnXZ5Pqobe2cOsDlcY+VnwXsuXnE6sPM4aKXjJghiBtMsPtqP1iY683kzcnXHtpk+r\n YFFrwi/wLy0c7tej1OuB3KgJ3t9TXi5C3mTNzMlmwKCqaOlnh9t2e3cRKsBY+C1682tt\n zgJo/YetRUza70hPRMCxAEBp291zRaS2HcO81ckKuZvd1duf918A8BkICBa8aSKssxO9\n uSeg==", "X-Gm-Message-State": "AOAM531vCnyr+c67zKLbg51h8xKVgHOMaSxIsv5/KU8jEU1qwjbBbkAp\n hNEx1+i2qcysfpbrcXN+BV6fCqCFUTS7Qw==", "X-Google-Smtp-Source": "\n ABdhPJz2QNwez0GP3Yl2DapneCkdcmJ9Zy/G7KFjGK5dByHwop4LYVBp2hTJGtOKTE47ica6fa6g8A==", "X-Received": "by 2002:a17:90a:be03:: with SMTP id\n a3mr3543455pjs.152.1641405715229;\n Wed, 05 Jan 2022 10:01:55 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Subject": "[RFC] eal: remove size for eal_set_runtime_dir", "Date": "Wed, 5 Jan 2022 10:01:53 -0800", "Message-Id": "<20220105180153.73311-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "\n <98CBD80474FA8B44BF855DF32C47DC35D86DB1@smartserver.smartshare.dk>", "References": "<98CBD80474FA8B44BF855DF32C47DC35D86DB1@smartserver.smartshare.dk>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The size argument to eal_set_runtime_dir is useless and was\nbeing used incorrectly in strlcpy. It worked only because\nall callers passed PATH_MAX which is same as sizeof the destination\nruntime_dir.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nSuggested-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/eal/common/eal_common_config.c | 7 ++-----\n lib/eal/common/eal_private.h | 4 +---\n lib/eal/freebsd/eal.c | 2 +-\n lib/eal/linux/eal.c | 2 +-\n 4 files changed, 5 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_config.c b/lib/eal/common/eal_common_config.c\nindex 1c4c4dd585d0..62a9d7a198db 100644\n--- a/lib/eal/common/eal_common_config.c\n+++ b/lib/eal/common/eal_common_config.c\n@@ -29,12 +29,9 @@ rte_eal_get_runtime_dir(void)\n }\n \n int\n-eal_set_runtime_dir(char *run_dir, size_t size)\n+eal_set_runtime_dir(const char *run_dir)\n {\n-\tsize_t str_size;\n-\n-\tstr_size = strlcpy(runtime_dir, run_dir, size);\n-\tif (str_size >= size) {\n+\tif (strlcpy(runtime_dir, run_dir, PATH_MAX) >= PATH_MAX) {\n \t\tRTE_LOG(ERR, EAL, \"Runtime directory string too long\\n\");\n \t\treturn -1;\n \t}\ndiff --git a/lib/eal/common/eal_private.h b/lib/eal/common/eal_private.h\nindex 36bcc0b5a492..734f1f334b69 100644\n--- a/lib/eal/common/eal_private.h\n+++ b/lib/eal/common/eal_private.h\n@@ -681,13 +681,11 @@ eal_mem_set_dump(void *virt, size_t size, bool dump);\n *\n * @param run_dir\n * The new runtime directory path of DPDK\n- * @param size\n- * The size of the new runtime directory path in bytes.\n * @return\n * 0 on success, (-1) on failure.\n */\n int\n-eal_set_runtime_dir(char *run_dir, size_t size);\n+eal_set_runtime_dir(const char *run_dir);\n \n /**\n * Get the internal configuration structure.\ndiff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex a1cd2462db1b..503e276dc27f 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -123,7 +123,7 @@ eal_create_runtime_dir(void)\n \t\treturn -1;\n \t}\n \n-\tif (eal_set_runtime_dir(run_dir, sizeof(run_dir)))\n+\tif (eal_set_runtime_dir(run_dir))\n \t\treturn -1;\n \n \treturn 0;\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex 80ffe1c7f9d8..a73ff75f65c9 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -135,7 +135,7 @@ eal_create_runtime_dir(void)\n \t\treturn -1;\n \t}\n \n-\tif (eal_set_runtime_dir(run_dir, sizeof(run_dir)))\n+\tif (eal_set_runtime_dir(run_dir))\n \t\treturn -1;\n \n \treturn 0;\n", "prefixes": [ "RFC" ] }