Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105693/?format=api
{ "id": 105693, "url": "http://patchwork.dpdk.org/api/patches/105693/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/b5b5d4a5eb98e92a9a06d51a88814ed9f2976e57.1641627917.git.wangyunjian@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<b5b5d4a5eb98e92a9a06d51a88814ed9f2976e57.1641627917.git.wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/b5b5d4a5eb98e92a9a06d51a88814ed9f2976e57.1641627917.git.wangyunjian@huawei.com", "date": "2022-01-08T07:51:57", "name": "ethdev: fix rxq_state leak in error path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9028775c1e294cb017bc5b26f074d0c3b97677f9", "submitter": { "id": 551, "url": "http://patchwork.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/b5b5d4a5eb98e92a9a06d51a88814ed9f2976e57.1641627917.git.wangyunjian@huawei.com/mbox/", "series": [ { "id": 21097, "url": "http://patchwork.dpdk.org/api/series/21097/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21097", "date": "2022-01-08T07:51:57", "name": "ethdev: fix rxq_state leak in error path", "version": 1, "mbox": "http://patchwork.dpdk.org/series/21097/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105693/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/105693/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BF908A0350;\n\tSat, 8 Jan 2022 08:52:10 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3EE6840689;\n\tSat, 8 Jan 2022 08:52:10 +0100 (CET)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 420B440042;\n Sat, 8 Jan 2022 08:52:07 +0100 (CET)", "from dggpemm500020.china.huawei.com (unknown [172.30.72.54])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JWBzQ5WJ4zZdrd;\n Sat, 8 Jan 2022 15:48:34 +0800 (CST)", "from dggpemm500008.china.huawei.com (7.185.36.136) by\n dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2308.20; Sat, 8 Jan 2022 15:52:05 +0800", "from localhost (10.174.242.157) by dggpemm500008.china.huawei.com\n (7.185.36.136) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 8 Jan\n 2022 15:52:05 +0800" ], "From": "Yunjian Wang <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <thomas@monjalon.net>,\n <gmuthukrishn@marvell.com>, <dingxiaoxiong@huawei.com>,\n <xudingke@huawei.com>, Yunjian Wang <wangyunjian@huawei.com>,\n <stable@dpdk.org>", "Subject": "[dpdk-dev] [PATCH] ethdev: fix rxq_state leak in error path", "Date": "Sat, 8 Jan 2022 15:51:57 +0800", "Message-ID": "\n <b5b5d4a5eb98e92a9a06d51a88814ed9f2976e57.1641627917.git.wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.174.242.157]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n dggpemm500008.china.huawei.com (7.185.36.136)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In eth_dev_handle_port_info() allocated memory for rxq_state,\nwe should free it when error happens, otherwise it will lead\nto memory leak.\n\nFixes: 58b43c1ddfd1 (\"ethdev: add telemetry endpoint for device info\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n lib/ethdev/rte_ethdev.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex a1d475a292..29e21ad580 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -6320,8 +6320,10 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,\n \t\treturn -ENOMEM;\n \n \ttxq_state = rte_tel_data_alloc();\n-\tif (!txq_state)\n+\tif (!txq_state) {\n+\t\trte_tel_data_free(rxq_state);\n \t\treturn -ENOMEM;\n+\t}\n \n \trte_tel_data_start_dict(d);\n \trte_tel_data_add_dict_string(d, \"name\", eth_dev->data->name);\n", "prefixes": [] }