Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105695/?format=api
{ "id": 105695, "url": "http://patchwork.dpdk.org/api/patches/105695/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/59c1e579917d1ddeeb80c553021a1d551ddb9b52.1641629424.git.wangyunjian@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<59c1e579917d1ddeeb80c553021a1d551ddb9b52.1641629424.git.wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/59c1e579917d1ddeeb80c553021a1d551ddb9b52.1641629424.git.wangyunjian@huawei.com", "date": "2022-01-08T08:14:21", "name": "net/virtio: fix uninitialized old_rss_key variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "45613b6c61004c05f2f7cf53d9f4c7f87f162941", "submitter": { "id": 551, "url": "http://patchwork.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/59c1e579917d1ddeeb80c553021a1d551ddb9b52.1641629424.git.wangyunjian@huawei.com/mbox/", "series": [ { "id": 21099, "url": "http://patchwork.dpdk.org/api/series/21099/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21099", "date": "2022-01-08T08:14:21", "name": "net/virtio: fix uninitialized old_rss_key variable", "version": 1, "mbox": "http://patchwork.dpdk.org/series/21099/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105695/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/105695/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 79F8DA0350;\n\tSat, 8 Jan 2022 09:14:27 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0EBC240696;\n\tSat, 8 Jan 2022 09:14:27 +0100 (CET)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id 33D3B40042;\n Sat, 8 Jan 2022 09:14:25 +0100 (CET)", "from dggpemm500024.china.huawei.com (unknown [172.30.72.53])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4JWCV864l8z5HpD;\n Sat, 8 Jan 2022 16:11:44 +0800 (CST)", "from dggpemm500008.china.huawei.com (7.185.36.136) by\n dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2308.20; Sat, 8 Jan 2022 16:14:23 +0800", "from localhost (10.174.242.157) by dggpemm500008.china.huawei.com\n (7.185.36.136) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 8 Jan\n 2022 16:14:22 +0800" ], "From": "Yunjian Wang <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<maxime.coquelin@redhat.com>, <chenbo.xia@intel.com>,\n <dingxiaoxiong@huawei.com>, <xudingke@huawei.com>, Yunjian Wang\n <wangyunjian@huawei.com>, <stable@dpdk.org>", "Subject": "[dpdk-dev] [PATCH] net/virtio: fix uninitialized old_rss_key variable", "Date": "Sat, 8 Jan 2022 16:14:21 +0800", "Message-ID": "\n <59c1e579917d1ddeeb80c553021a1d551ddb9b52.1641629424.git.wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.174.242.157]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggpemm500008.china.huawei.com (7.185.36.136)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch fixes an issue that uninitialized old_rss_key\nis used for restoring the rss_key.\n\nCoverity issue: 373866\nFixes: 0c9d66207054 (\"net/virtio: support RSS\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n drivers/net/virtio/virtio_ethdev.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex c2588369b2..7c445bfc48 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -2028,7 +2028,8 @@ virtio_dev_rss_hash_update(struct rte_eth_dev *dev,\n \n \treturn 0;\n restore_key:\n-\tmemcpy(hw->rss_key, old_rss_key, VIRTIO_NET_RSS_KEY_SIZE);\n+\tif (rss_conf->rss_key && rss_conf->rss_key_len)\n+\t\tmemcpy(hw->rss_key, old_rss_key, VIRTIO_NET_RSS_KEY_SIZE);\n restore_types:\n \thw->rss_hash_types = old_hash_types;\n \n", "prefixes": [] }