Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105710/?format=api
{ "id": 105710, "url": "http://patchwork.dpdk.org/api/patches/105710/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220110113509.553184-3-ssebasti@amd.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220110113509.553184-3-ssebasti@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220110113509.553184-3-ssebasti@amd.com", "date": "2022-01-10T11:35:05", "name": "[v1,2/6] net/axgbe: toggle PLL settings during rate change", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "744c49d48e04b998d385862b7e6a21c2eae73fbc", "submitter": { "id": 1604, "url": "http://patchwork.dpdk.org/api/people/1604/?format=api", "name": "Selwin Sebastian", "email": "ssebasti@amd.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220110113509.553184-3-ssebasti@amd.com/mbox/", "series": [ { "id": 21109, "url": "http://patchwork.dpdk.org/api/series/21109/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21109", "date": "2022-01-10T11:35:04", "name": "[v1,1/6] net/axgbe: always attempt link training in KR mode", "version": 1, "mbox": "http://patchwork.dpdk.org/series/21109/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105710/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/105710/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EEB0BA034D;\n\tMon, 10 Jan 2022 12:35:50 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B2F5641169;\n\tMon, 10 Jan 2022 12:35:38 +0100 (CET)", "from NAM04-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam08on2076.outbound.protection.outlook.com [40.107.100.76])\n by mails.dpdk.org (Postfix) with ESMTP id 1CA7E4114D\n for <dev@dpdk.org>; Mon, 10 Jan 2022 12:35:37 +0100 (CET)", "from MW4PR03CA0172.namprd03.prod.outlook.com (2603:10b6:303:8d::27)\n by MWHPR12MB1136.namprd12.prod.outlook.com (2603:10b6:300:f::14) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Mon, 10 Jan\n 2022 11:35:34 +0000", "from CO1NAM11FT022.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:8d:cafe::c0) by MW4PR03CA0172.outlook.office365.com\n (2603:10b6:303:8d::27) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11 via Frontend\n Transport; Mon, 10 Jan 2022 11:35:34 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CO1NAM11FT022.mail.protection.outlook.com (10.13.175.199) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.4867.7 via Frontend Transport; Mon, 10 Jan 2022 11:35:34 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 10 Jan\n 2022 05:35:32 -0600" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=iKMaBLWShbbjNlhwGc+cNz2z+2qnCIqg5PFBBXEhXJFl1VvPGihrtEhFTcRmGRM0IH4Qw5vcHMD3NwtCziXkO8GmM3ZeDIZsE9ACsjqy+Crb7pHC8Ig5+4dr5UU93ENwnhfbVMpvLKKp9EgFVXgs9dD0E6MVbWljFVbo5/3dVRKOEUN4fk/biI5/bEfZbkgcEbG4EbnOQGfbXLV4TsR2RufTSrWlroV3fmDPqWv0dkwT+SSRVNyA0wCvEFlfMTva1pKs83ArsuFdqDk8EP08nhN3DhZpLbSJeh+GXFK1/tGhme0ce8IChN51y9ChD4rbFLHsd8ubH/mJ7poG7nFSWg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=U6SsUlebNCOLojVCc0nEF+szVML+gsOIhsQI0TJmZJE=;\n b=JwqnI7eaNnSj6MHKf8rWGpqFS4Nf6bc9mlkRN7HArbfOhDCkDl3s10KRSt2nYV3ZxMGumtQv1Esmw7X103u5TGBhj2Cx+3xQlrpnWA9N6qzI1IU24URSI01JeFJQ1j0VcgOJXv7NIRVuYRTLWyByENvRWCLsMuVEXUVvVEuJF9bbQkMkNbshH6aFa+t6rnbxTpXOMUhItJJHAXc9MEr4Zn+pAwQ1tlK80WJlX51a9L50Uj4bqmb//yDhZrD2Hz7VFQrfHSKQMzU+jw1za5IyjA3thbJb929JTs1QRNSj3tC0nalHSHOXoiBn9Ir7WAnbj0xwM9wwqfIGS10tkrF0hw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=U6SsUlebNCOLojVCc0nEF+szVML+gsOIhsQI0TJmZJE=;\n b=4Qz397lnNHP02qMoa8pAec0OY3va7ySINgXK0mcg5L4R8Wa4n+VJgxfTuT3GdvQd1yfqDNHWLxtjcqm+jEh/MM9cOrEQEcMW40u9nF5x+n404sqhUKMWBqIgzPdEC3JegPlwFjMcD0buJLXr4zdxuz0JhSN/V9Dcqj7NP0S7c+k=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com;", "From": "<ssebasti@amd.com>", "To": "<dev@dpdk.org>", "Subject": "[PATCH v1 2/6] net/axgbe: toggle PLL settings during rate change", "Date": "Mon, 10 Jan 2022 17:05:05 +0530", "Message-ID": "<20220110113509.553184-3-ssebasti@amd.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220110113509.553184-1-ssebasti@amd.com>", "References": "<20220110113509.553184-1-ssebasti@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "e0966755-0d01-42bc-84fc-08d9d42d50b9", "X-MS-TrafficTypeDiagnostic": "MWHPR12MB1136:EE_", "X-Microsoft-Antispam-PRVS": "\n <MWHPR12MB11363300FA131439088236768D509@MWHPR12MB1136.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:7219;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n YgvZiU8uTYEm9TMEWQEFNDtWAUxNJFjkx5jKHc8AfeOSrrL0khrN0DP+vXcSpO9iVBVTxBiOYLQQT8VBrc58ocJaZh7FmEa0jb7XV/Bl8tQKN3Crx8JMMOZf01149jIBCjlFYm1WpTnBNvZJfLAMlnftHwm7wqk2U0Klc9bBfCVEqcPJbIvhz7Po/wetdFxXcPUQ5f8yQdHPwEhiTnCDOluCwv6CIpf0pMpJWq67+8PGS+6YjuE0gG8rA2HFPwbud7dsbRdQuNrtRWm18b4iCgE6n5NPPpifNJLxlvsTSNAKcUxtYTTXA4wHjB9WmswZ4abZ4fQG7Mg0uXOqdouyy5OsmVKMpx1qPiMrnN+pyfESvT5r9R10LlJh6vRiN0ELcq5/jsCZxYkex1t9VQ0/VLPWl42ylQUgvbMGsOkTS2oGpkWU+zp7nXDbP2g8oR2nh3/Wgox3sDVmtYakYY8GxOAYh9qBiYG2Iy0fiwE1uhQV8KKtNygKr330xKNblkGNatYi2FuJrP/vl8qPa7jwagBBZ2N9OzUpzriY0zm3Z3Vx9w61c37kVqW6QM68ztqcAjloQjdB4e3dFp3I6G3TnGeENLTPRBDjdO+f0aCexeFpyFEtLCnt62WLEow4sfymXABDl1DoZtL/sVjF9n4jDt1IkCLXIP0/Waw/wiKG8vZMiF6z/JvN1mpHrzLMxtOvZKKU2KtsUoPp+45HW7YsTZImHTyQjixOXcy6fZyjfdcHKqiAFhnBG5qB9MOoeiQNozxDcqoaVv3Y9ePs1BYEYXd/5YSem6aS4LSs9AfxNAQ=", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(4636009)(36840700001)(46966006)(40470700002)(6666004)(26005)(2906002)(82310400004)(6916009)(426003)(336012)(186003)(5660300002)(356005)(1076003)(83380400001)(2616005)(70586007)(8936002)(70206006)(36860700001)(16526019)(36756003)(81166007)(47076005)(40460700001)(2876002)(316002)(7696005)(508600001)(8676002)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "10 Jan 2022 11:35:34.1025 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n e0966755-0d01-42bc-84fc-08d9d42d50b9", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT022.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MWHPR12MB1136", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Selwin Sebastian <selwin.sebastian@amd.com>\n\nFor each rate change command submission, the FW has to do a phy\npower off sequence internally. For this to happen correctly, the\nPLL re-initialization control setting has to be turned off before\nsending mailbox commands and re-enabled once the command submission\nis complete. Without the PLL control setting, the link up takes\nlonger time in a fixed phy configuration.\n\nSigned-off-by: Selwin Sebastian <selwin.sebastian@amd.com>\n---\n drivers/net/axgbe/axgbe_common.h | 9 +++++++++\n drivers/net/axgbe/axgbe_phy_impl.c | 22 ++++++++++++++++++++--\n 2 files changed, 29 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_common.h b/drivers/net/axgbe/axgbe_common.h\nindex df0aa21a9b..5a7ac35b6a 100644\n--- a/drivers/net/axgbe/axgbe_common.h\n+++ b/drivers/net/axgbe/axgbe_common.h\n@@ -1314,6 +1314,11 @@\n #define MDIO_VEND2_PMA_CDR_CONTROL\t0x8056\n #endif\n \n+#ifndef MDIO_VEND2_PMA_MISC_CTRL0\n+#define MDIO_VEND2_PMA_MISC_CTRL0\t0x8090\n+#endif\n+\n+\n #ifndef MDIO_CTRL1_SPEED1G\n #define MDIO_CTRL1_SPEED1G\t\t(MDIO_CTRL1_SPEED10G & ~BMCR_SPEED100)\n #endif\n@@ -1392,6 +1397,10 @@ static inline uint32_t high32_value(uint64_t addr)\n \treturn (addr >> 32) & 0x0ffffffff;\n }\n \n+#define XGBE_PMA_PLL_CTRL_MASK BIT(15)\n+#define XGBE_PMA_PLL_CTRL_SET BIT(15)\n+#define XGBE_PMA_PLL_CTRL_CLEAR 0x0000\n+\n /*END*/\n \n /* Bit setting and getting macros\ndiff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c\nindex 02236ec192..dc9489f0aa 100644\n--- a/drivers/net/axgbe/axgbe_phy_impl.c\n+++ b/drivers/net/axgbe/axgbe_phy_impl.c\n@@ -1196,8 +1196,22 @@ static void axgbe_phy_set_redrv_mode(struct axgbe_port *pdata)\n \taxgbe_phy_put_comm_ownership(pdata);\n }\n \n+static void axgbe_phy_pll_ctrl(struct axgbe_port *pdata, bool enable)\n+{\n+\tXMDIO_WRITE_BITS(pdata, MDIO_MMD_PMAPMD, MDIO_VEND2_PMA_MISC_CTRL0,\n+\t\t\tXGBE_PMA_PLL_CTRL_MASK,\n+\t\t\tenable ? XGBE_PMA_PLL_CTRL_SET\n+\t\t\t: XGBE_PMA_PLL_CTRL_CLEAR);\n+\n+\t/* Wait for command to complete */\n+\trte_delay_us(150);\n+}\n+\n static void axgbe_phy_start_ratechange(struct axgbe_port *pdata)\n {\n+\t/* Clear the PLL so that it helps in power down sequence */\n+\taxgbe_phy_pll_ctrl(pdata, false);\n+\n \t/* Log if a previous command did not complete */\n \tif (XP_IOREAD_BITS(pdata, XP_DRIVER_INT_RO, STATUS))\n \t\tPMD_DRV_LOG(NOTICE, \"firmware mailbox not ready for command\\n\");\n@@ -1213,10 +1227,14 @@ static void axgbe_phy_complete_ratechange(struct axgbe_port *pdata)\n \twait = AXGBE_RATECHANGE_COUNT;\n \twhile (wait--) {\n \t\tif (!XP_IOREAD_BITS(pdata, XP_DRIVER_INT_RO, STATUS))\n-\t\t\treturn;\n-\n+\t\t\tgoto reenable_pll;\n \t\trte_delay_us(1500);\n \t}\n+\n+reenable_pll:\n+\t /* Re-enable the PLL control */\n+\taxgbe_phy_pll_ctrl(pdata, true);\n+\n \tPMD_DRV_LOG(NOTICE, \"firmware mailbox command did not complete\\n\");\n }\n \n", "prefixes": [ "v1", "2/6" ] }