Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/105711/?format=api
{ "id": 105711, "url": "http://patchwork.dpdk.org/api/patches/105711/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220110113509.553184-4-ssebasti@amd.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220110113509.553184-4-ssebasti@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220110113509.553184-4-ssebasti@amd.com", "date": "2022-01-10T11:35:06", "name": "[v1,3/6] net/axgbe: simplify mailbox interface rate change code", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "1976ed9eb90b0d3c74bbd508dc4d5d19a7cc42a0", "submitter": { "id": 1604, "url": "http://patchwork.dpdk.org/api/people/1604/?format=api", "name": "Selwin Sebastian", "email": "ssebasti@amd.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220110113509.553184-4-ssebasti@amd.com/mbox/", "series": [ { "id": 21109, "url": "http://patchwork.dpdk.org/api/series/21109/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21109", "date": "2022-01-10T11:35:04", "name": "[v1,1/6] net/axgbe: always attempt link training in KR mode", "version": 1, "mbox": "http://patchwork.dpdk.org/series/21109/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/105711/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/105711/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7E02FA034D;\n\tMon, 10 Jan 2022 12:35:56 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 98AA541159;\n\tMon, 10 Jan 2022 12:35:40 +0100 (CET)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2052.outbound.protection.outlook.com [40.107.220.52])\n by mails.dpdk.org (Postfix) with ESMTP id 5380B41174\n for <dev@dpdk.org>; Mon, 10 Jan 2022 12:35:39 +0100 (CET)", "from CO2PR04CA0152.namprd04.prod.outlook.com (2603:10b6:104::30) by\n BN9PR12MB5383.namprd12.prod.outlook.com (2603:10b6:408:104::7) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.4867.9; Mon, 10 Jan 2022 11:35:36 +0000", "from CO1NAM11FT021.eop-nam11.prod.protection.outlook.com\n (2603:10b6:104:0:cafe::50) by CO2PR04CA0152.outlook.office365.com\n (2603:10b6:104::30) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9 via Frontend\n Transport; Mon, 10 Jan 2022 11:35:36 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CO1NAM11FT021.mail.protection.outlook.com (10.13.175.51) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.4867.7 via Frontend Transport; Mon, 10 Jan 2022 11:35:35 +0000", "from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 10 Jan\n 2022 05:35:34 -0600" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=FpR/JphyBjpkSKVj2uKyZaaGmONrbPZ+kZgg7U64YyMtAChp1yzLyXn7++YgsTY8aMvPA11Nx8VlOLB9VZ7Dmyo+07EKSTv4XfeVxLsz1m+mbqHsSmZ+IkY8xE5WitNcmjEY/woeobpAdCj75r3HeAk1SE652o4wSD7JLbNVWfkN8ewz1AcugVRaj/efGAOU4X9UAQuA/vothmJ/c6bATotSXv330vrrctpIBlquKuN16NwEMgOnscC6z9mSOrn7QKeN/aRI+Bk7EumiZ0/iRbNVlwEaRuVrKcXLsPJRPpwyvSbjB1ppur8WOlxUghjWZr0/qIHo6iBhd6jP+Chdnw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=EDNq/bUaboLX1syhoRERxWGpOwl5JGhCkcks2RDjzMY=;\n b=GdlIJkNTcusV2sDWxGumQ4Z6d3oetMQAkrVxJMCwhaJcK4EH7PXj6ZKN+o2y/rEHPA/427qKpZj5OazBYIJcus3NYLpOVzusbmlXDk0FNoDYfGFFbTNkAE8ibBlKGMRgyXifQSaAs2c5w7l4rXwDAYXWZO4n4CrNsd0qptMpgboyp+W2ePNbEtZzyN28JvV5VI104pXkVakDcMEU1AFkby6d5VgRVz6j9p/RqR9EB+fMLYNzxFMPt4/KwTIka2Pn072gK5w853dGZ7DeUET7Rq2/2UM619tsUXdAhtzrTSUFo3za//Y/SnVY/vpAnwqkLGNr9pRe0uUEv+kOQYj1tw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=EDNq/bUaboLX1syhoRERxWGpOwl5JGhCkcks2RDjzMY=;\n b=a4/aYdZwOGafhwQIMtqEm4GrLzLA56eL2XhsitWJWX77qH5UD35rj1/AoYVGtW9gyxSNLHK5YhWTmITJ5EfKvLm/+AoQnPCMrXWeMFTaZydx+9SXx/T4vS7wMsvAb1LqYcGw1qx9waS8NhLdQQ5xDpWjr2GkNnv0TdoJDtXS9GA=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com;", "From": "<ssebasti@amd.com>", "To": "<dev@dpdk.org>", "Subject": "[PATCH v1 3/6] net/axgbe: simplify mailbox interface rate change code", "Date": "Mon, 10 Jan 2022 17:05:06 +0530", "Message-ID": "<20220110113509.553184-4-ssebasti@amd.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220110113509.553184-1-ssebasti@amd.com>", "References": "<20220110113509.553184-1-ssebasti@amd.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "fb3d563f-2a14-4922-5d40-08d9d42d51e6", "X-MS-TrafficTypeDiagnostic": "BN9PR12MB5383:EE_", "X-Microsoft-Antispam-PRVS": "\n <BN9PR12MB5383F382FBD20529E5EEDBA18D509@BN9PR12MB5383.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:5797;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n PQ0ByDEdBaGnRMx0cIOC91lKxgHiTEiyb3+K6cKmJiuUiX6/7GZW3kM2HHPjroAE3mg0o0l3ViRzanDb7H4mjrVF0n1VrMxunMiXO4Js2ZqIHFkfOL/Zq6PxDNylBciZnj57i90WXrrskK33fVzYogycURIh+sWi6IqCZ3l0Snw5HrmgjAP2EUMh+KGtmJSZYeKHjx/2r1CJzEnPJ8iTuwDwCxxcqUaQsSamJuVr40sCe09OfciSvZ50psUpEj+VXlFZyqvK8q1qOhv2fICsS+3KCg4G2s6nDaZF/oCTL4wWUor5bu70qOnLMDm4cGo2LGlD4KSiq+T7DLZfSmzAVJt/VS+vi50ktd2IoFhJkO2QnR0sxIHXbvLzTdZUSpXnKiLBvTQdN9AmQjgJ40MhnrqiHU06q2rMmM1vdgN0ZGaZsmCiYNJrXzthqxOcN0HKDr8Kby7Uh2tjkM3/+FESA9JJwHUXmwr51hvOGKsfwDYnByMYFCO8fi+yBL8FPxEtz2THeYQ6cniSw/11dM6enqiyNcPs435X/0uvnCpICKyZN5863EUA1xwvjSYOpeWpaf2LlS4ZhcgC+DNaHLtkFabSmjv3L6Utp6xNgAg8Y/8DIEDGqTDbXmGmnjZCFSwGo+AtpeoCPDkSDPO5ISorObY/Mn5S8/cPnAThILCn2T/eU92eyt1Cd73CaHvd4ZWQS4lg8Ku0mRsJzyzcg2SKtsTcxnPnJOYYBIYdwq7xySqxyDAxPmzoTV2RtK7WXTA8HJmUVI/3M8qtIv8J8HdhCgHBhbVpd9dW/UB0NM9hR3Y=", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(4636009)(40470700002)(36840700001)(46966006)(6916009)(83380400001)(6666004)(8936002)(2876002)(8676002)(426003)(5660300002)(26005)(336012)(7696005)(1076003)(316002)(186003)(16526019)(508600001)(356005)(36756003)(2906002)(70586007)(2616005)(81166007)(70206006)(15650500001)(36860700001)(47076005)(82310400004)(40460700001)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "10 Jan 2022 11:35:35.9960 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n fb3d563f-2a14-4922-5d40-08d9d42d51e6", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT021.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN9PR12MB5383", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Selwin Sebastian <selwin.sebastian@amd.com>\n\nSimplify and centralize the mailbox command rate change interface by\nhaving a single function perform the writes to the mailbox registers\nto issue the request.\n\nSigned-off-by: Selwin Sebastian <selwin.sebastian@amd.com>\n---\n drivers/net/axgbe/axgbe_phy_impl.c | 95 ++++++++----------------------\n 1 file changed, 23 insertions(+), 72 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c\nindex dc9489f0aa..0894dbf74b 100644\n--- a/drivers/net/axgbe/axgbe_phy_impl.c\n+++ b/drivers/net/axgbe/axgbe_phy_impl.c\n@@ -1207,21 +1207,26 @@ static void axgbe_phy_pll_ctrl(struct axgbe_port *pdata, bool enable)\n \trte_delay_us(150);\n }\n \n-static void axgbe_phy_start_ratechange(struct axgbe_port *pdata)\n+static void axgbe_phy_perform_ratechange(struct axgbe_port *pdata,\n+\t\t\t\t\tunsigned int cmd, unsigned int sub_cmd)\n {\n+\tunsigned int s0 = 0;\n+\tunsigned int wait;\n \t/* Clear the PLL so that it helps in power down sequence */\n \taxgbe_phy_pll_ctrl(pdata, false);\n \n \t/* Log if a previous command did not complete */\n \tif (XP_IOREAD_BITS(pdata, XP_DRIVER_INT_RO, STATUS))\n \t\tPMD_DRV_LOG(NOTICE, \"firmware mailbox not ready for command\\n\");\n-\telse\n-\t\treturn;\n-}\n \n-static void axgbe_phy_complete_ratechange(struct axgbe_port *pdata)\n-{\n-\tunsigned int wait;\n+\t/* Construct the command */\n+\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, COMMAND, cmd);\n+\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, SUB_COMMAND, sub_cmd);\n+\n+\t/* Issue the command */\n+\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_0, s0);\n+\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_1, 0);\n+\tXP_IOWRITE_BITS(pdata, XP_DRIVER_INT_REQ, REQUEST, 1);\n \n \t/* Wait for command to complete */\n \twait = AXGBE_RATECHANGE_COUNT;\n@@ -1240,21 +1245,10 @@ static void axgbe_phy_complete_ratechange(struct axgbe_port *pdata)\n \n static void axgbe_phy_rrc(struct axgbe_port *pdata)\n {\n-\tunsigned int s0;\n \n-\taxgbe_phy_start_ratechange(pdata);\n \n \t/* Receiver Reset Cycle */\n-\ts0 = 0;\n-\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, COMMAND, 5);\n-\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, SUB_COMMAND, 0);\n-\n-\t/* Call FW to make the change */\n-\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_0, s0);\n-\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_1, 0);\n-\tXP_IOWRITE_BITS(pdata, XP_DRIVER_INT_REQ, REQUEST, 1);\n-\n-\taxgbe_phy_complete_ratechange(pdata);\n+\taxgbe_phy_perform_ratechange(pdata, 5, 0);\n \n \tPMD_DRV_LOG(DEBUG, \"receiver reset complete\\n\");\n }\n@@ -1263,13 +1257,9 @@ static void axgbe_phy_power_off(struct axgbe_port *pdata)\n {\n \tstruct axgbe_phy_data *phy_data = pdata->phy_data;\n \n-\taxgbe_phy_start_ratechange(pdata);\n+\t/* Power off */\n+\taxgbe_phy_perform_ratechange(pdata, 0, 0);\n \n-\t/* Call FW to make the change */\n-\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_0, 0);\n-\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_1, 0);\n-\tXP_IOWRITE_BITS(pdata, XP_DRIVER_INT_REQ, REQUEST, 1);\n-\taxgbe_phy_complete_ratechange(pdata);\n \tphy_data->cur_mode = AXGBE_MODE_UNKNOWN;\n \n \tPMD_DRV_LOG(DEBUG, \"phy powered off\\n\");\n@@ -1278,31 +1268,21 @@ static void axgbe_phy_power_off(struct axgbe_port *pdata)\n static void axgbe_phy_sfi_mode(struct axgbe_port *pdata)\n {\n \tstruct axgbe_phy_data *phy_data = pdata->phy_data;\n-\tunsigned int s0;\n \n \taxgbe_phy_set_redrv_mode(pdata);\n \n-\taxgbe_phy_start_ratechange(pdata);\n-\n \t/* 10G/SFI */\n-\ts0 = 0;\n-\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, COMMAND, 3);\n \tif (phy_data->sfp_cable != AXGBE_SFP_CABLE_PASSIVE) {\n-\t\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, SUB_COMMAND, 0);\n+\t\taxgbe_phy_perform_ratechange(pdata, 3, 0);\n \t} else {\n \t\tif (phy_data->sfp_cable_len <= 1)\n-\t\t\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, SUB_COMMAND, 1);\n+\t\t\taxgbe_phy_perform_ratechange(pdata, 3, 1);\n \t\telse if (phy_data->sfp_cable_len <= 3)\n-\t\t\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, SUB_COMMAND, 2);\n+\t\t\taxgbe_phy_perform_ratechange(pdata, 3, 2);\n \t\telse\n-\t\t\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, SUB_COMMAND, 3);\n+\t\t\taxgbe_phy_perform_ratechange(pdata, 3, 3);\n \t}\n \n-\t/* Call FW to make the change */\n-\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_0, s0);\n-\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_1, 0);\n-\tXP_IOWRITE_BITS(pdata, XP_DRIVER_INT_REQ, REQUEST, 1);\n-\taxgbe_phy_complete_ratechange(pdata);\n \tphy_data->cur_mode = AXGBE_MODE_SFI;\n \n \tPMD_DRV_LOG(DEBUG, \"10GbE SFI mode set\\n\");\n@@ -1311,22 +1291,11 @@ static void axgbe_phy_sfi_mode(struct axgbe_port *pdata)\n static void axgbe_phy_kr_mode(struct axgbe_port *pdata)\n {\n \tstruct axgbe_phy_data *phy_data = pdata->phy_data;\n-\tunsigned int s0;\n \n \taxgbe_phy_set_redrv_mode(pdata);\n \n-\taxgbe_phy_start_ratechange(pdata);\n-\n \t/* 10G/KR */\n-\ts0 = 0;\n-\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, COMMAND, 4);\n-\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, SUB_COMMAND, 0);\n-\n-\t/* Call FW to make the change */\n-\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_0, s0);\n-\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_1, 0);\n-\tXP_IOWRITE_BITS(pdata, XP_DRIVER_INT_REQ, REQUEST, 1);\n-\taxgbe_phy_complete_ratechange(pdata);\n+\taxgbe_phy_perform_ratechange(pdata, 4, 0);\n \tphy_data->cur_mode = AXGBE_MODE_KR;\n \n \tPMD_DRV_LOG(DEBUG, \"10GbE KR mode set\\n\");\n@@ -1335,40 +1304,22 @@ static void axgbe_phy_kr_mode(struct axgbe_port *pdata)\n static void axgbe_phy_kx_2500_mode(struct axgbe_port *pdata)\n {\n \tstruct axgbe_phy_data *phy_data = pdata->phy_data;\n-\tunsigned int s0;\n \n \taxgbe_phy_set_redrv_mode(pdata);\n-\t/* 2.5G/KX */\n-\taxgbe_phy_start_ratechange(pdata);\n-\ts0 = 0;\n-\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, COMMAND, 2);\n-\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, SUB_COMMAND, 0);\n-\n-\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_0, s0);\n-\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_1, 0);\n-\n-\tXP_IOWRITE_BITS(pdata, XP_DRIVER_INT_REQ, REQUEST, 1);\n \n+\t/* 2.5G/KX */\n+\taxgbe_phy_perform_ratechange(pdata, 2, 0);\n \tphy_data->cur_mode = AXGBE_MODE_KX_2500;\n }\n \n static void axgbe_phy_sgmii_1000_mode(struct axgbe_port *pdata)\n {\n \tstruct axgbe_phy_data *phy_data = pdata->phy_data;\n-\tunsigned int s0;\n \n \taxgbe_phy_set_redrv_mode(pdata);\n \n \t/* 1G/SGMII */\n-\taxgbe_phy_start_ratechange(pdata);\n-\ts0 = 0;\n-\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, COMMAND, 1);\n-\tXP_SET_BITS(s0, XP_DRIVER_SCRATCH_0, SUB_COMMAND, 2);\n-\n-\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_0, s0);\n-\tXP_IOWRITE(pdata, XP_DRIVER_SCRATCH_1, 0);\n-\n-\tXP_IOWRITE_BITS(pdata, XP_DRIVER_INT_REQ, REQUEST, 1);\n+\taxgbe_phy_perform_ratechange(pdata, 1, 2);\n \n \tphy_data->cur_mode = AXGBE_MODE_SGMII_1000;\n }\n", "prefixes": [ "v1", "3/6" ] }