Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106354/?format=api
{ "id": 106354, "url": "http://patchwork.dpdk.org/api/patches/106354/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220124150339.280090-4-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220124150339.280090-4-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220124150339.280090-4-ciara.power@intel.com", "date": "2022-01-24T15:03:38", "name": "[v2,3/4] crypto: add asym session user data API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1159acfea7b8ca81eaa48c36f3f210dc41f6f89c", "submitter": { "id": 978, "url": "http://patchwork.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220124150339.280090-4-ciara.power@intel.com/mbox/", "series": [ { "id": 21331, "url": "http://patchwork.dpdk.org/api/series/21331/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21331", "date": "2022-01-24T15:03:39", "name": "crypto: improve asym session usage", "version": 2, "mbox": "http://patchwork.dpdk.org/series/21331/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/106354/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/106354/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CE1BAA04A8;\n\tMon, 24 Jan 2022 16:04:39 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0F102427DB;\n\tMon, 24 Jan 2022 16:04:27 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id 1684141154\n for <dev@dpdk.org>; Mon, 24 Jan 2022 16:04:23 +0100 (CET)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 24 Jan 2022 07:03:56 -0800", "from silpixa00400355.ir.intel.com (HELO\n silpixa00400355.ger.corp.intel.com) ([10.237.222.49])\n by orsmga003.jf.intel.com with ESMTP; 24 Jan 2022 07:03:54 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1643036664; x=1674572664;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=WfxoP1SNmmoiM1PmIzipgZxliyo6UZIlZ09l1nFbXfg=;\n b=V9XF8IkPS2j1svuDzr+XkWJodrKHHE+wywxhfoL2uextyHcwM+4GQi7U\n WD5w4GdjjKM3HG9B32MQxOdxkEgYth07G3eZaEw6UBHxdLCE/TRCr8rZQ\n 3Id5t2PyExCdmlM9HrGFbAs0tFBF54/lpEaILaWEO+EiANcf83qsTzoN6\n Q3XFtEW4U97FocdFjSJTnEIN3pozsm3qY+e5KkFEIFkEBSJDJfHeI72Vd\n SjjpGgx1Sy+xyQ0Zrq6OEe2yIX/rIq6ngaWz0PRRqQNuxy9l2Rjg3fNG3\n xlugzf9FnrV7lRJrR5hXl8StIT+VN3Ifo5jI0pUQvqn+F23oSHYPyNuF7 A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10236\"; a=\"332417209\"", "E=Sophos;i=\"5.88,311,1635231600\"; d=\"scan'208\";a=\"332417209\"", "E=Sophos;i=\"5.88,311,1635231600\"; d=\"scan'208\";a=\"476744136\"" ], "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "roy.fan.zhang@intel.com, gakhil@marvell.com, anoobj@marvell.com,\n mdr@ashroe.eu, Ciara Power <ciara.power@intel.com>,\n Declan Doherty <declan.doherty@intel.com>", "Subject": "[PATCH v2 3/4] crypto: add asym session user data API", "Date": "Mon, 24 Jan 2022 15:03:38 +0000", "Message-Id": "<20220124150339.280090-4-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220124150339.280090-1-ciara.power@intel.com>", "References": "<20220124150339.280090-1-ciara.power@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "A user data field is added to the asymmetric session structure.\nRelevant API added to get/set the field.\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n\n---\nv2: Corrected order of version map entries.\n---\n app/test/test_cryptodev_asym.c | 2 +-\n lib/cryptodev/cryptodev_pmd.h | 4 ++-\n lib/cryptodev/rte_cryptodev.c | 39 ++++++++++++++++++++++++++---\n lib/cryptodev/rte_cryptodev.h | 34 ++++++++++++++++++++++++-\n lib/cryptodev/rte_cryptodev_trace.h | 3 ++-\n lib/cryptodev/version.map | 2 ++\n 6 files changed, 76 insertions(+), 8 deletions(-)", "diff": "diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c\nindex f93f39af42..a81d6292f6 100644\n--- a/app/test/test_cryptodev_asym.c\n+++ b/app/test/test_cryptodev_asym.c\n@@ -897,7 +897,7 @@ testsuite_setup(void)\n \t}\n \n \tts_params->session_mpool = rte_cryptodev_asym_session_pool_create(\n-\t\t\t\"test_asym_sess_mp\", TEST_NUM_SESSIONS * 2, 0,\n+\t\t\t\"test_asym_sess_mp\", TEST_NUM_SESSIONS * 2, 0, 0,\n \t\t\tSOCKET_ID_ANY);\n \n \tTEST_ASSERT_NOT_NULL(ts_params->session_mpool,\ndiff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h\nindex 2d12505d3c..a0f7bb0c05 100644\n--- a/lib/cryptodev/cryptodev_pmd.h\n+++ b/lib/cryptodev/cryptodev_pmd.h\n@@ -636,7 +636,9 @@ __extension__ struct rte_cryptodev_asym_session {\n \t/**< Session driver ID. */\n \tuint8_t max_priv_session_sz;\n \t/**< size of private session data used when creating mempool */\n-\tuint8_t padding[6];\n+\tuint16_t user_data_sz;\n+\t/**< session user data will be placed after sess_data */\n+\tuint8_t padding[4];\n \tuint8_t sess_private_data[0];\n };\n \ndiff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c\nindex c10b9bf05f..2a591930de 100644\n--- a/lib/cryptodev/rte_cryptodev.c\n+++ b/lib/cryptodev/rte_cryptodev.c\n@@ -210,6 +210,8 @@ struct rte_cryptodev_sym_session_pool_private_data {\n struct rte_cryptodev_asym_session_pool_private_data {\n \tuint8_t max_priv_session_sz;\n \t/**< size of private session data used when creating mempool */\n+\tuint16_t user_data_sz;\n+\t/**< session user data will be placed after sess_private_data */\n };\n \n int\n@@ -1803,7 +1805,7 @@ rte_cryptodev_sym_session_pool_create(const char *name, uint32_t nb_elts,\n \n struct rte_mempool *\n rte_cryptodev_asym_session_pool_create(const char *name, uint32_t nb_elts,\n-\tuint32_t cache_size, int socket_id)\n+\tuint32_t cache_size, uint16_t user_data_size, int socket_id)\n {\n \tstruct rte_mempool *mp;\n \tstruct rte_cryptodev_asym_session_pool_private_data *pool_priv;\n@@ -1821,7 +1823,8 @@ rte_cryptodev_asym_session_pool_create(const char *name, uint32_t nb_elts,\n \t\treturn NULL;\n \t}\n \n-\tobj_sz = rte_cryptodev_asym_get_header_session_size() + max_priv_sz;\n+\tobj_sz = rte_cryptodev_asym_get_header_session_size() + max_priv_sz +\n+\t\t\tuser_data_size;\n \tobj_sz_aligned = RTE_ALIGN_CEIL(obj_sz, RTE_CACHE_LINE_SIZE);\n \n \tmp = rte_mempool_create(name, nb_elts, obj_sz_aligned, cache_size,\n@@ -1844,7 +1847,7 @@ rte_cryptodev_asym_session_pool_create(const char *name, uint32_t nb_elts,\n \tpool_priv->max_priv_session_sz = max_priv_sz;\n \n \trte_cryptodev_trace_asym_session_pool_create(name, nb_elts,\n-\t\tcache_size, mp);\n+\t\tuser_data_size, cache_size, mp);\n \treturn mp;\n }\n \n@@ -1958,12 +1961,13 @@ rte_cryptodev_asym_session_create(struct rte_mempool *mp, uint8_t dev_id,\n \t}\n \n \tsess->driver_id = dev->driver_id;\n+\tsess->user_data_sz = pool_priv->user_data_sz;\n \tsess->max_priv_session_sz = pool_priv->max_priv_session_sz;\n \n \t/* Clear device session pointer.\n \t * Include the flag indicating presence of private data\n \t */\n-\tmemset(sess->sess_private_data, 0, session_priv_data_sz);\n+\tmemset(sess->sess_private_data, 0, session_priv_data_sz + sess->user_data_sz);\n \n \tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->asym_session_configure, NULL);\n \n@@ -2173,6 +2177,33 @@ rte_cryptodev_sym_session_get_user_data(\n \treturn (void *)(sess->sess_data + sess->nb_drivers);\n }\n \n+int\n+rte_cryptodev_asym_session_set_user_data(void *session, void *data, uint16_t size)\n+{\n+\tstruct rte_cryptodev_asym_session *sess = session;\n+\tif (sess == NULL)\n+\t\treturn -EINVAL;\n+\n+\tif (sess->user_data_sz < size)\n+\t\treturn -ENOMEM;\n+\n+\trte_memcpy(sess->sess_private_data +\n+\t\t\tsess->max_priv_session_sz,\n+\t\t\tdata, size);\n+\treturn 0;\n+}\n+\n+void *\n+rte_cryptodev_asym_session_get_user_data(void *session)\n+{\n+\tstruct rte_cryptodev_asym_session *sess = session;\n+\tif (sess == NULL || sess->user_data_sz == 0)\n+\t\treturn NULL;\n+\n+\treturn (void *)(sess->sess_private_data +\n+\t\t\tsess->max_priv_session_sz);\n+}\n+\n static inline void\n sym_crypto_fill_status(struct rte_crypto_sym_vec *vec, int32_t errnum)\n {\ndiff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h\nindex af328de896..6a4d6d9934 100644\n--- a/lib/cryptodev/rte_cryptodev.h\n+++ b/lib/cryptodev/rte_cryptodev.h\n@@ -959,6 +959,8 @@ rte_cryptodev_sym_session_pool_create(const char *name, uint32_t nb_elts,\n * The number of elements in the mempool.\n * @param cache_size\n * The number of per-lcore cache elements\n+ * @param user_data_size\n+ * The size of user data to be placed after session private data.\n * @param socket_id\n * The *socket_id* argument is the socket identifier in the case of\n * NUMA. The value can be *SOCKET_ID_ANY* if there is no NUMA\n@@ -971,7 +973,7 @@ rte_cryptodev_sym_session_pool_create(const char *name, uint32_t nb_elts,\n __rte_experimental\n struct rte_mempool *\n rte_cryptodev_asym_session_pool_create(const char *name, uint32_t nb_elts,\n-\tuint32_t cache_size, int socket_id);\n+\tuint32_t cache_size, uint16_t user_data_size, int socket_id);\n \n /**\n * Create symmetric crypto session header (generic with no private data)\n@@ -1213,6 +1215,36 @@ void *\n rte_cryptodev_sym_session_get_user_data(\n \t\t\t\t\tstruct rte_cryptodev_sym_session *sess);\n \n+/**\n+ * Store user data in an asymmetric session.\n+ *\n+ * @param\tsess\t\tSession pointer allocated by\n+ *\t\t\t\t*rte_cryptodev_asym_session_create*.\n+ * @param\tdata\t\tPointer to the user data.\n+ * @param\tsize\t\tSize of the user data.\n+ *\n+ * @return\n+ * - On success, zero.\n+ * - On failure, a negative value.\n+ */\n+__rte_experimental\n+int\n+rte_cryptodev_asym_session_set_user_data(void *sess, void *data, uint16_t size);\n+\n+/**\n+ * Get user data stored in an asymmetric session.\n+ *\n+ * @param\tsess\t\tSession pointer allocated by\n+ *\t\t\t\t*rte_cryptodev_asym_session_create*.\n+ *\n+ * @return\n+ * - On success return pointer to user data.\n+ * - On failure returns NULL.\n+ */\n+__rte_experimental\n+void *\n+rte_cryptodev_asym_session_get_user_data(void *sess);\n+\n /**\n * Perform actual crypto processing (encrypt/digest or auth/decrypt)\n * on user provided data.\ndiff --git a/lib/cryptodev/rte_cryptodev_trace.h b/lib/cryptodev/rte_cryptodev_trace.h\nindex 2c9de4f6de..563c719598 100644\n--- a/lib/cryptodev/rte_cryptodev_trace.h\n+++ b/lib/cryptodev/rte_cryptodev_trace.h\n@@ -86,9 +86,10 @@ RTE_TRACE_POINT(\n RTE_TRACE_POINT(\n \trte_cryptodev_trace_asym_session_pool_create,\n \tRTE_TRACE_POINT_ARGS(const char *name, uint32_t nb_elts,\n-\t\tuint32_t cache_size, void *mempool),\n+\t\tuint16_t user_data_size, uint32_t cache_size, void *mempool),\n \trte_trace_point_emit_string(name);\n \trte_trace_point_emit_u32(nb_elts);\n+\trte_trace_point_emit_u16(user_data_size);\n \trte_trace_point_emit_u32(cache_size);\n \trte_trace_point_emit_ptr(mempool);\n )\ndiff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map\nindex b1f2d6c7f0..816f3e831d 100644\n--- a/lib/cryptodev/version.map\n+++ b/lib/cryptodev/version.map\n@@ -104,7 +104,9 @@ EXPERIMENTAL {\n \trte_cryptodev_remove_enq_callback;\n \n \t# added 22.03\n+\trte_cryptodev_asym_session_get_user_data;\n \trte_cryptodev_asym_session_pool_create;\n+\trte_cryptodev_asym_session_set_user_data;\n \t__rte_cryptodev_trace_asym_session_pool_create;\n };\n \n", "prefixes": [ "v2", "3/4" ] }