Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/106652/?format=api
{ "id": 106652, "url": "http://patchwork.dpdk.org/api/patches/106652/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220128022533.44249-3-humin29@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220128022533.44249-3-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220128022533.44249-3-humin29@huawei.com", "date": "2022-01-28T02:25:33", "name": "[2/2] net/bonding: fix reference count on mbufs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2624df0b78f6205fccac0f8608169cdf67f9cc49", "submitter": { "id": 1944, "url": "http://patchwork.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220128022533.44249-3-humin29@huawei.com/mbox/", "series": [ { "id": 21407, "url": "http://patchwork.dpdk.org/api/series/21407/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21407", "date": "2022-01-28T02:25:31", "name": "bugfix for bonding", "version": 1, "mbox": "http://patchwork.dpdk.org/series/21407/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/106652/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/106652/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E78A9A00C4;\n\tFri, 28 Jan 2022 03:25:33 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E55AD4281D;\n\tFri, 28 Jan 2022 03:25:24 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id CD644411FE\n for <dev@dpdk.org>; Fri, 28 Jan 2022 03:25:21 +0100 (CET)", "from dggeme756-chm.china.huawei.com (unknown [172.30.72.53])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4JlLqf28Ngz9sJ6;\n Fri, 28 Jan 2022 10:23:58 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2308.21; Fri, 28 Jan 2022 10:25:19 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <thomas@monjalon.net>", "Subject": "[PATCH 2/2] net/bonding: fix reference count on mbufs", "Date": "Fri, 28 Jan 2022 10:25:33 +0800", "Message-ID": "<20220128022533.44249-3-humin29@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20220128022533.44249-1-humin29@huawei.com>", "References": "<20220128022533.44249-1-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n dggeme756-chm.china.huawei.com (10.3.19.102)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In bonding Tx broadcast mode, Packets should be sent by every slave,\nbut only one mbuf exits. The solution is to increment reference count\non mbufs, but it ignores multi segments.\n\nThis patch fixed it by adding reference for every segment in multi\nsegments Tx scenario.\n\nFixes: 2efb58cbab6e (\"bond: new link bonding library\")\nCc: stable@dpdk.org\n\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex ba587e60bf..c1d9300100 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -1318,7 +1318,7 @@ bond_ethdev_tx_burst_broadcast(void *queue, struct rte_mbuf **bufs,\n \n \t/* Increment reference count on mbufs */\n \tfor (i = 0; i < nb_pkts; i++)\n-\t\trte_mbuf_refcnt_update(bufs[i], num_of_slaves - 1);\n+\t\trte_pktmbuf_refcnt_update(bufs[i], num_of_slaves - 1);\n \n \t/* Transmit burst on each active slave */\n \tfor (i = 0; i < num_of_slaves; i++) {\n", "prefixes": [ "2/2" ] }