Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107013/?format=api
{ "id": 107013, "url": "http://patchwork.dpdk.org/api/patches/107013/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220208101129.69173-2-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220208101129.69173-2-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220208101129.69173-2-jiawenwu@trustnetic.com", "date": "2022-02-08T10:11:21", "name": "[1/9] net/ngbe: fix failed to receive packets", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "1c61e70ce8c0a32e5d4170ebe4bdf74e40a27027", "submitter": { "id": 1932, "url": "http://patchwork.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220208101129.69173-2-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 21520, "url": "http://patchwork.dpdk.org/api/series/21520/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21520", "date": "2022-02-08T10:11:20", "name": "Wangxun fixes and supports", "version": 1, "mbox": "http://patchwork.dpdk.org/series/21520/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/107013/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/107013/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A2CE4A04AD;\n\tTue, 8 Feb 2022 11:05:20 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 335D741147;\n\tTue, 8 Feb 2022 11:05:13 +0100 (CET)", "from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166])\n by mails.dpdk.org (Postfix) with ESMTP id E5AED41153\n for <dev@dpdk.org>; Tue, 8 Feb 2022 11:05:10 +0100 (CET)", "from wxdbg.localdomain.com (unknown [183.129.236.74])\n by bizesmtp.qq.com (ESMTP) with\n id ; Tue, 08 Feb 2022 18:04:58 +0800 (CST)" ], "X-QQ-mid": "bizesmtp46t1644314698t50g43pb", "X-QQ-SSF": "01400000002000F0L000B00A0000000", "X-QQ-FEAT": "ufm+TBkikDPFmwyAzx8qxl24OVvXruOTkUhzLTqbGKoDGtcGNmLrQtEfRQrVv\n LTieUUpowgZ1MvzrpseguKBrRs/zL+N0UUqA6Ywb9poY0EJ31PSuQPgDQ+/M/Ot4DiLHGnn\n VIrXaymSBqXxIXC4/ZjteldEnV5eKbT5ntepDdP2C4ZN3jYu5wzBaFoSEBrq3V0zptQjhMv\n Gmj3umkYtVm0P0cSiKLF6xN8tgrgZbsjzyR+lhA/OGJmtkDnHamFHqAzf9ofsM8MiB8lYJk\n eZxIYQavkhyTeDUe6fVQ7xom5sra64tMHMjsv+pOu2iSb8GclE6cItn90a29QZo8xumQ8M/\n JgW6tQUSgVXzFMSqdO9IgYsubr1+w==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 1/9] net/ngbe: fix failed to receive packets", "Date": "Tue, 8 Feb 2022 18:11:21 +0800", "Message-Id": "<20220208101129.69173-2-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20220208101129.69173-1-jiawenwu@trustnetic.com>", "References": "<20220208101129.69173-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign6", "X-QQ-Bgrelay": "1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Initialize Rx packet buffer before starting RxTx, ensure to receive\npackets.\n\nFixes: 62fc35e63d0e (\"net/ngbe: support Rx queue start/stop\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/ngbe/base/ngbe_dummy.h | 4 ++++\n drivers/net/ngbe/base/ngbe_hw.c | 27 +++++++++++++++++++++++++++\n drivers/net/ngbe/base/ngbe_hw.h | 2 ++\n drivers/net/ngbe/base/ngbe_type.h | 7 +++++++\n drivers/net/ngbe/ngbe_ethdev.c | 1 +\n 5 files changed, 41 insertions(+)", "diff": "diff --git a/drivers/net/ngbe/base/ngbe_dummy.h b/drivers/net/ngbe/base/ngbe_dummy.h\nindex 61b0d82bfb..d74c9f7b54 100644\n--- a/drivers/net/ngbe/base/ngbe_dummy.h\n+++ b/drivers/net/ngbe/base/ngbe_dummy.h\n@@ -114,6 +114,9 @@ static inline s32 ngbe_mac_get_link_capabilities_dummy(struct ngbe_hw *TUP0,\n {\n \treturn NGBE_ERR_OPS_DUMMY;\n }\n+static inline void ngbe_setup_pba_dummy(struct ngbe_hw *TUP0)\n+{\n+}\n static inline s32 ngbe_mac_led_on_dummy(struct ngbe_hw *TUP0, u32 TUP1)\n {\n \treturn NGBE_ERR_OPS_DUMMY;\n@@ -298,6 +301,7 @@ static inline void ngbe_init_ops_dummy(struct ngbe_hw *hw)\n \thw->mac.setup_link = ngbe_mac_setup_link_dummy;\n \thw->mac.check_link = ngbe_mac_check_link_dummy;\n \thw->mac.get_link_capabilities = ngbe_mac_get_link_capabilities_dummy;\n+\thw->mac.setup_pba = ngbe_setup_pba_dummy;\n \thw->mac.led_on = ngbe_mac_led_on_dummy;\n \thw->mac.led_off = ngbe_mac_led_off_dummy;\n \thw->mac.set_rar = ngbe_mac_set_rar_dummy;\ndiff --git a/drivers/net/ngbe/base/ngbe_hw.c b/drivers/net/ngbe/base/ngbe_hw.c\nindex 0716357725..0b22ea0fb3 100644\n--- a/drivers/net/ngbe/base/ngbe_hw.c\n+++ b/drivers/net/ngbe/base/ngbe_hw.c\n@@ -1609,6 +1609,30 @@ void ngbe_set_mac_anti_spoofing(struct ngbe_hw *hw, bool enable, int vf)\n \twr32(hw, NGBE_POOLTXASMAC, pfvfspoof);\n }\n \n+/**\n+ * ngbe_set_pba - Initialize Rx packet buffer\n+ * @hw: pointer to hardware structure\n+ * @headroom: reserve n KB of headroom\n+ **/\n+void ngbe_set_pba(struct ngbe_hw *hw)\n+{\n+\tu32 rxpktsize = hw->mac.rx_pb_size;\n+\tu32 txpktsize, txpbthresh;\n+\n+\t/* Reserve 256 KB of headroom */\n+\trxpktsize -= 256;\n+\n+\trxpktsize <<= 10;\n+\twr32(hw, NGBE_PBRXSIZE, rxpktsize);\n+\n+\t/* Only support an equally distributed Tx packet buffer strategy. */\n+\ttxpktsize = NGBE_PBTXSIZE_MAX;\n+\ttxpbthresh = (txpktsize / 1024) - NGBE_TXPKT_SIZE_MAX;\n+\n+\twr32(hw, NGBE_PBTXSIZE, txpktsize);\n+\twr32(hw, NGBE_PBTXDMATH, txpbthresh);\n+}\n+\n /**\n * ngbe_set_vlan_anti_spoofing - Enable/Disable VLAN anti-spoofing\n * @hw: pointer to hardware structure\n@@ -1907,6 +1931,8 @@ s32 ngbe_init_ops_pf(struct ngbe_hw *hw)\n \tmac->check_link = ngbe_check_mac_link_em;\n \tmac->setup_link = ngbe_setup_mac_link_em;\n \n+\tmac->setup_pba = ngbe_set_pba;\n+\n \t/* Manageability interface */\n \tmac->init_thermal_sensor_thresh = ngbe_init_thermal_sensor_thresh;\n \tmac->check_overtemp = ngbe_mac_check_overtemp;\n@@ -1928,6 +1954,7 @@ s32 ngbe_init_ops_pf(struct ngbe_hw *hw)\n \tmac->mcft_size\t\t= NGBE_EM_MC_TBL_SIZE;\n \tmac->vft_size\t\t= NGBE_EM_VFT_TBL_SIZE;\n \tmac->num_rar_entries\t= NGBE_EM_RAR_ENTRIES;\n+\tmac->rx_pb_size\t\t= NGBE_EM_RX_PB_SIZE;\n \tmac->max_rx_queues\t= NGBE_EM_MAX_RX_QUEUES;\n \tmac->max_tx_queues\t= NGBE_EM_MAX_TX_QUEUES;\n \ndiff --git a/drivers/net/ngbe/base/ngbe_hw.h b/drivers/net/ngbe/base/ngbe_hw.h\nindex ad7e8fc2d9..b32cf87ff4 100644\n--- a/drivers/net/ngbe/base/ngbe_hw.h\n+++ b/drivers/net/ngbe/base/ngbe_hw.h\n@@ -13,6 +13,7 @@\n #define NGBE_EM_RAR_ENTRIES 32\n #define NGBE_EM_MC_TBL_SIZE 32\n #define NGBE_EM_VFT_TBL_SIZE 128\n+#define NGBE_EM_RX_PB_SIZE 42 /*KB*/\n \n s32 ngbe_init_hw(struct ngbe_hw *hw);\n s32 ngbe_start_hw(struct ngbe_hw *hw);\n@@ -44,6 +45,7 @@ s32 ngbe_update_mc_addr_list(struct ngbe_hw *hw, u8 *mc_addr_list,\n \t\t\t\t ngbe_mc_addr_itr func, bool clear);\n s32 ngbe_disable_sec_rx_path(struct ngbe_hw *hw);\n s32 ngbe_enable_sec_rx_path(struct ngbe_hw *hw);\n+void ngbe_set_pba(struct ngbe_hw *hw);\n \n s32 ngbe_setup_fc_em(struct ngbe_hw *hw);\n s32 ngbe_fc_enable(struct ngbe_hw *hw);\ndiff --git a/drivers/net/ngbe/base/ngbe_type.h b/drivers/net/ngbe/base/ngbe_type.h\nindex 12847b7272..269e087d50 100644\n--- a/drivers/net/ngbe/base/ngbe_type.h\n+++ b/drivers/net/ngbe/base/ngbe_type.h\n@@ -11,6 +11,9 @@\n #define NGBE_FRAME_SIZE_MAX (9728) /* Maximum frame size, +FCS */\n #define NGBE_FRAME_SIZE_DFT (1522) /* Default frame size, +FCS */\n #define NGBE_NUM_POOL (32)\n+#define NGBE_PBRXSIZE_MAX 0x00080000 /* 512KB Packet Buffer */\n+#define NGBE_PBTXSIZE_MAX 0x00005000 /* 20KB Packet Buffer */\n+#define NGBE_TXPKT_SIZE_MAX 0xA /* Max Tx Packet size */\n #define NGBE_MAX_QP (8)\n #define NGBE_MAX_UTA 128\n \n@@ -269,6 +272,9 @@ struct ngbe_mac_info {\n \ts32 (*get_link_capabilities)(struct ngbe_hw *hw,\n \t\t\t\t u32 *speed, bool *autoneg);\n \n+\t/* Packet Buffer manipulation */\n+\tvoid (*setup_pba)(struct ngbe_hw *hw);\n+\n \t/* LED */\n \ts32 (*led_on)(struct ngbe_hw *hw, u32 index);\n \ts32 (*led_off)(struct ngbe_hw *hw, u32 index);\n@@ -311,6 +317,7 @@ struct ngbe_mac_info {\n \tu32 mcft_size;\n \tu32 vft_size;\n \tu32 num_rar_entries;\n+\tu32 rx_pb_size;\n \tu32 max_tx_queues;\n \tu32 max_rx_queues;\n \tbool get_link_status;\ndiff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c\nindex 0d66c32551..180489ce38 100644\n--- a/drivers/net/ngbe/ngbe_ethdev.c\n+++ b/drivers/net/ngbe/ngbe_ethdev.c\n@@ -1004,6 +1004,7 @@ ngbe_dev_start(struct rte_eth_dev *dev)\n \t\tgoto error;\n \t}\n \n+\thw->mac.setup_pba(hw);\n \tngbe_configure_port(dev);\n \n \terr = ngbe_dev_rxtx_start(dev);\n", "prefixes": [ "1/9" ] }