Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107127/?format=api
{ "id": 107127, "url": "http://patchwork.dpdk.org/api/patches/107127/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220209124358.137807-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220209124358.137807-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220209124358.137807-1-haiyue.wang@intel.com", "date": "2022-02-09T12:43:58", "name": "[v1] net/af_xdp: make umem configure code more readable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e90236bab3349715604320b3609c208be0229673", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220209124358.137807-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 21567, "url": "http://patchwork.dpdk.org/api/series/21567/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21567", "date": "2022-02-09T12:43:58", "name": "[v1] net/af_xdp: make umem configure code more readable", "version": 1, "mbox": "http://patchwork.dpdk.org/series/21567/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/107127/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/107127/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 63FFFA04A5;\n\tWed, 9 Feb 2022 14:17:49 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EFD5B41143;\n\tWed, 9 Feb 2022 14:17:48 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id BFFD940140\n for <dev@dpdk.org>; Wed, 9 Feb 2022 14:17:47 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Feb 2022 05:17:46 -0800", "from npg-dpdk-haiyue-2.sh.intel.com ([10.67.118.240])\n by FMSMGA003.fm.intel.com with ESMTP; 09 Feb 2022 05:17:45 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1644412667; x=1675948667;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=vlQR8wanqcJRW4flBypPsHN7dZCTwvhuXoLu1CSa0Qg=;\n b=aGd+ih7kPcf0Nkgo2rvfKZsW1jToKl3FchgUKA2XQlEsPe5lxWzhb10i\n brzik3f/rnQnurC4qjP3v3d0W+ZifffwI6Gxvss1zayZXZYzAXC6bUHkY\n cjtRQbkk+CNxZcPpbMI66NMpTpTdPfkSjwE/MBSdBLyMnLjIZafnwAiq6\n c/KH7Y9AjVoJjkYW6SuiSH9NAfWoiCjCpHugWLE/9+NJ1CB4zCTUPHHHH\n Yy+Yvl/OTWxNbhxOCzc/pX5cS2hh5hz9fKRQR1patX+m7HgNajEVV4hzU\n LxMMaJIRCfuEwE8MHnF0QJBgEVFXsC8/bYGtgz9uaDARNqUffNv95QO9z Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10252\"; a=\"249149444\"", "E=Sophos;i=\"5.88,355,1635231600\"; d=\"scan'208\";a=\"249149444\"", "E=Sophos;i=\"5.88,355,1635231600\"; d=\"scan'208\";a=\"622272303\"" ], "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "Haiyue Wang <haiyue.wang@intel.com>,\n Ciara Loftus <ciara.loftus@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>", "Subject": "[PATCH v1] net/af_xdp: make umem configure code more readable", "Date": "Wed, 9 Feb 2022 20:43:58 +0800", "Message-Id": "<20220209124358.137807-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The below compile time defined style make the code not so readable, the\nfirst function end block is after \"#endif\" segment.\n\n\t#if defined(XDP_UMEM_UNALIGNED_CHUNK_FLAG)\n\n\txdp_umem_configure()\n\t{\n\n\t#else\n\txdp_umem_configure()\n\t{\n\n\t#endif\n\t\t'shared code block'\n\t}\n\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/af_xdp/rte_eth_af_xdp.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c\nindex 1b6192fa44..802f912cb7 100644\n--- a/drivers/net/af_xdp/rte_eth_af_xdp.c\n+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c\n@@ -1078,6 +1078,12 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,\n \t\t__atomic_store_n(&umem->refcnt, 1, __ATOMIC_RELEASE);\n \t}\n \n+\treturn umem;\n+\n+err:\n+\txdp_umem_destroy(umem);\n+\treturn NULL;\n+}\n #else\n static struct\n xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,\n@@ -1138,13 +1144,13 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,\n \t}\n \tumem->mz = mz;\n \n-#endif\n \treturn umem;\n \n err:\n \txdp_umem_destroy(umem);\n \treturn NULL;\n }\n+#endif\n \n static int\n load_custom_xdp_prog(const char *prog_path, int if_index, struct bpf_map **map)\n", "prefixes": [ "v1" ] }