Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107812/?format=api
{ "id": 107812, "url": "http://patchwork.dpdk.org/api/patches/107812/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220218163443.3520756-2-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220218163443.3520756-2-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220218163443.3520756-2-pablo.de.lara.guarch@intel.com", "date": "2022-02-18T16:34:40", "name": "[1/4] crypto/ipsec_mb: check for missing operation types", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f09e0a4015aa4f24f76450d8124eab700f0e3b8d", "submitter": { "id": 9, "url": "http://patchwork.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220218163443.3520756-2-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 21739, "url": "http://patchwork.dpdk.org/api/series/21739/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21739", "date": "2022-02-18T16:34:39", "name": "ipsec_mb fixes for ZUC algorithm", "version": 1, "mbox": "http://patchwork.dpdk.org/series/21739/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/107812/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/107812/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F399FA0032;\n\tFri, 18 Feb 2022 17:34:57 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E21BE40E2D;\n\tFri, 18 Feb 2022 17:34:57 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 5DB3940E28;\n Fri, 18 Feb 2022 17:34:56 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Feb 2022 08:34:55 -0800", "from silpixa00400493.ir.intel.com ([10.237.213.136])\n by orsmga008.jf.intel.com with ESMTP; 18 Feb 2022 08:34:53 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1645202096; x=1676738096;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=/j17sG4D23+B4zPQiDj1DUH8r0DJGveA/cIAqkkmaTk=;\n b=liBS6s+IUNaGQhrA82JwNMOoMx2ZrY27FSc47C+k2duiAm+V0KJTMOId\n HY8EA0rqluPn0f63N6E/73NCrKEZetiXAaAfUyXFCbelEnjOBiLuM4Feg\n nx82uwl7PJEWDNvNCOKA0y6NdX5nvcM3X8n/FinTosSWrMGUZDXvnV35Q\n j8ijahQiT15huo39f6OIGDdGEMl/jqAnjJt/8JXsRJQS/rl9/ucDzJ4P8\n dYR0sk4kQmz56vofBF9/cCVZ8bVXpTLxCcve8B6xPSec4DiExInQlNRmq\n 9IZVeeBaly85FdymGOmzzVr2y23EWo3P5y1eK3vsowbsUU1zKYlBwCFws Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10261\"; a=\"275757267\"", "E=Sophos;i=\"5.88,379,1635231600\"; d=\"scan'208\";a=\"275757267\"", "E=Sophos;i=\"5.88,379,1635231600\"; d=\"scan'208\";a=\"546343807\"" ], "X-ExtLoop1": "1", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "roy.fan.zhang@intel.com", "Cc": "dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n piotrx.bronowski@intel.com, stable@dpdk.org", "Subject": "[PATCH 1/4] crypto/ipsec_mb: check for missing operation types", "Date": "Fri, 18 Feb 2022 16:34:40 +0000", "Message-Id": "<20220218163443.3520756-2-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220218163443.3520756-1-pablo.de.lara.guarch@intel.com>", "References": "<20220218163443.3520756-1-pablo.de.lara.guarch@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When processing crypto operations in ZUC PMD,\nthere were two operation types that were set at session level,\nbut not checked when the operations are enqueued and processed,\nleaving the buffers untouched silently.\n\nFixes: cde8df1bda9d (\"crypto/ipsec_mb: move zuc PMD\")\nCc: piotrx.bronowski@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n drivers/crypto/ipsec_mb/pmd_zuc.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/crypto/ipsec_mb/pmd_zuc.c b/drivers/crypto/ipsec_mb/pmd_zuc.c\nindex 2eae1d1ec7..ec83d96dfc 100644\n--- a/drivers/crypto/ipsec_mb/pmd_zuc.c\n+++ b/drivers/crypto/ipsec_mb/pmd_zuc.c\n@@ -198,7 +198,7 @@ process_ops(struct rte_crypto_op **ops, enum ipsec_mb_operation op_type,\n \t\tstruct ipsec_mb_qp *qp, uint8_t num_ops)\n {\n \tunsigned int i;\n-\tunsigned int processed_ops;\n+\tunsigned int processed_ops = 0;\n \n \tswitch (op_type) {\n \tcase IPSEC_MB_OP_ENCRYPT_ONLY:\n@@ -212,18 +212,21 @@ process_ops(struct rte_crypto_op **ops, enum ipsec_mb_operation op_type,\n \t\t\t\tnum_ops);\n \t\tbreak;\n \tcase IPSEC_MB_OP_ENCRYPT_THEN_HASH_GEN:\n+\tcase IPSEC_MB_OP_DECRYPT_THEN_HASH_VERIFY:\n \t\tprocessed_ops = process_zuc_cipher_op(qp, ops, sessions,\n \t\t\t\tnum_ops);\n \t\tprocess_zuc_hash_op(qp, ops, sessions, processed_ops);\n \t\tbreak;\n \tcase IPSEC_MB_OP_HASH_VERIFY_THEN_DECRYPT:\n+\tcase IPSEC_MB_OP_HASH_GEN_THEN_ENCRYPT:\n \t\tprocessed_ops = process_zuc_hash_op(qp, ops, sessions,\n \t\t\t\tnum_ops);\n \t\tprocess_zuc_cipher_op(qp, ops, sessions, processed_ops);\n \t\tbreak;\n \tdefault:\n \t\t/* Operation not supported. */\n-\t\tprocessed_ops = 0;\n+\t\tfor (i = 0; i < num_ops; i++)\n+\t\t\tops[i]->status = RTE_CRYPTO_OP_STATUS_INVALID_SESSION;\n \t}\n \n \tfor (i = 0; i < num_ops; i++) {\n", "prefixes": [ "1/4" ] }