Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/107814/?format=api
{ "id": 107814, "url": "http://patchwork.dpdk.org/api/patches/107814/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220218163443.3520756-4-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220218163443.3520756-4-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220218163443.3520756-4-pablo.de.lara.guarch@intel.com", "date": "2022-02-18T16:34:42", "name": "[3/4] crypto/ipsec_mb: fix crypto operation overwrite", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b79faa5a4aa26775a5b269abf3abcafe785af261", "submitter": { "id": 9, "url": "http://patchwork.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220218163443.3520756-4-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 21739, "url": "http://patchwork.dpdk.org/api/series/21739/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21739", "date": "2022-02-18T16:34:39", "name": "ipsec_mb fixes for ZUC algorithm", "version": 1, "mbox": "http://patchwork.dpdk.org/series/21739/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/107814/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/107814/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0F808A0032;\n\tFri, 18 Feb 2022 17:35:17 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 00A8441152;\n\tFri, 18 Feb 2022 17:35:17 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 9D4F440141;\n Fri, 18 Feb 2022 17:35:14 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Feb 2022 08:35:13 -0800", "from silpixa00400493.ir.intel.com ([10.237.213.136])\n by orsmga008.jf.intel.com with ESMTP; 18 Feb 2022 08:35:10 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1645202114; x=1676738114;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=EvJ41HASOG00fe/pQeYPIrYSbihg9Bx0GmmbmHUgIuo=;\n b=cUpU75yn6cTZybqSSRYNJ9NyLlWUoNT/yjV+dHpHadWZIb2zYNSDatBc\n Xmio07XJUTUxHM+/RQUj55f4Eqc/Y1H52nBDwAFMVL3OH6gZ3OqxXCsk3\n mPTF6EWElWtLRp+At8rEzOdqlufjFQtnrqhJYkZaTDGYXW3R2TREDHotk\n hT829gHS1O56GrEpHIy3D6FpVzElrGxshr0MJOaOWrOI1JrybICaCT6gB\n uU9BT6S/tR+IQw7djb5oXxLVTCK2XFWUV6jFA4H3OgaIUXZbvMBTTRk39\n v30A4/V6/QvcPVDniUK3fSEAI4FuV1coNpn8ff7ZLx/3snVTazgR+fPVI g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10261\"; a=\"314423629\"", "E=Sophos;i=\"5.88,379,1635231600\"; d=\"scan'208\";a=\"314423629\"", "E=Sophos;i=\"5.88,379,1635231600\"; d=\"scan'208\";a=\"546344117\"" ], "X-ExtLoop1": "1", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "roy.fan.zhang@intel.com", "Cc": "dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n stable@dpdk.org", "Subject": "[PATCH 3/4] crypto/ipsec_mb: fix crypto operation overwrite", "Date": "Fri, 18 Feb 2022 16:34:42 +0000", "Message-Id": "<20220218163443.3520756-4-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220218163443.3520756-1-pablo.de.lara.guarch@intel.com>", "References": "<20220218163443.3520756-1-pablo.de.lara.guarch@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "ZUC PMD batches crypto operations depending on their type\n(encryption + tag generation, tag verification + decryption, etc),\nto allow parallelization.\nThe array used to store the pointers to these operations was\nalways the same array provided by dequeue_burst() function,\nand it was looping around the same positions (from 0 to ZUC_MAX_BURST - 1).\n\nA new internal array is used to avoid overwriting the pointers\nof the array provided by dequeue_burst() function.\n\nFixes: cf7685d68f00 (\"crypto/zuc: add driver for ZUC library\")\nCc: pablo.de.lara.guarch@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n drivers/crypto/ipsec_mb/pmd_zuc.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/crypto/ipsec_mb/pmd_zuc.c b/drivers/crypto/ipsec_mb/pmd_zuc.c\nindex 07cf1462d2..e36c7092d6 100644\n--- a/drivers/crypto/ipsec_mb/pmd_zuc.c\n+++ b/drivers/crypto/ipsec_mb/pmd_zuc.c\n@@ -259,6 +259,7 @@ zuc_pmd_dequeue_burst(void *queue_pair,\n \n \tstruct zuc_session *curr_sess;\n \tstruct zuc_session *sessions[ZUC_MAX_BURST];\n+\tstruct rte_crypto_op *int_c_ops[ZUC_MAX_BURST];\n \tenum ipsec_mb_operation prev_zuc_op = IPSEC_MB_OP_NOT_SUPPORTED;\n \tenum ipsec_mb_operation curr_zuc_op;\n \tstruct ipsec_mb_qp *qp = queue_pair;\n@@ -290,11 +291,11 @@ zuc_pmd_dequeue_burst(void *queue_pair,\n \t\t */\n \t\tif (burst_size == 0) {\n \t\t\tprev_zuc_op = curr_zuc_op;\n-\t\t\tc_ops[0] = curr_c_op;\n+\t\t\tint_c_ops[0] = curr_c_op;\n \t\t\tsessions[0] = curr_sess;\n \t\t\tburst_size++;\n \t\t} else if (curr_zuc_op == prev_zuc_op) {\n-\t\t\tc_ops[burst_size] = curr_c_op;\n+\t\t\tint_c_ops[burst_size] = curr_c_op;\n \t\t\tsessions[burst_size] = curr_sess;\n \t\t\tburst_size++;\n \t\t\t/*\n@@ -302,7 +303,7 @@ zuc_pmd_dequeue_burst(void *queue_pair,\n \t\t\t * process them, and start a new batch.\n \t\t\t */\n \t\t\tif (burst_size == ZUC_MAX_BURST) {\n-\t\t\t\tprocessed_ops = process_ops(c_ops, curr_zuc_op,\n+\t\t\t\tprocessed_ops = process_ops(int_c_ops, curr_zuc_op,\n \t\t\t\t\t\tsessions, qp, burst_size);\n \t\t\t\tif (processed_ops < burst_size) {\n \t\t\t\t\tburst_size = 0;\n@@ -316,7 +317,7 @@ zuc_pmd_dequeue_burst(void *queue_pair,\n \t\t\t * Different operation type, process the ops\n \t\t\t * of the previous type.\n \t\t\t */\n-\t\t\tprocessed_ops = process_ops(c_ops, prev_zuc_op,\n+\t\t\tprocessed_ops = process_ops(int_c_ops, prev_zuc_op,\n \t\t\t\t\tsessions, qp, burst_size);\n \t\t\tif (processed_ops < burst_size) {\n \t\t\t\tburst_size = 0;\n@@ -326,7 +327,7 @@ zuc_pmd_dequeue_burst(void *queue_pair,\n \t\t\tburst_size = 0;\n \t\t\tprev_zuc_op = curr_zuc_op;\n \n-\t\t\tc_ops[0] = curr_c_op;\n+\t\t\tint_c_ops[0] = curr_c_op;\n \t\t\tsessions[0] = curr_sess;\n \t\t\tburst_size++;\n \t\t}\n@@ -334,7 +335,7 @@ zuc_pmd_dequeue_burst(void *queue_pair,\n \n \tif (burst_size != 0) {\n \t\t/* Process the crypto ops of the last operation type. */\n-\t\tprocessed_ops = process_ops(c_ops, prev_zuc_op,\n+\t\tprocessed_ops = process_ops(int_c_ops, prev_zuc_op,\n \t\t\t\tsessions, qp, burst_size);\n \t}\n \n", "prefixes": [ "3/4" ] }