Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/108121/?format=api
{ "id": 108121, "url": "http://patchwork.dpdk.org/api/patches/108121/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220223060931.2661907-1-honnappa.nagarahalli@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220223060931.2661907-1-honnappa.nagarahalli@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220223060931.2661907-1-honnappa.nagarahalli@arm.com", "date": "2022-02-23T06:09:30", "name": "[v3,1/2] examples/l3fwd: use single set of variables throughout the code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "de948a24659b19f3a7553bce6292ff0028104e83", "submitter": { "id": 1045, "url": "http://patchwork.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220223060931.2661907-1-honnappa.nagarahalli@arm.com/mbox/", "series": [ { "id": 21810, "url": "http://patchwork.dpdk.org/api/series/21810/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21810", "date": "2022-02-23T06:09:30", "name": "[v3,1/2] examples/l3fwd: use single set of variables throughout the code", "version": 3, "mbox": "http://patchwork.dpdk.org/series/21810/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/108121/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/108121/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 15050A034C;\n\tWed, 23 Feb 2022 07:09:49 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 898E940E5A;\n\tWed, 23 Feb 2022 07:09:48 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 4979A40DF6\n for <dev@dpdk.org>; Wed, 23 Feb 2022 07:09:47 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ACDD8106F;\n Tue, 22 Feb 2022 22:09:46 -0800 (PST)", "from 2p2660v4-1.austin.arm.com (2p2660v4-1.austin.arm.com\n [10.118.13.211])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A1A233F66F;\n Tue, 22 Feb 2022 22:09:46 -0800 (PST)" ], "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "To": "dev@dpdk.org, honnappa.nagarahalli@arm.com, lijuan.tu@intel.com,\n juraj.linkes@pantheon.tech, ohilyard@iol.unh.edu,\n david.marchand@redhat.com, thomas@monjalon.net, jerinj@marvell.com,\n bruce.richardson@intel.com, stephen@networkplumber.org, bluca@debian.org,\n ktraynor@redhat.com, christian.ehrhardt@canonical.com, xuemingl@nvidia.com", "Cc": "kathleen.capella@arm.com, nd@arm.com, Ruifeng Wang <ruifeng.wang@arm.com>", "Subject": "[PATCH v3 1/2] examples/l3fwd: use single set of variables throughout\n the code", "Date": "Wed, 23 Feb 2022 00:09:30 -0600", "Message-Id": "<20220223060931.2661907-1-honnappa.nagarahalli@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220202060403.118301-1-honnappa.nagarahalli@arm.com>", "References": "<20220202060403.118301-1-honnappa.nagarahalli@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "nb_rxd and nb_txd are used in polling mode and event mode of\noperation. nb_rxd and nb_txd are already global in polling mode\nbut are not visible to event mode code. Make them visible to all\nparts of the application.\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Kathleen Capella <kathleen.capella@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\nDTS test cases require changing the RX and TX queue depths.\nCurrently, this is achieved by patching the DPDK code. This patch set\nprovides a mechanism to configure the queue depths while launching\nthe application. With this change DTS test cases do not need\nto modify the DPDK code.\n\nv2 - Single parse function, additional validation on input (Stephen)\n\nv2 - Fixed typo (Ruifeng) and adjusted the commit msg (Kathleen).\n\n examples/l3fwd/l3fwd.h | 4 ++++\n examples/l3fwd/l3fwd_event.c | 2 --\n examples/l3fwd/main.c | 5 ++---\n 3 files changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h\nindex 38ca19133c..4ccdb28b4a 100644\n--- a/examples/l3fwd/l3fwd.h\n+++ b/examples/l3fwd/l3fwd.h\n@@ -81,6 +81,10 @@ struct lcore_conf {\n \n extern volatile bool force_quit;\n \n+/* RX and TX queue depths */\n+extern uint16_t nb_rxd;\n+extern uint16_t nb_txd;\n+\n /* ethernet addresses of ports */\n extern uint64_t dest_eth_addr[RTE_MAX_ETHPORTS];\n extern struct rte_ether_addr ports_eth_addr[RTE_MAX_ETHPORTS];\ndiff --git a/examples/l3fwd/l3fwd_event.c b/examples/l3fwd/l3fwd_event.c\nindex dd9eafa9b9..7a401290f8 100644\n--- a/examples/l3fwd/l3fwd_event.c\n+++ b/examples/l3fwd/l3fwd_event.c\n@@ -43,8 +43,6 @@ l3fwd_eth_dev_port_setup(struct rte_eth_conf *port_conf)\n {\n \tstruct l3fwd_event_resources *evt_rsrc = l3fwd_get_eventdev_rsrc();\n \tuint16_t nb_ports = rte_eth_dev_count_avail();\n-\tuint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT;\n-\tuint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT;\n \tunsigned int nb_lcores = rte_lcore_count();\n \tstruct rte_eth_conf local_port_conf;\n \tstruct rte_eth_dev_info dev_info;\ndiff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c\nindex eb68ffc5aa..acd186ab7d 100644\n--- a/examples/l3fwd/main.c\n+++ b/examples/l3fwd/main.c\n@@ -53,9 +53,8 @@\n \n #define MAX_LCORE_PARAMS 1024\n \n-/* Static global variables used within this file. */\n-static uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT;\n-static uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT;\n+uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT;\n+uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT;\n \n /**< Ports set in promiscuous mode off by default. */\n static int promiscuous_on;\n", "prefixes": [ "v3", "1/2" ] }