Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 108718,
    "url": "http://patchwork.dpdk.org/api/patches/108718/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dts/patch/20220315041613.1552-1-junx.dong@intel.com/",
    "project": {
        "id": 3,
        "url": "http://patchwork.dpdk.org/api/projects/3/?format=api",
        "name": "DTS",
        "link_name": "dts",
        "list_id": "dts.dpdk.org",
        "list_email": "dts@dpdk.org",
        "web_url": "",
        "scm_url": "git://dpdk.org/tools/dts",
        "webscm_url": "http://git.dpdk.org/tools/dts/",
        "list_archive_url": "https://inbox.dpdk.org/dts",
        "list_archive_url_format": "https://inbox.dpdk.org/dts/{}",
        "commit_url_format": ""
    },
    "msgid": "<20220315041613.1552-1-junx.dong@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dts/20220315041613.1552-1-junx.dong@intel.com",
    "date": "2022-03-15T04:16:13",
    "name": "[V1] framework/*: Fixed some issues of new create eal parameter API",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "aa53466d497e785401d717cc959bfa83cf02f17f",
    "submitter": {
        "id": 2237,
        "url": "http://patchwork.dpdk.org/api/people/2237/?format=api",
        "name": "Jun Dong",
        "email": "junx.dong@intel.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dts/patch/20220315041613.1552-1-junx.dong@intel.com/mbox/",
    "series": [
        {
            "id": 22147,
            "url": "http://patchwork.dpdk.org/api/series/22147/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dts/list/?series=22147",
            "date": "2022-03-15T04:16:13",
            "name": "[V1] framework/*: Fixed some issues of new create eal parameter API",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/22147/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/108718/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/108718/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dts-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0FC5CA00BE;\n\tTue, 15 Mar 2022 05:16:24 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D074E40395;\n\tTue, 15 Mar 2022 05:16:23 +0100 (CET)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id B896A4014F\n for <dts@dpdk.org>; Tue, 15 Mar 2022 05:16:21 +0100 (CET)",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Mar 2022 21:16:20 -0700",
            "from shwdenpg197.ccr.corp.intel.com ([10.253.109.70])\n by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Mar 2022 21:16:19 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1647317781; x=1678853781;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=Ck2+iO71heY8uwgQjHWLQBkSAwiRvfED2tRTH5kKB8s=;\n b=Jc9OOxWN+0wTaGlAm4VJPT4kpIlxJS7j4dLIeQbqYMLV/9SFvk6pKaLl\n PR4WYsbRssypxCuc51wqEwp3hPnGOobMaypzIa+K6iTOC/KVX1+fD0D5Z\n VQXO63qOiby5Tgss0lpcxo9PDN8gCed/nZlqHoXSammlHNYya9E290Tzj\n Q28tCV9WtA9nKAChBo0PzLt6xlycz7KL/HmHyNCUQQsqcnoQRzCKgl5D+\n EnA6bbWoPrcXrilOksAzQ2PlyTCpVSigRenlp4vZrwqI/e0dB2tTjLhpv\n KCwqdO3fF8no+7m2DmeP4X5lo08us/M1mXUEvtZrfirVI+ca7kd65Gghg g==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6200,9189,10286\"; a=\"342634705\"",
            "E=Sophos;i=\"5.90,182,1643702400\"; d=\"scan'208\";a=\"342634705\"",
            "E=Sophos;i=\"5.90,182,1643702400\"; d=\"scan'208\";a=\"782929000\""
        ],
        "From": "Jun Dong <junx.dong@intel.com>",
        "To": "dts@dpdk.org",
        "Cc": "lijuan.tu@intel.com,\n\tqingx.sun@intel.com,\n\tjunx.dong@intel.com",
        "Subject": "[dts] [V1] framework/*: Fixed some issues of new create eal parameter\n API",
        "Date": "Tue, 15 Mar 2022 12:16:13 +0800",
        "Message-Id": "<20220315041613.1552-1-junx.dong@intel.com>",
        "X-Mailer": "git-send-email 2.33.1.windows.1",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dts@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "test suite reviews and discussions <dts.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dts/>",
        "List-Post": "<mailto:dts@dpdk.org>",
        "List-Help": "<mailto:dts-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dts-bounces@dpdk.org"
    },
    "content": "- Remove blank from cores list\n- Change validate rule of port to compatible with FreeBSD\n- Modify file prefix generate rule to compatible with FreeBSD\n- Restore ParameterInvalidException's define since some API have used it\n\nSigned-off-by: Jun Dong <junx.dong@intel.com>\n---\n framework/dut.py       | 22 ++++++++++++++++------\n framework/exception.py |  7 +------\n 2 files changed, 17 insertions(+), 12 deletions(-)",
    "diff": "diff --git a/framework/dut.py b/framework/dut.py\nindex 7b3535c7..dfd85c81 100644\n--- a/framework/dut.py\n+++ b/framework/dut.py\n@@ -1364,6 +1364,10 @@ class _EalParameter(object):\n         self.vdevs = vdevs\n         self.other_eal_param = other_eal_param\n \n+    _param_validate_exception_info_template = (\n+        'Invalid parameter of %s about value of %s, Please reference API doc.'\n+    )\n+\n     @staticmethod\n     def _validate_cores(cores: Union[str, List[int], List[str]]):\n         core_string_match = r\"default|all|\\d+S/\\d+C/\\d+T|$\"\n@@ -1386,18 +1390,22 @@ class _EalParameter(object):\n                 or all(map(lambda _port: type(_port) == str, ports))\n                 and all(\n             map(\n-                lambda _port: re.match(r\"^([\\d\\w]+:){2}[\\d\\w]+\\.[\\d\\w]+$\", _port),\n+                lambda _port: re.match(r\"^([\\d\\w]+:){1,2}[\\d\\w]+\\.[\\d\\w]+$\", _port),\n                 ports,\n             )\n         )\n         ):\n-            raise ParameterInvalidException(\"ports\", ports)\n+            raise ParameterInvalidException(\n+                _EalParameter._param_validate_exception_info_template % ('ports', ports)\n+            )\n         return ports\n \n     @staticmethod\n     def _validate_port_options(port_options: Dict[Union[str, int], str]):\n         if not isinstance(port_options, Dict):\n-            raise ParameterInvalidException(\"port_options\", port_options)\n+            raise ParameterInvalidException(\n+                _EalParameter._param_validate_exception_info_template % ('port_options', port_options)\n+            )\n         port_list = port_options.keys()\n         _EalParameter._validate_ports(list(port_list))\n         return port_options\n@@ -1405,7 +1413,9 @@ class _EalParameter(object):\n     @staticmethod\n     def _validate_vdev(vdev: List[str]):\n         if not isinstance(vdev, list):\n-            raise ParameterInvalidException(\"vdev\", vdev)\n+            raise ParameterInvalidException(\n+                _EalParameter._param_validate_exception_info_template % ('vdev', vdev)\n+            )\n \n     def _make_cores_param(self) -> str:\n         is_use_default_cores = (\n@@ -1446,7 +1456,7 @@ class _EalParameter(object):\n                 )\n             return _formated_core_list\n \n-        return f'-l {\", \".join(_get_consecutive_cores_range(core_list))}'\n+        return f'-l {\",\".join(_get_consecutive_cores_range(core_list))}'\n \n     def _make_memory_channels(self) -> str:\n         param_template = \"-n {}\"\n@@ -1499,7 +1509,6 @@ class _EalParameter(object):\n             if not self.fixed_prefix:\n                 fixed_file_prefix = fixed_file_prefix + \"_\" + self.dut.prefix_subfix\n         fixed_file_prefix = self._do_os_handle_with_prefix_param(fixed_file_prefix)\n-        fixed_file_prefix = \"--file-prefix=\" + fixed_file_prefix\n         return fixed_file_prefix\n \n     def _make_vdevs_param(self) -> str:\n@@ -1570,6 +1579,7 @@ class _EalParameter(object):\n             file_prefix = \"\"\n         else:\n             self.dut.prefix_list.append(file_prefix)\n+            file_prefix = \"--file-prefix=\" + file_prefix\n         return file_prefix\n \n     def make_eal_param(self) -> str:\ndiff --git a/framework/exception.py b/framework/exception.py\nindex 2554c1d8..c3900cb6 100644\n--- a/framework/exception.py\n+++ b/framework/exception.py\n@@ -77,12 +77,7 @@ class SSHSessionDeadException(Exception):\n \n \n class ParameterInvalidException(Exception):\n-    def __init__(self, param_name: str, param_value: Any):\n-        self.param_name = param_name\n-        self.param_value = param_value\n-\n-    def __str__(self) -> str:\n-        return f'Invalid parameter of {self.param_name} about value of {self.param_value}, Please reference API doc.'\n+    pass\n \n \n class StartVMFailedException(Exception):\n",
    "prefixes": [
        "V1"
    ]
}