Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/110063/?format=api
http://patchwork.dpdk.org/api/patches/110063/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220422035100.3180870-5-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220422035100.3180870-5-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220422035100.3180870-5-g.singh@nxp.com", "date": "2022-04-22T03:50:51", "name": "[05/14] crypto/dpaa_sec: physically enable QI", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1a2e0d1352b5eca75d23c610a4367105dfa14b45", "submitter": { "id": 1068, "url": "http://patchwork.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220422035100.3180870-5-g.singh@nxp.com/mbox/", "series": [ { "id": 22607, "url": "http://patchwork.dpdk.org/api/series/22607/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=22607", "date": "2022-04-22T03:50:47", "name": "[01/14] crypto/dpaa2_sec: fix fle buffer leak", "version": 1, "mbox": "http://patchwork.dpdk.org/series/22607/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/110063/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/110063/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 79155A0093;\n\tFri, 22 Apr 2022 05:52:06 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A6551427FE;\n\tFri, 22 Apr 2022 05:51:44 +0200 (CEST)", "from EUR02-VE1-obe.outbound.protection.outlook.com\n (mail-eopbgr20041.outbound.protection.outlook.com [40.107.2.41])\n by mails.dpdk.org (Postfix) with ESMTP id 2C54142806\n for <dev@dpdk.org>; Fri, 22 Apr 2022 05:51:43 +0200 (CEST)", "from AS8PR04MB8198.eurprd04.prod.outlook.com (2603:10a6:20b:3b0::14)\n by DB7PR04MB4393.eurprd04.prod.outlook.com (2603:10a6:5:32::21) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 22 Apr\n 2022 03:51:42 +0000", "from AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::8cf1:93b:c340:3be2]) by AS8PR04MB8198.eurprd04.prod.outlook.com\n ([fe80::8cf1:93b:c340:3be2%7]) with mapi id 15.20.5186.015; Fri, 22 Apr 2022\n 03:51:42 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=JBinw2uyNSzpmIQlEjjXklQ1z6OEBqstie+LrnJEbyVv+POjbDbAnaFJygCyo89fXIAKTvdUk/Ybv2pLKZvOfWDhiYm6+CDhiKmWAWr93hJ83d0X0oT/3UlMT21S8JgfmjK+cvdKcXQYYJObOSjymapOCs+cPEcowRWRH3YMFPDSTzEhbjSh2uu4WXKee4NxXNWCyB2FgiUZVK94JJEfz5yRp6u490vk5J39efGHy0468r+MFLf64qPD4+hFburLG11SyqksPbEiAJ9XbbhjHjNYuIiHrmwrWSWkYaV6VOpXvacLYeLYmKArHah4Q3MvhY1E/G8Yez1jDQyGKkJvjA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=72FAFAZov6BXALbzDsSvvgzjDwKgM8BwVgmSD12zo/w=;\n b=TFpSnn0IlGTMd/lYMbcbjLd2XfpBnh9HfAa6K/GcK7iQwxuWIYhbSnFoPmMBdZC97NI2tlFEgBEFmMWC1BeEi7z412AifsoFpesHRUgkSSueukbwc/YTG3dWl0fJGXyQxBpFO5xU/Fkkbn45SjqyR4SKhhCxxvNDm6KVKiglgDZc/FzwBorMbcIXyIr5GQeI1GVMqHMQ9ONssnTp8O7nzxiY/E1s+lGE5y/lQ9Wd2Hfn6zMxquFKtww2WcXlyMbci/ZJDOo9dydkiQbNPmVPwL0t0a8FFDFtISmVyRgLKoRsTAfB26WOhOsrFbVApdiEk/1r4yq/rhFKFe6TqCpD4g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass\n header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=72FAFAZov6BXALbzDsSvvgzjDwKgM8BwVgmSD12zo/w=;\n b=sBbb//k5zSJbp+lf6k1txKFU2gtqsRZs7Vn7M/q78ODdqR5KCekWS8+bLKmS0tDAP9M7KM8BQjwl2y79CLxDk0/mVeGYNrVm57u/fibLzIkUtn8JSaNsWWYpQOlyIu8l4n4UmiatcNqFsRop1L4k0xkdOUVhAhpTXNGngJXt2AY=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nxp.com;", "From": "Gagandeep Singh <g.singh@nxp.com>", "To": "gakhil@marvell.com,\n\tdev@dpdk.org", "Cc": "Gagandeep Singh <g.singh@nxp.com>", "Subject": "[PATCH 05/14] crypto/dpaa_sec: physically enable QI", "Date": "Fri, 22 Apr 2022 09:20:51 +0530", "Message-Id": "<20220422035100.3180870-5-g.singh@nxp.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220422035100.3180870-1-g.singh@nxp.com>", "References": "<20220422035100.3180870-1-g.singh@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SG2PR03CA0127.apcprd03.prod.outlook.com\n (2603:1096:4:91::31) To AS8PR04MB8198.eurprd04.prod.outlook.com\n (2603:10a6:20b:3b0::14)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "e5db4187-7064-4dfe-88c3-08da24136976", "X-MS-TrafficTypeDiagnostic": "DB7PR04MB4393:EE_", "X-Microsoft-Antispam-PRVS": "\n <DB7PR04MB4393BF77412C12A912273C66E1F79@DB7PR04MB4393.eurprd04.prod.outlook.com>", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n vNqeh7PxDNqYCqnYjmASlA1e8eGeSZmISAAoIOGp4XZVQZ8DDnioBQrApn2wnFWqOEVuzSzh+XOTpXe47OLwIlf7B8Ht7XECrUpgd9jYf9oa+CNF/KFcL5EtHRHSkyE2Mxa7JqQ9vGv7HvmJLCQykpaRhB9TpdLFIEegLhkLW0uZaH8zznWBBQYCV2caikSzMv7vzSRcnL0Ps0kgMRbLr8PhP1Hf5W+gA7Udlo8FqYnyu7IT4SJkDW73XPsioijQPddAz5aRT+HPb6bZ+k7bpjUI3hwuS6gKqajXQp8A1GAe4UsFAxqcUjeNPQ7SZ1WH7tnsj28AP7PTUmQCOB+lipQUysxHiqPEq683OGzVQCrxlRPJGxPsdKqtg4CX9RMfj3eqasiyjJfXUXDgX9bquZ5tefn33VhuHzUiFuxZsBCI6dvtW+eWjfSVMu4twcU/6J0xVEbSQVxAAaA5g2J5qzfbH84p4REDMf3Y8ue+k80W8VY+ea/encFpo2iimiH/uET8w7fBi929wb+k5ebdwjMiMO2fehjPEPTIgYdjUGXQ6lVQBvVma6q1fxUmVPzEjEAtKwGBWxmldtet7dmZLbcnChnwb2npP+BlfNjQgKQVkXKaxgk+wV9V29kocZKj5SMcbmZrL6C3IOfmKml6BVbwcekivxF4Xr1ih4cED0vp1iKXUof1TEEQz3QuKcylS0khO7nT9lN3NJWNAFRn0g==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS8PR04MB8198.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230001)(4636009)(366004)(5660300002)(36756003)(2616005)(6486002)(1076003)(8936002)(86362001)(316002)(52116002)(66946007)(26005)(6506007)(6512007)(186003)(66556008)(6666004)(66476007)(83380400001)(38350700002)(38100700002)(508600001)(4326008)(55236004)(2906002)(8676002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n vrCRad8b4LcsYYjIQj0UmypLN3Tvhx/dvmaYvYus4I5wfkaxmfF2gWFRdtWQlB95rPLlyvsHHwiX4b9+siBJsHZT1lUCrJqvqZyps5//S7ZkwTjq3QGIIOMOD1wXYZiQTOGNDl1MeeORXidCJ1tf9J1PVz8cRA+ANoNSbY+oHrUiHzLdNewzOrSifiPqY8DUy3szr9zsOZQDsr6WEaQQ++AzmTxx5md9WYvI/M/cdwgElbZ/it/EYWeCjhs/9BBUH4k34cQaf6zWWjabI7gQSSarAvemCzKjWRYYX2mvh6ook9vXIULBPez2De0R8Ys2PjhTyEcBwVJUSYJ6OWczIxKhxVJt4c+mSngE9n2jhg6Iuw5UjPrODHqjK7/4gIWNpPz2y1TNclGDDtTLMe+ZzkC+PCP0EbVPs+2E4ede3+u+4rZUWK5rnIFb3p76S5Dem1QPchHP4KcjPSKNqcjU6ANvHCkvJCPtMDARyAiUmaAr0o/lk/EtO3CW32Xut4iXtvPtvIcs2bU+s18MKcwRs/iZ38OQr5e1c9ABLpJHKL9z8yXLPFMAPjQXRIG8+BHK3L0UTX+g/gfS/MMGLBUDjUqKYd6sb9ps8A3huB1gN0O2XP3loqgBK95EOoChIZRk951F/zlgj6Lw0LzOdXaUu3rCIm9CbGjudohX8FPs0MtgF0WdPgay5cFaaxfaCqG+i7Q+uRPbeHz/Lj+hdQ+ZupGa3yJBkDhGcs5PBIUNZFtYhmZ6QnaUuljM/UibU8nc2OHS5LUIndd+a7+6lCTwea8sPhio9S+HLKPf1jskgYW498PWbSn4Ufhcka+eGIq4c47cevHQKSy64ydgSMXvroWnYsKap8VW4nwXExjgu08zm8q5fbSDSvf2UrMMetNoZCLWJi1taG8JR+9Pdls0fJJ4V+8CzVhm8ZFppMzIE0J6FkxaE2br7jmvv9kWoiV9OcTBgpMUkkkWXwyBiWJbdRGn9y0bj5c1MGhL12gx45vbtwfCALdMZn0Bk93gWQaS3qlK5CvndgoBUprvnF0UOo7C8Q6axZq7qn5mJ0w0qt+VH3VhRPLw7Uyvwh5H/RFXBCt5wLBZA3WPkuqAXkswaGk/xim8BQdTrXPkWNlbZSICH8/Iu4uaOA127LbhCUX886CTlBImwyO3hCfJknJA1Aen3I1XWPiJptRGljRz2BVGEHU2g5A/0ZAJLFSXjZ1pHR40/84pjc7hEG8V191Oq2Pi32nMlkGMmqvDA2KGDApbbdURJAGKVTfjfXojRANYcqnVUrA78nH2NhUdy0dHKEcyzbc5fLloBkypgKHlDRB1uu/r1crbwfqOu5jqs4z2TaQ4FOkoHf/cihw9r8Z+hXAsZuXm3b4faarlb0xd/6knEQU3npW+h/14mspesSubXIILjQ2OmSM6Kw3BlEh5BkNhnbFHfsehYoozmGqpe1wbxnVtmdvXxS9Gyi71phdx/Skw3UrWA1A+K8qAQpfaFkeyIPy2cvgYwzRLtXyGVCs8oA4piOstgddlNYLPhKl8ikXQuojta2o0Y/sydvJ8MbHaBOTsgMLEe1EVPF41bQAa8cJUb96N4Lyg9007It6G3fB9Zv83jbbN6/wwkX20sZVfdYsFEEtn59SG5HSDNEhBm5AUuhGu+I0gvhbFo8ZXmUnSqpGc6OAjgHpgqFIFQfwLBfWUUUN9ci6J77IeZd2dcSaYKkEISXboWDnS96if3871K9JL3xhdn3cD1Ti5+w==", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n e5db4187-7064-4dfe-88c3-08da24136976", "X-MS-Exchange-CrossTenant-AuthSource": "AS8PR04MB8198.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "22 Apr 2022 03:51:42.1044 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n 2/OtzBDOQlG+J6OYJGQQotR7gqkKxGZIab2D+BZ6jPJLHp3vjRTIIBn/DB87jX7r", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB7PR04MB4393", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "To perform crypto operations on DPAA platform,\nQI interface of HW must be enabled.\nEarlier DPAA crypto driver was dependent on\nkernel for QI enable. Now with this patch\nthere is no such dependency on kernel.\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n drivers/crypto/dpaa_sec/dpaa_sec.c | 30 ++++++++++++++++++++++++++++--\n drivers/crypto/dpaa_sec/dpaa_sec.h | 6 ++++++\n 2 files changed, 34 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c\nindex ed12d6663b..23a94d7e41 100644\n--- a/drivers/crypto/dpaa_sec/dpaa_sec.c\n+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c\n@@ -1,7 +1,7 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n *\n * Copyright (c) 2016 Freescale Semiconductor, Inc. All rights reserved.\n- * Copyright 2017-2021 NXP\n+ * Copyright 2017-2022 NXP\n *\n */\n \n@@ -20,6 +20,7 @@\n #endif\n #include <rte_cycles.h>\n #include <rte_dev.h>\n+#include <rte_io.h>\n #include <rte_ip.h>\n #include <rte_kvargs.h>\n #include <rte_malloc.h>\n@@ -3654,9 +3655,35 @@ dpaa_sec_dev_init(struct rte_cryptodev *cryptodev)\n \tstruct dpaa_sec_qp *qp;\n \tuint32_t i, flags;\n \tint ret;\n+\tvoid *cmd_map;\n+\tint map_fd = -1;\n \n \tPMD_INIT_FUNC_TRACE();\n \n+\tinternals = cryptodev->data->dev_private;\n+\tmap_fd = open(\"/dev/mem\", O_RDWR);\n+\tif (unlikely(map_fd < 0)) {\n+\t\tDPAA_SEC_ERR(\"Unable to open (/dev/mem)\");\n+\t\treturn map_fd;\n+\t}\n+\tinternals->sec_hw = mmap(NULL, MAP_SIZE, PROT_READ | PROT_WRITE,\n+\t\t\t MAP_SHARED, map_fd, SEC_BASE_ADDR);\n+\tif (internals->sec_hw == MAP_FAILED) {\n+\t\tDPAA_SEC_ERR(\"Memory map failed\");\n+\t\tclose(map_fd);\n+\t\treturn -EINVAL;\n+\t}\n+\tcmd_map = (uint8_t *)internals->sec_hw +\n+\t\t (BLOCK_OFFSET * QI_BLOCK_NUMBER) + CMD_REG;\n+\tif (!(be32_to_cpu(rte_read32(cmd_map)) & QICTL_DQEN))\n+\t\t/* enable QI interface */\n+\t\trte_write32(cpu_to_be32(QICTL_DQEN), cmd_map);\n+\n+\tret = munmap(internals->sec_hw, MAP_SIZE);\n+\tif (ret)\n+\t\tDPAA_SEC_WARN(\"munmap failed\\n\");\n+\n+\tclose(map_fd);\n \tcryptodev->driver_id = dpaa_cryptodev_driver_id;\n \tcryptodev->dev_ops = &crypto_ops;\n \n@@ -3673,7 +3700,6 @@ dpaa_sec_dev_init(struct rte_cryptodev *cryptodev)\n \t\t\tRTE_CRYPTODEV_FF_OOP_LB_IN_SGL_OUT |\n \t\t\tRTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT;\n \n-\tinternals = cryptodev->data->dev_private;\n \tinternals->max_nb_queue_pairs = RTE_DPAA_MAX_NB_SEC_QPS;\n \tinternals->max_nb_sessions = RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS;\n \ndiff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers/crypto/dpaa_sec/dpaa_sec.h\nindex b3f2258ead..8921e3ed89 100644\n--- a/drivers/crypto/dpaa_sec/dpaa_sec.h\n+++ b/drivers/crypto/dpaa_sec/dpaa_sec.h\n@@ -10,6 +10,12 @@\n #define CRYPTODEV_NAME_DPAA_SEC_PMD\tcrypto_dpaa_sec\n /**< NXP DPAA - SEC PMD device name */\n \n+#define SEC_BASE_ADDR\t\t0x1700000\n+#define MAP_SIZE\t\t0x100000\n+#define BLOCK_OFFSET\t\t0x10000\n+#define CMD_REG\t\t\t0x4\n+#define QICTL_DQEN\t\t0x01\n+#define QI_BLOCK_NUMBER\t\t7\n #define MAX_DPAA_CORES\t\t4\n #define NUM_POOL_CHANNELS\t4\n #define DPAA_SEC_BURST\t\t7\n", "prefixes": [ "05/14" ] }{ "id": 110063, "url": "