Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/110364/?format=api
{ "id": 110364, "url": "http://patchwork.dpdk.org/api/patches/110364/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220427145821.5987-13-kalesh-anakkur.purayil@broadcom.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220427145821.5987-13-kalesh-anakkur.purayil@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220427145821.5987-13-kalesh-anakkur.purayil@broadcom.com", "date": "2022-04-27T14:58:16", "name": "[12/17] net/bnxt: fix setting autoneg speed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e1e5a651794f79c4c1c196e14a3041fed582dcf5", "submitter": { "id": 1479, "url": "http://patchwork.dpdk.org/api/people/1479/?format=api", "name": "Kalesh A P", "email": "kalesh-anakkur.purayil@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patchwork.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220427145821.5987-13-kalesh-anakkur.purayil@broadcom.com/mbox/", "series": [ { "id": 22696, "url": "http://patchwork.dpdk.org/api/series/22696/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=22696", "date": "2022-04-27T14:58:04", "name": "bnxt PMD fixes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/22696/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/110364/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/110364/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D9FBEA034C;\n\tWed, 27 Apr 2022 17:00:00 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4BF9542834;\n\tWed, 27 Apr 2022 16:58:49 +0200 (CEST)", "from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.166.231])\n by mails.dpdk.org (Postfix) with ESMTP id BF1A742831\n for <dev@dpdk.org>; Wed, 27 Apr 2022 16:58:46 +0200 (CEST)", "from dhcp-10-123-153-22.dhcp.broadcom.net\n (bgccx-dev-host-lnx2.bec.broadcom.net [10.123.153.22])\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTP id 57130C0000E8;\n Wed, 27 Apr 2022 07:58:45 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 57130C0000E8", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1651071526;\n bh=cXVyRRJ4u3nOv6vWjdchCmJOVbhb0yjfO+A9sYBJ/hc=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=oLdPvbWlLqk+9fCF88qdVbjkchuI2Mj/iOQPyt5WXfePPQ4sSman353j9G9Hb7bIu\n 1caJ6lK1RJikVDMJesUfC/7Z6yeh/Syx169wQiKhZ/utiXyQMiMBLS11Rbn3XqZeAd\n oHYUOQ18MifbjeNNrp9UmfiEOH2kSQOYWGaKikSQ=", "From": "Kalesh A P <kalesh-anakkur.purayil@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ajit.khaparde@broadcom.com", "Subject": "[PATCH 12/17] net/bnxt: fix setting autoneg speed", "Date": "Wed, 27 Apr 2022 20:28:16 +0530", "Message-Id": "<20220427145821.5987-13-kalesh-anakkur.purayil@broadcom.com>", "X-Mailer": "git-send-email 2.10.1", "In-Reply-To": "<20220427145821.5987-1-kalesh-anakkur.purayil@broadcom.com>", "References": "<20220427145821.5987-1-kalesh-anakkur.purayil@broadcom.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n\nThe \"active_fec_signal_mode\" in HWRM_PORT_PHY_QCFG response\ndoes not return correct value till the link is up. Driver cannot\nrely on active_fec_signal_mode while setting autoneg speed.\n\nWhile setting autoneg speed, driver is currently checking only\n\"auto_link_speed_mask\". Fixed to check \"auto_pam4_link_speed_mask\"\nas well. Also, while setting auto mode and setting speed mask,\ndriver will have to set both NRZ and PAM4 mask.\n\nFixes: c23f9ded0391 (\"net/bnxt: support 200G PAM4 link\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\n---\n drivers/net/bnxt/bnxt_hwrm.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c\nindex d87f0c3..9eb8b8d 100644\n--- a/drivers/net/bnxt/bnxt_hwrm.c\n+++ b/drivers/net/bnxt/bnxt_hwrm.c\n@@ -1424,17 +1424,17 @@ static int bnxt_hwrm_port_phy_cfg(struct bnxt *bp, struct bnxt_link_info *conf)\n \t\t\t}\n \t\t}\n \t\t/* AutoNeg - Advertise speeds specified. */\n-\t\tif (conf->auto_link_speed_mask &&\n+\t\tif ((conf->auto_link_speed_mask || conf->auto_pam4_link_speed_mask) &&\n \t\t !(conf->phy_flags & HWRM_PORT_PHY_CFG_INPUT_FLAGS_FORCE)) {\n \t\t\treq.auto_mode =\n \t\t\t\tHWRM_PORT_PHY_CFG_INPUT_AUTO_MODE_SPEED_MASK;\n-\t\t\tif (conf->auto_pam4_link_speed_mask &&\n-\t\t\t bp->link_info->link_signal_mode) {\n+\t\t\tif (conf->auto_pam4_link_speed_mask) {\n \t\t\t\tenables |=\n \t\t\t\tHWRM_PORT_PHY_CFG_IN_EN_AUTO_PAM4_LINK_SPD_MASK;\n \t\t\t\treq.auto_link_pam4_speed_mask =\n \t\t\t\trte_cpu_to_le_16(conf->auto_pam4_link_speed_mask);\n-\t\t\t} else {\n+\t\t\t}\n+\t\t\tif (conf->auto_link_speed_mask) {\n \t\t\t\tenables |=\n \t\t\t\tHWRM_PORT_PHY_CFG_IN_EN_AUTO_LINK_SPEED_MASK;\n \t\t\t\treq.auto_link_speed_mask =\n", "prefixes": [ "12/17" ] }