Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/110748/?format=api
{ "id": 110748, "url": "http://patchwork.dpdk.org/api/patches/110748/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220505173003.3242618-10-kda@semihalf.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220505173003.3242618-10-kda@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220505173003.3242618-10-kda@semihalf.com", "date": "2022-05-05T17:30:01", "name": "[09/11] test/ring: disable problematic tests for RISC-V", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6630f5dd2a90860bd98b2836e9f0e93d0b86f70f", "submitter": { "id": 2179, "url": "http://patchwork.dpdk.org/api/people/2179/?format=api", "name": "Stanislaw Kardach", "email": "kda@semihalf.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220505173003.3242618-10-kda@semihalf.com/mbox/", "series": [ { "id": 22800, "url": "http://patchwork.dpdk.org/api/series/22800/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=22800", "date": "2022-05-05T17:29:52", "name": "Introduce support for RISC-V architecture", "version": 1, "mbox": "http://patchwork.dpdk.org/series/22800/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/110748/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/110748/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4D995A00C2;\n\tThu, 5 May 2022 19:31:28 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C7D0842855;\n\tThu, 5 May 2022 19:30:37 +0200 (CEST)", "from mail-lf1-f51.google.com (mail-lf1-f51.google.com\n [209.85.167.51]) by mails.dpdk.org (Postfix) with ESMTP id 1DF2C42849\n for <dev@dpdk.org>; Thu, 5 May 2022 19:30:35 +0200 (CEST)", "by mail-lf1-f51.google.com with SMTP id w1so8627905lfa.4\n for <dev@dpdk.org>; Thu, 05 May 2022 10:30:35 -0700 (PDT)", "from localhost.localdomain (89-73-146-138.dynamic.chello.pl.\n [89.73.146.138]) by smtp.gmail.com with ESMTPSA id\n z26-20020ac25dfa000000b0047255d21203sm289640lfq.306.2022.05.05.10.30.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 05 May 2022 10:30:34 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=mPv2df3GWGEGSeivbo+U202bk5gf7E+r+1iOsSwMG1E=;\n b=NaAC8aJCvYdn76egG+1SwB3/0ccqfBdf+Qp/IqFtkfIb7L/tStzA6H08jX3KrcYgwv\n LyYGVXK1ft3NiTbl2wMs2hjc3knuEe3248cbIouEMY4tFqvPJ2nRhcikwoV4ZN8JzIIH\n T35buqUOv6MYdjh+8YV6vij+DRVkf7aFZqg3QNSujOmhrtOWooTwEZzNR7h9GV9mESsm\n +0KrBvlX/4OxYFNj5MBSiK2DC5qx+whnNwlYI9VDdjYdBiao4j8GMBpDWOi+8BiTtq07\n fPgr9d+C8ejUWb+8OHjWlB/QEj7IA3lGXwYKJ3t/xSCGpIlbsWhYZWTuHjXftRchVzdb\n CHuA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=mPv2df3GWGEGSeivbo+U202bk5gf7E+r+1iOsSwMG1E=;\n b=Y4ODmlJ5QqdYwmRn734iIW1LX1U6R/+d3EteEO3/oCSyTRPdRY2mFS4vdCdGO9tkW5\n WkPjC9BPp/q2hmJnqGkREdIeOUnIQ8VD2MfvbWCbYRsGBKi+U717la06FXNZrM18B8FS\n DFAVnBkFDAdjtjveTa9Me5THUmESWkCMB+PPtFrI/K3/qxWxk7dMLg2b3EVF4gqS6VBf\n TK8Y8dBZSrubVpxvAlu2BcbBqrd8DEERQGp5DIR1iEoh34R9ZGO8K0o5cHMRINn9jt0J\n agajm5sJHqKHPw/t6ia2dD1aCiOoeIrljcnAmVJ6bjaI9PDKPvQV9YDvBYXHd68Vgimf\n /GhQ==", "X-Gm-Message-State": "AOAM533REHfE1xD4Rb5mkS6LhACJ8hORW2qPmh+CdxYrxhk8rAT/3RXr\n S9L8aDoRb17xwQd6cyJPEhGNsA==", "X-Google-Smtp-Source": "\n ABdhPJzqCods3oHKBvZTRYu6L0W47mxY2qcQq7gZ7/B5T0XyA/931Ag8t0SNvmda1PxUFwgC6m5Lww==", "X-Received": "by 2002:a05:6512:132a:b0:471:af97:77b7 with SMTP id\n x42-20020a056512132a00b00471af9777b7mr18628152lfu.115.1651771834836;\n Thu, 05 May 2022 10:30:34 -0700 (PDT)", "From": "Stanislaw Kardach <kda@semihalf.com>", "To": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "Cc": "Stanislaw Kardach <kda@semihalf.com>, dev@dpdk.org,\n Frank Zhao <Frank.Zhao@starfivetech.com>, Sam Grove <sam.grove@sifive.com>,\n mw@semihalf.com, upstream@semihalf.com", "Subject": "[PATCH 09/11] test/ring: disable problematic tests for RISC-V", "Date": "Thu, 5 May 2022 19:30:01 +0200", "Message-Id": "<20220505173003.3242618-10-kda@semihalf.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220505173003.3242618-1-kda@semihalf.com>", "References": "<20220505173003.3242618-1-kda@semihalf.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When compiling for RISC-V in debug mode the large amount of inlining in\ntest_ring_basic_ex() and test_ring_with_exact_size() (in test_ring.c)\nleads to large loop bodies. This causes 'goto' and 'for' loop\nPC-relative jumps generated by the compiler to go beyond the architecture\nlimitation of +/-1MB offset (the 'j <offset>' instruction). This\ninstruction should not be generated by the compiler since C language does\nnot limit the maximum distance for 'goto' or 'for' loop jumps.\n\nThis only happens in the unit test for ring which tries to perform long\nloops with ring enqueue/dequeue and it seems to be caused by excessive\n__rte_always_inline usage. ring perf test compiles just fine under\ndebug.\n\nTo work around this, disable the offending tests in debug mode.\n\nSigned-off-by: Stanislaw Kardach <kda@semihalf.com>\nSponsored-by: Frank Zhao <Frank.Zhao@starfivetech.com>\nSponsored-by: Sam Grove <sam.grove@sifive.com>\n---\n app/test/test_ring.c | 8 ++++++++\n config/riscv/meson.build | 5 +++++\n doc/guides/rel_notes/release_22_07.rst | 3 ++-\n 3 files changed, 15 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test/test_ring.c b/app/test/test_ring.c\nindex bde33ab4a1..7d809c147b 100644\n--- a/app/test/test_ring.c\n+++ b/app/test/test_ring.c\n@@ -955,6 +955,7 @@ test_ring_burst_bulk_tests4(unsigned int test_idx)\n \treturn -1;\n }\n \n+#if !defined(RTE_RISCV_WO_DISABLE_RING_TESTS)\n /*\n * Test default, single element, bulk and burst APIs\n */\n@@ -1189,6 +1190,7 @@ test_ring_with_exact_size(void)\n \trte_ring_free(exact_sz_r);\n \treturn -1;\n }\n+#endif\n \n static int\n test_ring(void)\n@@ -1200,12 +1202,18 @@ test_ring(void)\n \tif (test_ring_negative_tests() < 0)\n \t\tgoto test_fail;\n \n+/* Disable the following tests on RISC-V in debug mode. This is a work-around\n+ * GCC bug for RISC-V which fails to generate proper jumps for loops with large\n+ * bodies.\n+ */\n+#if !defined(RTE_RISCV_WO_DISABLE_RING_TESTS)\n \t/* Some basic operations */\n \tif (test_ring_basic_ex() < 0)\n \t\tgoto test_fail;\n \n \tif (test_ring_with_exact_size() < 0)\n \t\tgoto test_fail;\n+#endif\n \n \t/* Burst and bulk operations with sp/sc, mp/mc and default.\n \t * The test cases are split into smaller test cases to\ndiff --git a/config/riscv/meson.build b/config/riscv/meson.build\nindex 0c16c31fc2..50d0b513bf 100644\n--- a/config/riscv/meson.build\n+++ b/config/riscv/meson.build\n@@ -141,3 +141,8 @@ foreach flag: dpdk_flags\n endforeach\n message('Using machine args: @0@'.format(machine_args))\n \n+# Enable work-around for ring unit tests in debug mode which fail to link\n+# properly due to bad code generation by GCC.\n+if get_option('optimization') == '0' or get_option('optimization') == 'g'\n+ add_project_arguments('-DRTE_RISCV_WO_DISABLE_RING_TESTS', language: 'c')\n+endif\ndiff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_07.rst\nindex 453591e568..4d64b68dfd 100644\n--- a/doc/guides/rel_notes/release_22_07.rst\n+++ b/doc/guides/rel_notes/release_22_07.rst\n@@ -76,7 +76,8 @@ New Features\n * Debug build of ``app/test/dpdk-test`` fails currently on RISC-V due to\n seemingly invalid loop and goto jump code generation by GCC in\n ``test_ring.c`` where extensive inlining increases the code size beyond the\n- capability of the generated instruction (JAL: +/-1MB PC-relative).\n+ capability of the generated instruction (JAL: +/-1MB PC-relative). The\n+ workaround is to disable ``test_ring_basic_ex()`` and ``test_ring_with_exact_size()`` on RISC-V on ``-O0`` or ``-Og``.\n \n * **Updated Intel iavf driver.**\n \n", "prefixes": [ "09/11" ] }