Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/111842/?format=api
{ "id": 111842, "url": "http://patchwork.dpdk.org/api/patches/111842/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220525171231.200035-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220525171231.200035-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20220525171231.200035-3-stephen@networkplumber.org", "date": "2022-05-25T17:12:29", "name": "[v3,2/3] rte_pie: remove unnecessary floating point", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7fcfedb264fc000511df5655aa8596853da0b3f2", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220525171231.200035-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 23161, "url": "http://patchwork.dpdk.org/api/series/23161/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=23161", "date": "2022-05-25T17:12:27", "name": "introduce random floating point function", "version": 3, "mbox": "http://patchwork.dpdk.org/series/23161/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/111842/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/111842/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1DD54A0555;\n\tWed, 25 May 2022 19:12:48 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EAA2041133;\n\tWed, 25 May 2022 19:12:39 +0200 (CEST)", "from mail-pg1-f180.google.com (mail-pg1-f180.google.com\n [209.85.215.180])\n by mails.dpdk.org (Postfix) with ESMTP id 4566442670\n for <dev@dpdk.org>; Wed, 25 May 2022 19:12:38 +0200 (CEST)", "by mail-pg1-f180.google.com with SMTP id h186so19396366pgc.3\n for <dev@dpdk.org>; Wed, 25 May 2022 10:12:38 -0700 (PDT)", "from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])\n by smtp.gmail.com with ESMTPSA id\n s23-20020a170902b19700b001622c377c3esm6139599plr.117.2022.05.25.10.12.35\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 25 May 2022 10:12:36 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=5/3sc9SGpZ9Q/YTgJdFfIYh1zwzoVJ75BgiA+TOIsyk=;\n b=J9DaLWmcVol7QtevyyiH8DedyYubJituluZuya9NGfjCq6pnykg0Nmjy6hrCdQYXWo\n 8gBZjQ3lTiAnkrr5KSRO3HasqQwly71gMZbEhRXRcBrcr8+MxHClFdKu9tXLk24sT6H5\n XNDnJJUmFRNwUGFZAFEZlVro7w2PszQxZ9/ugBOUQ+XMm9oHiVaIePgHCOY3Iq/ndVbg\n hy/KqnDICzGKoLOIvKjwi0rKcOPNeXivfb0Zz8PkojitKkZLo5R49JFk21PGj+QThMsJ\n I+NZvLYFty4M9gnyOq1fdum1zKOhuKYHl9QPzOLb60rS2BScClo7shfWLXlWW0UdzCG7\n CITA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=5/3sc9SGpZ9Q/YTgJdFfIYh1zwzoVJ75BgiA+TOIsyk=;\n b=spfmI3lAQYPgaoUApG+b5afZNotiXtrX0XJzzQsJvYz6i59SZtypPmfjJVhnYms85o\n KYUQ6bvDTehpKiRWl1am/rG/NiHc4mBvpMVlcLTfhe+C+dI/bV2fF6/VFtPKY20uW1ME\n ZNtmdhDUgmMcDRrStlBSeqJ3+NHH8qBvGI3KTG4ob+4QYqmIciJQQyGWLgrODLKIXzSR\n hUzAQBpaCubPz5EAwB1r54NQDzOor30snhJGkQuEvYQulSaXfO2K4rfmPA0tG1jut4r5\n ug870GkyU3QGwopCjEZsowVpmARW0S2wF+qOQRzmLHQR5X/EauJ1lE7iv/ZRkRZMHQ6A\n c/kA==", "X-Gm-Message-State": "AOAM530YxbcZYwGlyspfh+X99eRi8vrLWdlSSH0njehIgMc867wUTRzj\n ZFMGIao9EdpUo+/JHrYfOUmYd5Bvj4R3+A==", "X-Google-Smtp-Source": "\n ABdhPJyjIBK2DEhWJ0HYcLhDU9kYFiHyloPakYxziZOa/pKCj+bgvVAqBo+54VA5quMui4ap8cWCdw==", "X-Received": "by 2002:a63:f913:0:b0:3fa:2b27:bb82 with SMTP id\n h19-20020a63f913000000b003fa2b27bb82mr16203936pgi.213.1653498757241;\n Wed, 25 May 2022 10:12:37 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n wojciechx.liguzinski@intel.com,\n Cristian Dumitrescu <cristian.dumitrescu@intel.com>,\n Jasvinder Singh <jasvinder.singh@intel.com>", "Subject": "[PATCH v3 2/3] rte_pie: remove unnecessary floating point", "Date": "Wed, 25 May 2022 10:12:29 -0700", "Message-Id": "<20220525171231.200035-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220525171231.200035-1-stephen@networkplumber.org>", "References": "<20220524184623.480646-1-stephen@networkplumber.org>\n <20220525171231.200035-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The qdelay variable is derived from and compared to 64 bit\nvalue so it doesn't have to be floating point.\n\nFixes: 44c730b0e379 (\"sched: add PIE based congestion management\")\nCc: wojciechx.liguzinski@intel.com\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/sched/rte_pie.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/sched/rte_pie.h b/lib/sched/rte_pie.h\nindex 02a987f54ad1..3e2c1ef46721 100644\n--- a/lib/sched/rte_pie.h\n+++ b/lib/sched/rte_pie.h\n@@ -218,7 +218,7 @@ _rte_pie_drop(const struct rte_pie_config *pie_cfg,\n \tstruct rte_pie *pie)\n {\n \tuint64_t rand_value;\n-\tdouble qdelay = pie_cfg->qdelay_ref * 0.5;\n+\tuint64_t qdelay = pie_cfg->qdelay_ref / 2;\n \n \t/* PIE is active but the queue is not congested: return 0 */\n \tif (((pie->qdelay_old < qdelay) && (pie->drop_prob < 0.2)) ||\n", "prefixes": [ "v3", "2/3" ] }