Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112023/?format=api
{ "id": 112023, "url": "http://patchwork.dpdk.org/api/patches/112023/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/patch/20220530015647.285450-2-songx.jiale@intel.com/", "project": { "id": 3, "url": "http://patchwork.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20220530015647.285450-2-songx.jiale@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20220530015647.285450-2-songx.jiale@intel.com", "date": "2022-05-30T01:56:47", "name": "[V2] tests/userspace_ethtool: add method wait port link up and add checklist", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9364fa39e466674a264cba1c6c096e202cb357ad", "submitter": { "id": 2352, "url": "http://patchwork.dpdk.org/api/people/2352/?format=api", "name": "Jiale, SongX", "email": "songx.jiale@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dts/patch/20220530015647.285450-2-songx.jiale@intel.com/mbox/", "series": [], "comments": "http://patchwork.dpdk.org/api/patches/112023/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/112023/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9CCC2A00C4;\n\tMon, 30 May 2022 03:56:55 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 32225410FC;\n\tMon, 30 May 2022 03:56:55 +0200 (CEST)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 9F92640A82\n for <dts@dpdk.org>; Mon, 30 May 2022 03:56:53 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 May 2022 18:56:53 -0700", "from unknown (HELO daily-regression-131.intel.com)\n ([10.239.251.131])\n by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 29 May 2022 18:56:52 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1653875813; x=1685411813;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=eFXCK+k3MHBf0Lu2HRxzfJQilNiPf8gFKlNDp2WbKK0=;\n b=B/i8X7JZO5bc+43Do1NgdFCFwbWIDlvNGlEg2sjgnvVAjSYZZwFeh3Gj\n 3gqhXc78ud66k1jdyqGIyfJu0coW2RsjFIuugtw8H3vNB764u6aQyvlzt\n R3INMtzIhY0lp3FNXFZ46q3Iah/NEGJtP4W+KEWkXSOIcFGpIKHehoNCr\n H75eZO9h/FszPL0SkNpoRTNbIwpRd9uhOexy9jeXdR61VsRU3NNdieJ8e\n WOao+D3NoMbSOEzwwrLpseWXA1EbdNlE3sXPuLCgJyGguPJ4Eapk/eOYA\n OH47OjPDTVq4NttxPlsPMOOUv5AP5r7sgRJIWfTlFu7TyZZRtqDLTW+Gm A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10362\"; a=\"335517138\"", "E=Sophos;i=\"5.91,261,1647327600\"; d=\"scan'208\";a=\"335517138\"", "E=Sophos;i=\"5.91,261,1647327600\"; d=\"scan'208\";a=\"575717418\"" ], "From": "Jiale Song <songx.jiale@intel.com>", "To": "dts@dpdk.org", "Cc": "Jiale Song <songx.jiale@intel.com>", "Subject": "[dts] [PATCH V2] tests/userspace_ethtool: add method wait port link\n up and add checklist", "Date": "Mon, 30 May 2022 09:56:47 +0800", "Message-Id": "<20220530015647.285450-2-songx.jiale@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220530015647.285450-1-songx.jiale@intel.com>", "References": "<20220530015647.285450-1-songx.jiale@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=y", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "fix 4 issue:\n 1.check and wait for the port status of the tester and dut to be up and delete some unnecessary delays.\n 2.700 Series not support port disconnect by tools of linux, add 'I40E_10G-10G_BASE_T_X722'\nand 'I40E_10G-10G_BASE_T_BC'.\n 3.ensure that the dpdk app has exited and rebind the driver.\n 4.the driver of 'IGC-I225_LM' is i40e, not support the case, add to checklist.\n\nSigned-off-by: Jiale Song <songx.jiale@intel.com>\n---\n conf/test_case_checklist.json | 3 ++-\n tests/TestSuite_userspace_ethtool.py | 34 ++++++++++++++++++----------\n 2 files changed, 24 insertions(+), 13 deletions(-)", "diff": "diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json\nindex 053841ce..0347bc54 100644\n--- a/conf/test_case_checklist.json\n+++ b/conf/test_case_checklist.json\n@@ -2131,7 +2131,8 @@\n \"I40E_10G-SFP_X722\",\n \"I40E_10G-10G_BASE_T_X722\",\n \"IAVF_10G-X722_VF\",\n- \"I40E_10G-10G_BASE_T_BC\"\n+ \"I40E_10G-10G_BASE_T_BC\",\n+ \"IGC-I225_LM\"\n ],\n \"Target\": [\n \"ALL\"\ndiff --git a/tests/TestSuite_userspace_ethtool.py b/tests/TestSuite_userspace_ethtool.py\nindex adbba999..9f0bd8a8 100644\n--- a/tests/TestSuite_userspace_ethtool.py\n+++ b/tests/TestSuite_userspace_ethtool.py\n@@ -28,7 +28,7 @@ class TestUserspaceEthtool(TestCase):\n \"\"\"\n self.ports = self.dut.get_ports()\n self.verify(len(self.ports) >= 2, \"No ports found for \" + self.nic)\n-\n+ self.other_700_nic = [\"I40E_10G-10G_BASE_T_X722\", \"I40E_10G-10G_BASE_T_BC\"]\n # build sample app\n out = self.dut.build_dpdk_apps(\"examples/ethtool\")\n self.verify(\"Error\" not in out, \"compilation error 1\")\n@@ -263,18 +263,25 @@ class TestUserspaceEthtool(TestCase):\n portinfo[\"net_dev\"].bind_driver(portinfo[\"ori_driver\"])\n \n self.dut.send_expect(self.cmd, \"EthApp>\", 60)\n+ for port in self.ports:\n+ tester_port = self.tester.get_local_port(port)\n+ intf = self.tester.get_interface(tester_port)\n+ self.tester.is_interface_up(intf)\n # ethtool doesn't support port disconnect by tools of linux\n # only detect physical link disconnect status\n verify_pass = True\n verify_msg = \"\"\n- if not (self.is_eth_series_nic(700) or self.is_eth_series_nic(800)):\n+ if not (\n+ self.is_eth_series_nic(700)\n+ or self.other_700_nic\n+ or self.is_eth_series_nic(800)\n+ ):\n # check link status dump function\n for port in self.ports:\n tester_port = self.tester.get_local_port(port)\n intf = self.tester.get_interface(tester_port)\n self.tester.send_expect(\"ip link set dev %s down\" % intf, \"# \")\n- # wait for link stable\n- time.sleep(5)\n+ self.tester.is_interface_down(intf)\n \n out = self.dut.send_expect(\"link\", \"EthApp>\", 60)\n link_pattern = r\"Port (\\d+): (.*)\"\n@@ -299,8 +306,7 @@ class TestUserspaceEthtool(TestCase):\n tester_port = self.tester.get_local_port(port)\n intf = self.tester.get_interface(tester_port)\n self.tester.send_expect(\"ip link set dev %s up\" % intf, \"# \")\n- # wait for link stable\n- time.sleep(5)\n+ self.tester.is_interface_up(intf)\n \n # check port stats function\n pkt = Packet(pkt_type=\"UDP\")\n@@ -447,12 +453,13 @@ class TestUserspaceEthtool(TestCase):\n )\n pkt = Packet(pkt_type=\"UDP\")\n tester_port = self.tester.get_local_port(port)\n+ intf = self.tester.get_interface(tester_port)\n+ self.tester.is_interface_up(intf)\n self.verify(\n self.ethapp_check_link_status(index, \"Up\") == True,\n \"Fail to Open port{}\".format(index),\n )\n-\n- intf = self.tester.get_interface(tester_port)\n+ time.sleep(1)\n pkt.send_pkt(self.tester, tx_port=intf, count=4)\n rx_pkts, tx_pkts = self.strip_portstats(index)\n self.verify(\n@@ -532,6 +539,7 @@ class TestUserspaceEthtool(TestCase):\n pkt = Packet(pkt_type=\"UDP\")\n tester_port = self.tester.get_local_port(port)\n intf = self.tester.get_interface(tester_port)\n+ self.tester.is_interface_up(intf)\n pkt.send_pkt(self.tester, tx_port=intf, count=4)\n rx_pkts, tx_pkts = self.strip_portstats(index)\n self.verify(rx_pkts == ori_rx_pkts, \"Failed to stop port\")\n@@ -575,7 +583,6 @@ class TestUserspaceEthtool(TestCase):\n # Intel® Ethernet 800 Series should stop port before set mtu\n if self.nic in [\"ICE_25G-E810C_SFP\", \"ICE_100G-E810C_QSFP\"]:\n self.dut.send_expect(\"stop %s\" % index, \"EthApp>\")\n-\n # The mtu threshold is 2022,When it is greater than 2022, the open/stop port is required.\n if mtu > mtu_threshold:\n if self.nic in [\n@@ -592,7 +599,11 @@ class TestUserspaceEthtool(TestCase):\n if self.nic in [\"ICE_25G-E810C_SFP\", \"ICE_100G-E810C_QSFP\"]:\n self.dut.send_expect(\"open %s\" % index, \"EthApp>\")\n \n- time.sleep(5)\n+ self.tester.is_interface_up(intf)\n+ self.verify(\n+ self.ethapp_check_link_status(index, \"Up\") == True,\n+ \"Fail to Open port{}\".format(index),\n+ )\n ori_rx_pkts, _ = self.strip_portstats(index)\n pkt_size = mtu + HEADER_SIZE[\"eth\"] + offset\n pkt = Packet(pkt_type=\"UDP\", pkt_len=pkt_size)\n@@ -677,9 +688,8 @@ class TestUserspaceEthtool(TestCase):\n \"\"\"\n Run after each test case.\n \"\"\"\n- self.dut.bind_interfaces_linux(self.drivername)\n self.dut.kill_all()\n- pass\n+ self.dut.bind_interfaces_linux(self.drivername)\n \n def tear_down_all(self):\n \"\"\"\n", "prefixes": [ "V2" ] }