Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112330/?format=api
{ "id": 112330, "url": "http://patchwork.dpdk.org/api/patches/112330/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220601105455.166505-2-hamza.khan@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220601105455.166505-2-hamza.khan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220601105455.166505-2-hamza.khan@intel.com", "date": "2022-06-01T10:54:55", "name": "[2/2] examples/vm_power_manager: use safe version of list iterator", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9c64126df99c70c3e5a0e58d8b26f8adcba2f531", "submitter": { "id": 2714, "url": "http://patchwork.dpdk.org/api/people/2714/?format=api", "name": "Khan, Hamza", "email": "hamza.khan@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220601105455.166505-2-hamza.khan@intel.com/mbox/", "series": [ { "id": 23330, "url": "http://patchwork.dpdk.org/api/series/23330/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=23330", "date": "2022-06-01T10:54:54", "name": "[1/2] common: add safe version of foreach-list to Linux", "version": 1, "mbox": "http://patchwork.dpdk.org/series/23330/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/112330/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/112330/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A86C6A00C2;\n\tSun, 5 Jun 2022 09:52:04 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9C9D740041;\n\tSun, 5 Jun 2022 09:51:50 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 43C71410EA;\n Wed, 1 Jun 2022 12:55:14 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Jun 2022 03:55:13 -0700", "from silpixa00399752.ir.intel.com (HELO\n silpixa00399752.ger.corp.intel.com) ([10.237.222.52])\n by orsmga005.jf.intel.com with ESMTP; 01 Jun 2022 03:55:12 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1654080914; x=1685616914;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=vE957rAt9OW00McYjIZBghY0LaPcu29mg/RAXgPaTuw=;\n b=Ey0cgJeIzIrcqdCPcLB87qfHccFC71+zM4OvtEkOHTBGXTq00w2lcFbp\n iTgUj3Rh7KPivkWzVIsv6dr8NQ8DbvnnczLGZERBraI214zSNN4rb8ECK\n /r8UbX/OVfTqx22GZJ6+7BfkyBs03SOSp9TESlXfBKysBm0lNvKIKFL1Y\n F1fIVgvzMFh5433HFcjUIKWCYiOdH1HQR2sijxK9nScWxeobZVslzsGor\n Lr6+8RPHm71gUw9yQmiwAfHtGAQKZDLcQumw1ap7GQeuRIhG56fjZEC+I\n 0f41Al2TfmcvYhj/8hXCorrQF6em9Y4oVekHBQrmZOKBzEo+RvjF8uDHw w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10364\"; a=\"275557241\"", "E=Sophos;i=\"5.91,268,1647327600\"; d=\"scan'208\";a=\"275557241\"", "E=Sophos;i=\"5.91,268,1647327600\"; d=\"scan'208\";a=\"755862804\"" ], "X-ExtLoop1": "1", "From": "Hamza Khan <hamza.khan@intel.com>", "To": "David Hunt <david.hunt@intel.com>, Alan Carew <alan.carew@intel.com>,\n Pablo de Lara <pablo.de.lara.guarch@intel.com>", "Cc": "dev@dpdk.org,\n\tHamza Khan <hamza.khan@intel.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 2/2] examples/vm_power_manager: use safe version of list\n iterator", "Date": "Wed, 1 Jun 2022 10:54:55 +0000", "Message-Id": "<20220601105455.166505-2-hamza.khan@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220601105455.166505-1-hamza.khan@intel.com>", "References": "<20220601105455.166505-1-hamza.khan@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Sun, 05 Jun 2022 09:51:46 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently, when vm_power_manager exits, we are using a LIST_FOREACH\nmacro to iterate over VM info structures while freeing them. This\nleads to use-after-free error. To address this, use the newly added\nLIST_FOREACH_SAFE macro.\n\nFixes: e8ae9b662506 (\"examples/vm_power: channel manager and monitor in host\")\nCc: alan.carew@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Hamza Khan <hamza.khan@intel.com>\n---\n examples/vm_power_manager/channel_manager.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/examples/vm_power_manager/channel_manager.c b/examples/vm_power_manager/channel_manager.c\nindex 838465ab4b..bc95cec8d6 100644\n--- a/examples/vm_power_manager/channel_manager.c\n+++ b/examples/vm_power_manager/channel_manager.c\n@@ -1005,9 +1005,9 @@ channel_manager_exit(void)\n {\n \tunsigned i;\n \tchar mask[RTE_MAX_LCORE];\n-\tstruct virtual_machine_info *vm_info;\n+\tstruct virtual_machine_info *vm_info, *tmp;\n \n-\tLIST_FOREACH(vm_info, &vm_list_head, vms_info) {\n+\tLIST_FOREACH_SAFE(vm_info, &vm_list_head, vms_info, tmp) {\n \n \t\trte_spinlock_lock(&(vm_info->config_spinlock));\n \n", "prefixes": [ "2/2" ] }