Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112693/?format=api
{ "id": 112693, "url": "http://patchwork.dpdk.org/api/patches/112693/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220613102550.241759-3-wenxuanx.wu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220613102550.241759-3-wenxuanx.wu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220613102550.241759-3-wenxuanx.wu@intel.com", "date": "2022-06-13T10:25:48", "name": "[v9,2/4] ethdev: introduce protocol hdr based buffer split", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a7f82a4ea1261236d90321050dc002e6aed6796f", "submitter": { "id": 2515, "url": "http://patchwork.dpdk.org/api/people/2515/?format=api", "name": "Wu, WenxuanX", "email": "wenxuanx.wu@intel.com" }, "delegate": { "id": 3961, "url": "http://patchwork.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220613102550.241759-3-wenxuanx.wu@intel.com/mbox/", "series": [ { "id": 23498, "url": "http://patchwork.dpdk.org/api/series/23498/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=23498", "date": "2022-06-13T10:25:46", "name": "add an api to support proto based buffer split", "version": 9, "mbox": "http://patchwork.dpdk.org/series/23498/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/112693/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/112693/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2912CA0543;\n\tMon, 13 Jun 2022 12:49:12 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 715CB427E9;\n\tMon, 13 Jun 2022 12:49:09 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 79353427E9\n for <dev@dpdk.org>; Mon, 13 Jun 2022 12:49:07 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jun 2022 03:49:06 -0700", "from unknown (HELO localhost.localdomain) ([10.239.251.3])\n by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jun 2022 03:49:02 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1655117347; x=1686653347;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=UbILn8drMy7/82hw5L+QWudLJZuvt/dvXR+Zf9Ix55Q=;\n b=jBeFkeu58n46OrRz2tk4LWT1Lzg2XfbkEn7DfxY0d4vP2kzGHimSvuMs\n WnWAUjaUFZzQ/Fczn9pbj4vo8e7zX1FXozyM9mi9vgacgUiBKWCiXIWME\n rX7MVHjbzu33MUxYC76ESTQHFig1vZdTEPqKgY6k1dRaFh0X6bM6RPS6Y\n qwDncTrThfXKjiwyW4TTZrJTVSxp/wCXwDQX11z5/E1BECa9whc/KMdLh\n JqiUQbPmv0z+76E/g8bp4CxxMP+LyVEDBLORf0v5lgx08CHimoW9dUlje\n uPLCVoKAb2d9MDaG1NHV2cHTT+TPOhEwuJe2ntPTeJPxWaOAAAiyAFlaN Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10376\"; a=\"258076141\"", "E=Sophos;i=\"5.91,297,1647327600\"; d=\"scan'208\";a=\"258076141\"", "E=Sophos;i=\"5.91,297,1647327600\"; d=\"scan'208\";a=\"617442814\"" ], "From": "wenxuanx.wu@intel.com", "To": "thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, xiaoyun.li@intel.com,\n ferruh.yigit@xilinx.com, aman.deep.singh@intel.com, dev@dpdk.org,\n yuying.zhang@intel.com, qi.z.zhang@intel.com, jerinjacobk@gmail.com", "Cc": "stephen@networkplumber.org, Wenxuan Wu <wenxuanx.wu@intel.com>,\n Xuan Ding <xuan.ding@intel.com>, Yuan Wang <yuanx.wang@intel.com>,\n Ray Kinsella <mdr@ashroe.eu>", "Subject": "[PATCH v9 2/4] ethdev: introduce protocol hdr based buffer split", "Date": "Mon, 13 Jun 2022 10:25:48 +0000", "Message-Id": "<20220613102550.241759-3-wenxuanx.wu@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220613102550.241759-1-wenxuanx.wu@intel.com>", "References": "<20220303060136.36427-1-xuan.ding@intel.com>\n <20220613102550.241759-1-wenxuanx.wu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Wenxuan Wu <wenxuanx.wu@intel.com>\n\nCurrently, Rx buffer split supports length based split. With Rx queue\noffload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT enabled and Rx packet segment\nconfigured, PMD will be able to split the received packets into\nmultiple segments.\n\nHowever, length based buffer split is not suitable for NICs that do split\nbased on protocol headers. Given an arbitrarily variable length in Rx\npacket segment, it is almost impossible to pass a fixed protocol header to\ndriver. Besides, the existence of tunneling results in the composition of\na packet is various, which makes the situation even worse.\n\nThis patch extends current buffer split to support protocol header based\nbuffer split. A new proto_hdr field is introduced in the reserved field\nof rte_eth_rxseg_split structure to specify protocol header. The proto_hdr\nfield defines the split position of packet, splitting will always happens\nafter the protocol header defined in the Rx packet segment. When Rx queue\noffload RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT is enabled and corresponding\nprotocol header is configured, driver will split the ingress packets into\nmultiple segments.\n\nstruct rte_eth_rxseg_split {\n\n struct rte_mempool *mp; /* memory pools to allocate segment from */\n uint16_t length; /* segment maximal data length,\n configures \"split point\" */\n uint16_t offset; /* data offset from beginning\n of mbuf data buffer */\n uint32_t proto_hdr; /* inner/outer L2/L3/L4 protocol header,\n\t\t\t configures \"split point\" */\n };\n\nIf both inner and outer L2/L3/L4 level protocol header split can be\nsupported by a PMD. Corresponding protocol header capability is\nRTE_PTYPE_L2_ETHER, RTE_PTYPE_L3_IPV4, RTE_PTYPE_L3_IPV6, RTE_PTYPE_L4_TCP,\nRTE_PTYPE_L4_UDP, RTE_PTYPE_L4_SCTP, RTE_PTYPE_INNER_L2_ETHER,\nRTE_PTYPE_INNER_L3_IPV4, RTE_PTYPE_INNER_L3_IPV6, RTE_PTYPE_INNER_L4_TCP,\nRTE_PTYPE_INNER_L4_UDP, RTE_PTYPE_INNER_L4_SCTP.\n\nFor example, let's suppose we configured the Rx queue with the\nfollowing segments:\n seg0 - pool0, proto_hdr0=RTE_PTYPE_L3_IPV4, off0=2B\n seg1 - pool1, proto_hdr1=RTE_PTYPE_L4_UDP, off1=128B\n seg2 - pool2, off1=0B\n\nThe packet consists of MAC_IPV4_UDP_PAYLOAD will be split like\nfollowing:\n seg0 - ipv4 header @ RTE_PKTMBUF_HEADROOM + 2 in mbuf from pool0\n seg1 - udp header @ 128 in mbuf from pool1\n seg2 - payload @ 0 in mbuf from pool2\n\nNow buffer split can be configured in two modes. For length based\nbuffer split, the mp, length, offset field in Rx packet segment should\nbe configured, while the proto_hdr field should not be configured.\nFor protocol header based buffer split, the mp, offset, proto_hdr field\nin Rx packet segment should be configured, while the length field should\nnot be configured.\n\nThe split limitations imposed by underlying driver is reported in the\nrte_eth_dev_info->rx_seg_capa field. The memory attributes for the split\nparts may differ either, dpdk memory and external memory, respectively.\n\nSigned-off-by: Xuan Ding <xuan.ding@intel.com>\nSigned-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>\nSigned-off-by: Yuan Wang <yuanx.wang@intel.com>\nReviewed-by: Qi Zhang <qi.z.zhang@intel.com>\nAcked-by: Ray Kinsella <mdr@ashroe.eu>\n---\n lib/ethdev/rte_ethdev.c | 32 +++++++++++++++++++++++++++++++-\n lib/ethdev/rte_ethdev.h | 14 +++++++++++++-\n 2 files changed, 44 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex e1f2a0ffe3..b89e30296f 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -1662,6 +1662,7 @@ rte_eth_rx_queue_check_split(uint16_t port_id,\n \t\tstruct rte_mempool *mpl = rx_seg[seg_idx].mp;\n \t\tuint32_t length = rx_seg[seg_idx].length;\n \t\tuint32_t offset = rx_seg[seg_idx].offset;\n+\t\tuint32_t proto_hdr = rx_seg[seg_idx].proto_hdr;\n \n \t\tif (mpl == NULL) {\n \t\t\tRTE_ETHDEV_LOG(ERR, \"null mempool pointer\\n\");\n@@ -1695,7 +1696,36 @@ rte_eth_rx_queue_check_split(uint16_t port_id,\n \t\t}\n \t\toffset += seg_idx != 0 ? 0 : RTE_PKTMBUF_HEADROOM;\n \t\t*mbp_buf_size = rte_pktmbuf_data_room_size(mpl);\n-\n+\t\tuint32_t ptypes_mask;\n+\t\tint ret = rte_eth_supported_hdrs_get(port_id, &ptypes_mask);\n+\n+\t\tif (ret == ENOTSUP || ptypes_mask == RTE_PTYPE_UNKNOWN) {\n+\t\t\t/* Split at fixed length. */\n+\t\t\tlength = length != 0 ? length : *mbp_buf_size;\n+\t\t\tif (*mbp_buf_size < length + offset) {\n+\t\t\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\t\t\"%s mbuf_data_room_size %u < %u (segment length=%u + segment offset=%u)\\n\",\n+\t\t\t\t\tmpl->name, *mbp_buf_size,\n+\t\t\t\t\tlength + offset, length, offset);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t} else if (ret == 0) {\n+\t\t\t/* Split after specified protocol header. */\n+\t\t\tif (proto_hdr & ~ptypes_mask) {\n+\t\t\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\t\t\"Protocol header 0x%x is not supported.\\n\",\n+\t\t\t\t\tproto_hdr & ~ptypes_mask);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t\tif (*mbp_buf_size < offset) {\n+\t\t\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\t\t\t\"%s mbuf_data_room_size %u < %u segment offset)\\n\",\n+\t\t\t\t\t\tmpl->name, *mbp_buf_size,\n+\t\t\t\t\t\toffset);\n+\t\t\t\treturn -EINVAL;\n+\t\t\t}\n+\t\t} else {\n+\t\t\treturn ret;\n \t\t}\n \t}\n \treturn 0;\ndiff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex 72cac1518e..7df40f9f9b 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -1176,6 +1176,9 @@ struct rte_eth_txmode {\n * specified in the first array element, the second buffer, from the\n * pool in the second element, and so on.\n *\n+ * - The proto_hdrs in the elements define the split position of\n+ * received packets.\n+ *\n * - The offsets from the segment description elements specify\n * the data offset from the buffer beginning except the first mbuf.\n * The first segment offset is added with RTE_PKTMBUF_HEADROOM.\n@@ -1197,12 +1200,21 @@ struct rte_eth_txmode {\n * - pool from the last valid element\n * - the buffer size from this pool\n * - zero offset\n+ *\n+ * - Length based buffer split:\n+ * - mp, length, offset should be configured.\n+ * - The proto_hdr field should not be configured.\n+ *\n+ * - Protocol header based buffer split:\n+ * - mp, offset, proto_hdr should be configured.\n+ * - The length field should not be configured.\n */\n struct rte_eth_rxseg_split {\n \tstruct rte_mempool *mp; /**< Memory pool to allocate segment from. */\n \tuint16_t length; /**< Segment data length, configures split point. */\n \tuint16_t offset; /**< Data offset from beginning of mbuf data buffer. */\n-\tuint32_t reserved; /**< Reserved field. */\n+\t/**< Supported ptypes mask of a specific pmd, configures split point. */\n+\tuint32_t proto_hdr;\n };\n \n /**\n", "prefixes": [ "v9", "2/4" ] }