Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/112837/?format=api
{ "id": 112837, "url": "http://patchwork.dpdk.org/api/patches/112837/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220616070743.30658-2-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220616070743.30658-2-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220616070743.30658-2-ndabilpuram@marvell.com", "date": "2022-06-16T07:07:33", "name": "[02/12] common/cnxk: avoid CPT backpressure due to errata", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "fa8f166bb9c2acf28f1bc786b538bf18601f70d3", "submitter": { "id": 1202, "url": "http://patchwork.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220616070743.30658-2-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 23552, "url": "http://patchwork.dpdk.org/api/series/23552/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=23552", "date": "2022-06-16T07:07:32", "name": "[01/12] common/cnxk: use computed value for wqe skip", "version": 1, "mbox": "http://patchwork.dpdk.org/series/23552/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/112837/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/112837/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5BF22A00C3;\n\tThu, 16 Jun 2022 09:09:52 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4B62642BDC;\n\tThu, 16 Jun 2022 09:09:48 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 27863410D0\n for <dev@dpdk.org>; Thu, 16 Jun 2022 09:09:45 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 25G2BTY0015011\n for <dev@dpdk.org>; Thu, 16 Jun 2022 00:09:44 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3gq83yx4yv-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 16 Jun 2022 00:09:37 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Thu, 16 Jun 2022 00:09:35 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Thu, 16 Jun 2022 00:09:35 -0700", "from hyd1588t430.marvell.com (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 0D1A83F709B;\n Thu, 16 Jun 2022 00:09:32 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=e6QL4ZIr4q5y0gZglPZF2NdVf7G4aKmlNBrWpRS6+xQ=;\n b=SNsa7s79UBAldnSCD6kFhxzEivmWfZ04O/wJKsqUAfviEuuPExn0Ef4kAQpSrgTZ9W9o\n dPe+mNhq2vMgbU8V8HN7oVCDPv6uNeudW2Zqe1sqqlbALtxxSMVas0ZQrlVuf3z7MCS2\n hDMhbdO7zO/b/uy39kgTx3M5Nqs1797MJSQqBm2qOI58WBkDYSwKvva7xQrSSkXSb3xa\n h/KG4p852c2VyzDTtxbsnyUBsUE2DdRe90VoRd/fRzdjx3iYEdQRLgSZV8rOvlr4HjcR\n kXRNB2cvrgjv/6IlJejmXN6X19pwryY83g33trVPZGj0ORvDAMWckWYx+QHoMuyRFHTo qQ==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Kiran\n Kumar K\" <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Satha Rao <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH 02/12] common/cnxk: avoid CPT backpressure due to errata", "Date": "Thu, 16 Jun 2022 12:37:33 +0530", "Message-ID": "<20220616070743.30658-2-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.8.4", "In-Reply-To": "<20220616070743.30658-1-ndabilpuram@marvell.com>", "References": "<20220616070743.30658-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "tj1JRMhV66wGBkXAO9AmKrnOaMmVHBu0", "X-Proofpoint-GUID": "tj1JRMhV66wGBkXAO9AmKrnOaMmVHBu0", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514\n definitions=2022-06-16_03,2022-06-15_01,2022-02-23_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Avoid enabling CPT backpressure due to errata where\nbackpressure would block requests from even other\nCPT LF's. Also allow CQ size >=16K.\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\n---\n drivers/common/cnxk/roc_errata.h | 7 +++++++\n drivers/common/cnxk/roc_nix.h | 2 +-\n drivers/common/cnxk/roc_nix_fc.c | 3 ++-\n 3 files changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_errata.h b/drivers/common/cnxk/roc_errata.h\nindex 31162d5..f048297 100644\n--- a/drivers/common/cnxk/roc_errata.h\n+++ b/drivers/common/cnxk/roc_errata.h\n@@ -77,4 +77,11 @@ roc_errata_nix_has_perf_issue_on_stats_update(void)\n \treturn true;\n }\n \n+/* Errata IPBUCPT-38726, IPBUCPT-38727 */\n+static inline bool\n+roc_errata_cpt_hang_on_x2p_bp(void)\n+{\n+\treturn roc_model_is_cn10ka_a0();\n+}\n+\n #endif /* _ROC_ERRATA_H_ */\ndiff --git a/drivers/common/cnxk/roc_nix.h b/drivers/common/cnxk/roc_nix.h\nindex aedde1c..944e4c6 100644\n--- a/drivers/common/cnxk/roc_nix.h\n+++ b/drivers/common/cnxk/roc_nix.h\n@@ -309,7 +309,7 @@ struct roc_nix_rq {\n struct roc_nix_cq {\n \t/* Input parameters */\n \tuint16_t qid;\n-\tuint16_t nb_desc;\n+\tuint32_t nb_desc;\n \t/* End of Input parameters */\n \tuint16_t drop_thresh;\n \tstruct roc_nix *roc_nix;\ndiff --git a/drivers/common/cnxk/roc_nix_fc.c b/drivers/common/cnxk/roc_nix_fc.c\nindex a0505bd..cef5d07 100644\n--- a/drivers/common/cnxk/roc_nix_fc.c\n+++ b/drivers/common/cnxk/roc_nix_fc.c\n@@ -77,7 +77,8 @@ nix_fc_rxchan_bpid_set(struct roc_nix *roc_nix, bool enable)\n \t\tgoto exit;\n \n \t/* Enable backpressure on CPT if inline inb is enabled */\n-\tif (enable && roc_nix_inl_inb_is_enabled(roc_nix)) {\n+\tif (enable && roc_nix_inl_inb_is_enabled(roc_nix) &&\n+\t !roc_errata_cpt_hang_on_x2p_bp()) {\n \t\treq = mbox_alloc_msg_nix_cpt_bp_enable(mbox);\n \t\tif (req == NULL)\n \t\t\treturn rc;\n", "prefixes": [ "02/12" ] }