Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/113663/?format=api
{ "id": 113663, "url": "http://patchwork.dpdk.org/api/patches/113663/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220704152751.943965-4-kevin.laatz@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220704152751.943965-4-kevin.laatz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220704152751.943965-4-kevin.laatz@intel.com", "date": "2022-07-04T15:27:51", "name": "[v3,3/3] dma/idxd: fix null pointer dereference during pci remove", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ce0029d1e00e740f84a80d8c702799fa2531b820", "submitter": { "id": 921, "url": "http://patchwork.dpdk.org/api/people/921/?format=api", "name": "Kevin Laatz", "email": "kevin.laatz@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220704152751.943965-4-kevin.laatz@intel.com/mbox/", "series": [ { "id": 23877, "url": "http://patchwork.dpdk.org/api/series/23877/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=23877", "date": "2022-07-04T15:27:48", "name": "Fix IDXD PCI device close", "version": 3, "mbox": "http://patchwork.dpdk.org/series/23877/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/113663/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/113663/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0139AA0540;\n\tMon, 4 Jul 2022 17:27:56 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2220742B73;\n\tMon, 4 Jul 2022 17:27:42 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 6D3EC40E09;\n Mon, 4 Jul 2022 17:27:38 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Jul 2022 08:27:13 -0700", "from silpixa00401122.ir.intel.com ([10.237.213.29])\n by FMSMGA003.fm.intel.com with ESMTP; 04 Jul 2022 08:27:11 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1656948458; x=1688484458;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=tTzgjTPtKJyGFi85E66ohWVWqgfAUW5ECkd/53bJxlk=;\n b=ItGpVdIOeVXTvdLunXWPgHZ0erho4CQI4wBacWs5zVRP6I6NEaUCKs1Q\n vRhSfHnfqe0cQgywVuEFtQn3+MPDvq+1ErvMQ+p6E6ylrQPcSe+gzq3uu\n nJUubRTJjxIBszPn1SvHJ7Oo9Emd9VgEF5RkaVIW8s1Qq666Qb3FBZdnI\n jFqrtkESZlFux0BoeaqFSJ26N+S/6RQy0aeVk/Y/VnmUMTcW02k8kM/d7\n SPP8w6GSPE9CVPO4o1nR5h8vUiHwD6lpWZJaFjcz+WTKdEmhyOFISvs70\n IeANeHLMSmvBuOfGOfITSWy+YMCPO6FCC8gf1U2Z5H6utIbS1JdO2ruwB Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10398\"; a=\"262946841\"", "E=Sophos;i=\"5.92,243,1650956400\"; d=\"scan'208\";a=\"262946841\"", "E=Sophos;i=\"5.92,243,1650956400\"; d=\"scan'208\";a=\"682231016\"" ], "X-ExtLoop1": "1", "From": "Kevin Laatz <kevin.laatz@intel.com>", "To": "dev@dpdk.org", "Cc": "bruce.richardson@intel.com, Kevin Laatz <kevin.laatz@intel.com>,\n stable@dpdk.org", "Subject": "[PATCH v3 3/3] dma/idxd: fix null pointer dereference during pci\n remove", "Date": "Mon, 4 Jul 2022 16:27:51 +0100", "Message-Id": "<20220704152751.943965-4-kevin.laatz@intel.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20220704152751.943965-1-kevin.laatz@intel.com>", "References": "<20220408141504.1319913-1-kevin.laatz@intel.com>\n <20220704152751.943965-1-kevin.laatz@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The 'info' struct was being declared as a NULL pointer. If a NULL\npointer is passed to 'rte_dma_info_get', EINVAL is returned and the\nstruct is not populated. This subsequently causes a segfault when\ndereferencing 'info'.\n\nThis patch fixes the issue by simply declaring 'info' on the stack and\npassing its address to 'rte_dma_info_get'.\n\nFixes: 9449330a8458 (\"dma/idxd: create dmadev instances on PCI probe\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/dma/idxd/idxd_pci.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c\nindex 2c3b01cd2b..2f8ec06d9e 100644\n--- a/drivers/dma/idxd/idxd_pci.c\n+++ b/drivers/dma/idxd/idxd_pci.c\n@@ -380,10 +380,10 @@ idxd_dmadev_remove_pci(struct rte_pci_device *dev)\n \tIDXD_PMD_INFO(\"Closing %s on NUMA node %d\", name, dev->device.numa_node);\n \n \tRTE_DMA_FOREACH_DEV(i) {\n-\t\tstruct rte_dma_info *info = {0};\n-\t\trte_dma_info_get(i, info);\n-\t\tif (strncmp(name, info->dev_name, strlen(name)) == 0)\n-\t\t\tidxd_dmadev_destroy(info->dev_name);\n+\t\tstruct rte_dma_info info;\n+\t\trte_dma_info_get(i, &info);\n+\t\tif (strncmp(name, info.dev_name, strlen(name)) == 0)\n+\t\t\tidxd_dmadev_destroy(info.dev_name);\n \t}\n \n \treturn 0;\n", "prefixes": [ "v3", "3/3" ] }