Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/114171/?format=api
{ "id": 114171, "url": "http://patchwork.dpdk.org/api/patches/114171/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220725163543.875775-12-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220725163543.875775-12-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220725163543.875775-12-bruce.richardson@intel.com", "date": "2022-07-25T16:35:40", "name": "[v2,11/13] test/telemetry_data: add test cases for character escaping", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "add4e3df7861d1130b57c4a5b385cf1315738b22", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220725163543.875775-12-bruce.richardson@intel.com/mbox/", "series": [ { "id": 24069, "url": "http://patchwork.dpdk.org/api/series/24069/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=24069", "date": "2022-07-25T16:35:29", "name": "telemetry JSON escaping and other enhancements", "version": 2, "mbox": "http://patchwork.dpdk.org/series/24069/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/114171/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/114171/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C4BFCA00C4;\n\tMon, 25 Jul 2022 18:37:03 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C1F7C42B8D;\n\tMon, 25 Jul 2022 18:36:34 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 11F5342B89\n for <dev@dpdk.org>; Mon, 25 Jul 2022 18:36:32 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Jul 2022 09:36:32 -0700", "from silpixa00401385.ir.intel.com (HELO\n silpixa00401385.ger.corp.intel.com.) ([10.237.223.47])\n by orsmga006.jf.intel.com with ESMTP; 25 Jul 2022 09:36:31 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1658766993; x=1690302993;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=ulk7dfNr+IpskgW6mtTN0ffCvjyImwIkl400BPLel7g=;\n b=P/Y4lDzFLP0oO2uvqTgqsBy8YF3vbkJ9LiCZXkEnxAzO9zb6iliT019B\n uYVappPqpAr+Y9Ug8i+QMki7OLZvbdYsU9/XivJ8u/HE4NvfLJBWKUxAT\n 3/MJstcsNxx2RACm6XmBQmsI6NY81K8cFqAJY6Rk438hfZE/hEs43JMH+\n Y32WqIOlkKpvYa7mOxIe7deSY9R/ktuBB3KHLnKeDQkPAwyKLWUPjmUjp\n DQHG+wc5oZOURm+ZDP4nyRo7tVzBHP5YXBMMjdjE/zWeg6p1A6/VSuuRg\n F4fbSHh6G8PZjyl7O/rpWaeS7n/+Gy1vKIHZE/hfPuy9xUws86R/k1fhC A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6400,9594,10419\"; a=\"288499134\"", "E=Sophos;i=\"5.93,193,1654585200\"; d=\"scan'208\";a=\"288499134\"", "E=Sophos;i=\"5.93,193,1654585200\"; d=\"scan'208\";a=\"575122755\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Ciara Power <ciara.power@intel.com>", "Subject": "[PATCH v2 11/13] test/telemetry_data: add test cases for character\n escaping", "Date": "Mon, 25 Jul 2022 17:35:40 +0100", "Message-Id": "<20220725163543.875775-12-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220725163543.875775-1-bruce.richardson@intel.com>", "References": "<20220623164245.561371-1-bruce.richardson@intel.com>\n <20220725163543.875775-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add in some basic unit tests to validate the character escaping being\ndone on string data values, which tests end-to-end processing of those\nvalues beyond just the json-encoding steps tested by the\n\"telemetry_json_autotest\".\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/test_telemetry_data.c | 30 +++++++++++++++++++++++++++++-\n 1 file changed, 29 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test/test_telemetry_data.c b/app/test/test_telemetry_data.c\nindex 5a85e790d3..cfa4d636f0 100644\n--- a/app/test/test_telemetry_data.c\n+++ b/app/test/test_telemetry_data.c\n@@ -347,6 +347,30 @@ test_array_with_array_u64_values(void)\n \treturn CHECK_OUTPUT(\"[[0,1,2,3,4],[0,1,2,3,4]]\");\n }\n \n+static int\n+test_string_char_escaping(void)\n+{\n+\trte_tel_data_string(&response_data, \"hello,\\nworld\\n\");\n+\treturn CHECK_OUTPUT(\"\\\"hello,\\\\nworld\\\\n\\\"\");\n+}\n+\n+static int\n+test_array_char_escaping(void)\n+{\n+\trte_tel_data_start_array(&response_data, RTE_TEL_STRING_VAL);\n+\trte_tel_data_add_array_string(&response_data, \"\\\\escape\\r\");\n+\trte_tel_data_add_array_string(&response_data, \"characters\\n\");\n+\treturn CHECK_OUTPUT(\"[\\\"\\\\\\\\escape\\\\r\\\",\\\"characters\\\\n\\\"]\");\n+}\n+\n+static int\n+test_dict_char_escaping(void)\n+{\n+\trte_tel_data_start_dict(&response_data);\n+\trte_tel_data_add_dict_string(&response_data, \"name\", \"escaped\\n\\tvalue\");\n+\treturn CHECK_OUTPUT(\"{\\\"name\\\":\\\"escaped\\\\n\\\\tvalue\\\"}\");\n+}\n+\n static int\n connect_to_socket(void)\n {\n@@ -406,7 +430,11 @@ telemetry_data_autotest(void)\n \t\t\ttest_dict_with_dict_values,\n \t\t\ttest_array_with_array_int_values,\n \t\t\ttest_array_with_array_u64_values,\n-\t\t\ttest_array_with_array_string_values };\n+\t\t\ttest_array_with_array_string_values,\n+\t\t\ttest_string_char_escaping,\n+\t\t\ttest_array_char_escaping,\n+\t\t\ttest_dict_char_escaping,\n+\t};\n \n \trte_telemetry_register_cmd(REQUEST_CMD, telemetry_test_cb, \"Test\");\n \tfor (i = 0; i < RTE_DIM(test_cases); i++) {\n", "prefixes": [ "v2", "11/13" ] }