Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/115442/?format=api
{ "id": 115442, "url": "http://patchwork.dpdk.org/api/patches/115442/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/patch/20220826024308.17447-3-weiyuanx.li@intel.com/", "project": { "id": 3, "url": "http://patchwork.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20220826024308.17447-3-weiyuanx.li@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20220826024308.17447-3-weiyuanx.li@intel.com", "date": "2022-08-26T02:43:01", "name": "[V2,03/10] tests/checksum_offload: update dts code for dpdk csum change", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c8536a69a62069829f6402bc4a650be945f29668", "submitter": { "id": 2477, "url": "http://patchwork.dpdk.org/api/people/2477/?format=api", "name": "Weiyuan Li", "email": "weiyuanx.li@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dts/patch/20220826024308.17447-3-weiyuanx.li@intel.com/mbox/", "series": [ { "id": 24416, "url": "http://patchwork.dpdk.org/api/series/24416/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/list/?series=24416", "date": "2022-08-26T02:42:59", "name": "[V2,01/10] tests/vf_offload: update dts code for dpdk csum change", "version": 2, "mbox": "http://patchwork.dpdk.org/series/24416/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/115442/comments/", "check": "pending", "checks": "http://patchwork.dpdk.org/api/patches/115442/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E8AD0A0551;\n\tFri, 26 Aug 2022 04:43:14 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E3B0E40143;\n\tFri, 26 Aug 2022 04:43:14 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id AB8FE400D6\n for <dts@dpdk.org>; Fri, 26 Aug 2022 04:43:12 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Aug 2022 19:43:11 -0700", "from unknown (HELO localhost.localdomain) ([10.239.252.248])\n by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Aug 2022 19:43:09 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1661481792; x=1693017792;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=1TsFJERQDU94Ol8JAVZJKDEmZDv/ZKMhrVhsAfTSAd4=;\n b=SBblJbQOSX0Tkrfn3QRf07arp2k6ABAfP15/iZR2BYwnYcLRu6a9arh4\n wQBj7g7/J5tc/g3+j3mT2k81dwi75X/VBc3ClYYZCVfA1eJFor6MxQhAn\n 8dFLH8CSTC7FU9QVbXsEDg0oqSr0zmODYu7ULRvr29vq++ZkP/e5T5PPQ\n 3A5e10CJGzcmHo0ffZPr4feaMh+1UVHT778P/wvDCZiwzjbupxwDxds9P\n 4naMc4t3+45n+UDHaBwi9S+nEQ9XUNlF+jwcuAsOCzHc0jRiuqEmgLBkF\n 6mdbWXTELxwO9cpj3CB4EwOmaAU38PGX/KAto+HC3izBudukveLl6NV2q g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10450\"; a=\"295187346\"", "E=Sophos;i=\"5.93,264,1654585200\"; d=\"scan'208\";a=\"295187346\"", "E=Sophos;i=\"5.93,264,1654585200\"; d=\"scan'208\";a=\"671275191\"" ], "From": "Weiyuan Li <weiyuanx.li@intel.com>", "To": "dts@dpdk.org", "Cc": "Weiyuan Li <weiyuanx.li@intel.com>,\n\tJiale Song <songx.jiale@intel.com>", "Subject": "[dts][PATCH V2 03/10] tests/checksum_offload: update dts code for\n dpdk csum change", "Date": "Fri, 26 Aug 2022 10:43:01 +0800", "Message-Id": "<20220826024308.17447-3-weiyuanx.li@intel.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20220826024308.17447-1-weiyuanx.li@intel.com>", "References": "<20220826024308.17447-1-weiyuanx.li@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "According to dpdk commit 9b4ea7ae77fa(app/testpmd: revert MAC update in checksum forwarding) modify\nthe script adapt to this chagne.\n\n1. Modify VF case to enable promisc.\n2. Modify PF case to send packet dst mac is random.\n\nSigned-off-by: Weiyuan Li <weiyuanx.li@intel.com>\n---\nTested-by: Jiale Song < songx.jiale@intel.com>\n\nv2:\n-modify dst mac address\n\n tests/TestSuite_checksum_offload.py | 35 +++++++++++++----------------\n 1 file changed, 16 insertions(+), 19 deletions(-)", "diff": "diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py\nindex 3554f5eb..1ccc884c 100644\n--- a/tests/TestSuite_checksum_offload.py\n+++ b/tests/TestSuite_checksum_offload.py\n@@ -204,11 +204,10 @@ class TestChecksumOffload(TestCase):\n self.tester.get_local_port(self.dut_ports[0])\n )\n \n- sniff_src = self.dut.get_mac_address(self.dut_ports[0])\n+ sniff_src = \"52:00:00:00:00:00\"\n result = dict()\n \n chksum = self.get_chksum_values(packets_expected)\n-\n inst = self.tester.tcpdump_sniff_packets(\n intf=rx_interface,\n count=len(packets_sent) * 4,\n@@ -424,8 +423,9 @@ class TestChecksumOffload(TestCase):\n ):\n if os.path.isfile(capture_file_path):\n os.remove(capture_file_path)\n+ src_mac = \"52:00:00:00:00:00\"\n self.tester.send_expect(\n- f\"tcpdump -i '{iface}' ether src {dut_mac} -s 0 -w {capture_file_path} &\",\n+ f\"tcpdump -i '{iface}' ether src {src_mac} -s 0 -w {capture_file_path} -Q in &\",\n \"# \",\n )\n \n@@ -502,7 +502,8 @@ class TestChecksumOffload(TestCase):\n Verify that the same number of packet are correctly received on the\n traffic generator side.\n \"\"\"\n- mac = self.dut.get_mac_address(self.dut_ports[0])\n+ # mac = self.dut.get_mac_address(self.dut_ports[0])\n+ mac = \"52:00:00:00:00:01\"\n \n pktsChkErr = {\n \"IP/UDP\": 'Ether(dst=\"%s\", src=\"52:00:00:00:00:00\")/Dot1Q(vlan=1)/IP(chksum=0x0)/UDP(chksum=0xf)/(\"X\"*46)'\n@@ -546,7 +547,7 @@ class TestChecksumOffload(TestCase):\n transmit packet.Enable Checksum offload.\n Verify the checksum valid-flags.\n \"\"\"\n- mac = self.dut.get_mac_address(self.dut_ports[0])\n+ mac = \"52:00:00:00:00:01\"\n \n pkts_ref = {\n \"IP/UDP\": 'Ether(dst=\"%s\", src=\"52:00:00:00:00:00\")/IP()/UDP()/(\"X\"*46)'\n@@ -611,7 +612,7 @@ class TestChecksumOffload(TestCase):\n Verify that the same number of packet are correctly received on the\n traffic generator side.\n \"\"\"\n- mac = self.dut.get_mac_address(self.dut_ports[0])\n+ mac = \"52:00:00:00:00:01\"\n \n pkts = {\n \"IP/UDP\": 'Ether(dst=\"%s\", src=\"52:00:00:00:00:00\")/IP(chksum=0x0)/UDP(chksum=0xf)/(\"X\"*46)'\n@@ -660,7 +661,7 @@ class TestChecksumOffload(TestCase):\n Verify that the same number of packet are correctly received on\n the traffic generator side.\n \"\"\"\n- mac = self.dut.get_mac_address(self.dut_ports[0])\n+ mac = \"52:00:00:00:00:01\"\n sndIP = \"10.0.0.1\"\n sndIPv6 = \"::1\"\n sndPkts = {\n@@ -816,9 +817,8 @@ class TestChecksumOffload(TestCase):\n verification_errors: List[VerifyFailure] = []\n \n iface = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))\n- dut_mac = self.dut.get_mac_address(self.dut_ports[0])\n- tester_mac = self.tester.get_mac(self.tester.get_local_port(self.dut_ports[0]))\n-\n+ dut_mac = \"52:00:00:00:00:01\"\n+ tester_mac = \"52:00:00:00:00:00\"\n self.scapy_exec(f\"eth = Ether(dst='{dut_mac}', src='{tester_mac}')\")\n self.scapy_exec(f\"iface = '{iface}'\")\n \n@@ -848,8 +848,8 @@ class TestChecksumOffload(TestCase):\n verification_errors: List[VerifyFailure] = []\n \n iface = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))\n- dut_mac = self.dut.get_mac_address(self.dut_ports[0])\n- tester_mac = self.tester.get_mac(self.tester.get_local_port(self.dut_ports[0]))\n+ dut_mac = \"52:00:00:00:00:01\"\n+ tester_mac = \"52:00:00:00:00:00\"\n eth = Ether(dst=dut_mac, src=tester_mac)\n \n checksum_options = (\n@@ -903,9 +903,8 @@ class TestChecksumOffload(TestCase):\n verification_errors: List[VerifyFailure] = []\n \n iface = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))\n- dut_mac = self.dut.get_mac_address(self.dut_ports[0])\n- tester_mac = self.tester.get_mac(self.tester.get_local_port(self.dut_ports[0]))\n-\n+ dut_mac = \"52:00:00:00:00:01\"\n+ tester_mac = \"52:00:00:00:00:00\"\n self.tester.send_expect(\"scapy\", \">>> \")\n self.scapy_exec(f\"eth = Ether(dst='{dut_mac}', src='{tester_mac}')\")\n self.scapy_exec(f\"iface = '{iface}'\")\n@@ -1003,9 +1002,8 @@ class TestChecksumOffload(TestCase):\n verification_errors: List[VerifyFailure] = []\n \n iface = self.tester.get_interface(self.tester.get_local_port(self.dut_ports[0]))\n- dut_mac = self.dut.get_mac_address(self.dut_ports[0])\n- tester_mac = self.tester.get_mac(self.tester.get_local_port(self.dut_ports[0]))\n-\n+ dut_mac = \"52:00:00:00:00:01\"\n+ tester_mac = \"52:00:00:00:00:00\"\n packets = self.get_packets(dut_mac, tester_mac)\n \n capture_file_name = \"test_hardware_checksum_check_l4_tx_capture.pcap\"\n@@ -1022,7 +1020,6 @@ class TestChecksumOffload(TestCase):\n )\n \n captured_packets = rdpcap(\"output/tmp/pcap/\" + capture_file_name)\n-\n self.verify(\n len(packets) == len(captured_packets), \"Not all packets were received\"\n )\n", "prefixes": [ "V2", "03/10" ] }