Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/116397/?format=api
{ "id": 116397, "url": "http://patchwork.dpdk.org/api/patches/116397/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/cc33a1f1fa1da154bddd019ee5578af7f99df23d.1663336827.git.gmuthukrishn@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<cc33a1f1fa1da154bddd019ee5578af7f99df23d.1663336827.git.gmuthukrishn@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/cc33a1f1fa1da154bddd019ee5578af7f99df23d.1663336827.git.gmuthukrishn@marvell.com", "date": "2022-09-16T14:01:31", "name": "[v1] examples/fips_validation: fix SHA MCT test from segfault", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d49d2eaadf7849baf1848fd81e7367b1c6393190", "submitter": { "id": 2301, "url": "http://patchwork.dpdk.org/api/people/2301/?format=api", "name": "Gowrishankar Muthukrishnan", "email": "gmuthukrishn@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/cc33a1f1fa1da154bddd019ee5578af7f99df23d.1663336827.git.gmuthukrishn@marvell.com/mbox/", "series": [ { "id": 24694, "url": "http://patchwork.dpdk.org/api/series/24694/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=24694", "date": "2022-09-16T14:01:31", "name": "[v1] examples/fips_validation: fix SHA MCT test from segfault", "version": 1, "mbox": "http://patchwork.dpdk.org/series/24694/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/116397/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/116397/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DC721A0032;\n\tFri, 16 Sep 2022 16:01:40 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 86B724021D;\n\tFri, 16 Sep 2022 16:01:40 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 3F0E840156\n for <dev@dpdk.org>; Fri, 16 Sep 2022 16:01:39 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 28GBS8R4032643;\n Fri, 16 Sep 2022 07:01:38 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3jmra0rfnf-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Fri, 16 Sep 2022 07:01:38 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Fri, 16 Sep 2022 07:01:36 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Fri, 16 Sep 2022 07:01:36 -0700", "from localhost.localdomain (unknown [10.28.34.38])\n by maili.marvell.com (Postfix) with ESMTP id 7A1143F70B1;\n Fri, 16 Sep 2022 07:01:34 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=89LxpxQUkzXNV8ocPGWo5qRoH7Gc3psVSdM/y9/A9Lc=;\n b=X2KXnUKes27+z7HIe/bGS1bYOF7KhcggY2c3nzvn1G1AATgWgmEEpTchL+NGVP3kqErn\n dj5hsfA6kZ+XRtXBgvlY5BDNI0mTyMeuUtChsfthWGC7LtKLQpgHo+bdEmumf6kSk7wo\n 9UEedpyFuuLuQRvzGn5G5DJ1R2Pp9C/AvAdlReSRrgupXT+g+8r3nyBNarts531v7TMA\n 3RRqTIexIKlQMN6jT3i91xGgaz6yDIYzOp7iD9N13tITYXTUHCyyLpPZLdFduQSkHsOU\n Ve3AQ3vKYc4YkJLPGbi5AIwpRu4HY/IAJUjIESlkDsA5wlmnT00q6BO5kZW0tV7r+1rP 6w==", "From": "Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "To": "<dev@dpdk.org>", "CC": "Anoob Joseph <anoobj@marvell.com>, Fan Zhang <roy.fan.zhang@intel.com>,\n Brian Dooley <brian.dooley@intel.com>,\n Akhil Goyal <gakhil@marvell.com>, <jerinj@marvell.com>,\n Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>", "Subject": "[v1] examples/fips_validation: fix SHA MCT test from segfault", "Date": "Fri, 16 Sep 2022 19:31:31 +0530", "Message-ID": "\n <cc33a1f1fa1da154bddd019ee5578af7f99df23d.1663336827.git.gmuthukrishn@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "7mYEu412smIO6wydJijZriJ5tg6H4Xj-", "X-Proofpoint-GUID": "7mYEu412smIO6wydJijZriJ5tg6H4Xj-", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1\n definitions=2022-09-16_08,2022-09-16_01,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In case of FIPS 140-2 format of test vectors in MCT test, msg is\nnot given in the test vector, hence pt will be NULL which test\nfunction has to handle correctly.\n\nFixes: d5c247145c2c (\"examples/fips_validation: add parsing for SHA\")\n\nSigned-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>\n---\n examples/fips_validation/main.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c\nindex 8bd5a66889..cab3dd22b9 100644\n--- a/examples/fips_validation/main.c\n+++ b/examples/fips_validation/main.c\n@@ -1696,13 +1696,14 @@ fips_mct_sha_test(void)\n \t/* val[0] is op result and other value is for parse_writeback callback */\n \tstruct fips_val val[2] = {{NULL, 0},};\n \tstruct fips_val md[SHA_MD_BLOCK], msg;\n-\tchar temp[MAX_DIGEST_SIZE*2];\n \tint ret;\n \tuint32_t i, j;\n \n \tmsg.len = SHA_MD_BLOCK * vec.cipher_auth.digest.len;\n \tmsg.val = calloc(1, msg.len);\n-\tmemcpy(vec.cipher_auth.digest.val, vec.pt.val, vec.cipher_auth.digest.len);\n+\tif (vec.pt.val)\n+\t\tmemcpy(vec.cipher_auth.digest.val, vec.pt.val, vec.cipher_auth.digest.len);\n+\n \tfor (i = 0; i < SHA_MD_BLOCK; i++)\n \t\tmd[i].val = rte_malloc(NULL, (MAX_DIGEST_SIZE*2), 0);\n \n@@ -1769,14 +1770,15 @@ fips_mct_sha_test(void)\n \t\tmemcpy(vec.cipher_auth.digest.val, md[2].val, md[2].len);\n \t\tvec.cipher_auth.digest.len = md[2].len;\n \n-\t\tif (info.file_type != FIPS_TYPE_JSON) {\n+\t\tif (info.file_type != FIPS_TYPE_JSON)\n \t\t\tfprintf(info.fp_wr, \"COUNT = %u\\n\", j);\n-\t\t\twriteback_hex_str(\"\", temp, &vec.cipher_auth.digest);\n-\t\t\tfprintf(info.fp_wr, \"MD = %s\\n\\n\", temp);\n-\t\t}\n+\n \t\tval[1].val = msg.val;\n \t\tval[1].len = msg.len;\n \t\tinfo.parse_writeback(val);\n+\n+\t\tif (info.file_type != FIPS_TYPE_JSON)\n+\t\t\tfprintf(info.fp_wr, \"\\n\");\n \t}\n \n \tfor (i = 0; i < (SHA_MD_BLOCK); i++)\n", "prefixes": [ "v1" ] }