Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117135/?format=api
{ "id": 117135, "url": "http://patchwork.dpdk.org/api/patches/117135/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220929120501.428-1-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220929120501.428-1-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220929120501.428-1-olivier.matz@6wind.com", "date": "2022-09-29T12:05:01", "name": "cryptodev: fix unduly newlines in logs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "868ae34b8c873d84c55d7a6fe8b9e5fcb60e231e", "submitter": { "id": 8, "url": "http://patchwork.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220929120501.428-1-olivier.matz@6wind.com/mbox/", "series": [ { "id": 24913, "url": "http://patchwork.dpdk.org/api/series/24913/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=24913", "date": "2022-09-29T12:05:01", "name": "cryptodev: fix unduly newlines in logs", "version": 1, "mbox": "http://patchwork.dpdk.org/series/24913/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/117135/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/117135/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 336ACA00C4;\n\tThu, 29 Sep 2022 14:05:10 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2981440694;\n\tThu, 29 Sep 2022 14:05:10 +0200 (CEST)", "from mail-wr1-f49.google.com (mail-wr1-f49.google.com\n [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id 9217540395\n for <dev@dpdk.org>; Thu, 29 Sep 2022 14:05:08 +0200 (CEST)", "by mail-wr1-f49.google.com with SMTP id v28so1861623wrd.3\n for <dev@dpdk.org>; Thu, 29 Sep 2022 05:05:08 -0700 (PDT)", "from gojira.dev.6wind.com ([185.13.181.2])\n by smtp.gmail.com with ESMTPSA id\n r9-20020adfda49000000b002258235bda3sm6742648wrl.61.2022.09.29.05.05.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Sep 2022 05:05:07 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date;\n bh=czGnXihUVOpY1PZ/OH/7h2bBi8Pf6NTBwZdcFY+NA9k=;\n b=FNzQUNwccnh4IvKLY9Jt+QSeZBs9pp1HHqRu7MMTW2Wj2xX/EtLp3qKvQQrgcaiB77\n p5bRpkufpWZ2jf2BbETUbeM1S8Xo4/HEgqfwoImhZ6ceZEYKOqH8qpaZx9Km2kH8wYrh\n PeKRv4k2/kEY89jMT8NKVH/kZW1N/UIFWr0WK39N0IQ/3m+7r9slk3OI8t4WrIeU/Hc5\n uZY4zXisU9qM6aWBHZJ6DyFJ6uX7uycnxAAtc5zurqNbJ1TOn+ViYP+P8HoWzcF04Rzw\n VIMxIqN/V9U2Uu9FXO7yZsdrQgu6otVGneWK6Ou0SyR0If/6WWj1XuQCVwWdyGgGCTkZ\n DAWw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date;\n bh=czGnXihUVOpY1PZ/OH/7h2bBi8Pf6NTBwZdcFY+NA9k=;\n b=aND1Shl4GtNcHnXHz+ykJevosHd8VNuvfp3XRj8rTjT6U16jMX7wa3nPrKnN45dqU4\n OLHt9TleIRRdwv7HrLTm7n8kyLqVUQn44VcNRvNAm2SqI5lW2i2VxGHkf2ZOic66OKdX\n mBHMLba27iWLYF9XEJy09roUIPGhxZYiw2jn5WhLkpAW3aL6apjY4aek7krpcSUrOwIZ\n fcw2NqoBLwSrxQrbPRptpxPC9ksEHSSdIMxtmc9bxDg7DeypMR3phb2Xq58SvRbxL0oH\n rUbc28378CDJdZG0jJDJblTI6XR95vrYzpN7+/ymy7tCbUdzmZmgwTCoZ+I+xaX3TG5m\n BYjA==", "X-Gm-Message-State": "ACrzQf0xMXQ9GJUNy2rV+BbeYhpTMrTFRfdzVJS3qEh5vL95kJyBl8pV\n 5cmJbN/CX4A3s7GnURIJ5efME99f8hdhUuwj", "X-Google-Smtp-Source": "\n AMsMyM55iYKlABl0BbCIUBPjGbj4rok2mzUUjeVNKY8Ua0addbBclVeuC2gqL/d5kiyZGlLJtGBjsw==", "X-Received": "by 2002:adf:d209:0:b0:228:6298:f288 with SMTP id\n j9-20020adfd209000000b002286298f288mr1976517wrh.386.1664453108348;\n Thu, 29 Sep 2022 05:05:08 -0700 (PDT)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "Akhil Goyal <gakhil@marvell.com>,\n\tFan Zhang <royzhang1980@gmail.com>", "Subject": "[PATCH] cryptodev: fix unduly newlines in logs", "Date": "Thu, 29 Sep 2022 14:05:01 +0200", "Message-Id": "<20220929120501.428-1-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The CDEV_LOG_* macros already add a '\\n' at the end of\nthe line. Remove it from format strings to avoid duplicated\nnewlines.\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n lib/cryptodev/cryptodev_pmd.c | 4 ++--\n lib/cryptodev/cryptodev_pmd.h | 2 +-\n lib/cryptodev/rte_cryptodev.c | 26 +++++++++++++-------------\n 3 files changed, 16 insertions(+), 16 deletions(-)", "diff": "diff --git a/lib/cryptodev/cryptodev_pmd.c b/lib/cryptodev/cryptodev_pmd.c\nindex d90b2570b1..77b269f312 100644\n--- a/lib/cryptodev/cryptodev_pmd.c\n+++ b/lib/cryptodev/cryptodev_pmd.c\n@@ -99,11 +99,11 @@ rte_cryptodev_pmd_create(const char *name,\n \tstruct rte_cryptodev *cryptodev;\n \n \tif (params->name[0] != '\\0') {\n-\t\tCDEV_LOG_INFO(\"User specified device name = %s\\n\", params->name);\n+\t\tCDEV_LOG_INFO(\"User specified device name = %s\", params->name);\n \t\tname = params->name;\n \t}\n \n-\tCDEV_LOG_INFO(\"Creating cryptodev %s\\n\", name);\n+\tCDEV_LOG_INFO(\"Creating cryptodev %s\", name);\n \n \tCDEV_LOG_INFO(\"Initialisation parameters - name: %s,\"\n \t\t\t\"socket id: %d, max queue pairs: %u\",\ndiff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h\nindex 96d7e225b0..09ba952455 100644\n--- a/lib/cryptodev/cryptodev_pmd.h\n+++ b/lib/cryptodev/cryptodev_pmd.h\n@@ -652,7 +652,7 @@ set_sym_session_private_data(struct rte_cryptodev_sym_session *sess,\n \t\tuint8_t driver_id, void *private_data)\n {\n \tif (unlikely(sess->nb_drivers <= driver_id)) {\n-\t\tCDEV_LOG_ERR(\"Set private data for driver %u not allowed\\n\",\n+\t\tCDEV_LOG_ERR(\"Set private data for driver %u not allowed\",\n \t\t\t\tdriver_id);\n \t\treturn;\n \t}\ndiff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c\nindex 5e25e607fa..05d6aa793f 100644\n--- a/lib/cryptodev/rte_cryptodev.c\n+++ b/lib/cryptodev/rte_cryptodev.c\n@@ -1235,13 +1235,13 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,\n \t}\n \n \tif (!qp_conf) {\n-\t\tCDEV_LOG_ERR(\"qp_conf cannot be NULL\\n\");\n+\t\tCDEV_LOG_ERR(\"qp_conf cannot be NULL\");\n \t\treturn -EINVAL;\n \t}\n \n \tif ((qp_conf->mp_session && !qp_conf->mp_session_private) ||\n \t\t\t(!qp_conf->mp_session && qp_conf->mp_session_private)) {\n-\t\tCDEV_LOG_ERR(\"Invalid mempools\\n\");\n+\t\tCDEV_LOG_ERR(\"Invalid mempools\");\n \t\treturn -EINVAL;\n \t}\n \n@@ -1254,7 +1254,7 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,\n \t\tpool_priv = rte_mempool_get_priv(qp_conf->mp_session);\n \t\tif (!pool_priv || qp_conf->mp_session->private_data_size <\n \t\t\t\tsizeof(*pool_priv)) {\n-\t\t\tCDEV_LOG_ERR(\"Invalid mempool\\n\");\n+\t\t\tCDEV_LOG_ERR(\"Invalid mempool\");\n \t\t\treturn -EINVAL;\n \t\t}\n \n@@ -1265,7 +1265,7 @@ rte_cryptodev_queue_pair_setup(uint8_t dev_id, uint16_t queue_pair_id,\n \t\t\tobj_size) || (s.nb_drivers <= dev->driver_id) ||\n \t\t\trte_cryptodev_sym_get_private_session_size(dev_id) >\n \t\t\t\tobj_priv_size) {\n-\t\t\tCDEV_LOG_ERR(\"Invalid mempool\\n\");\n+\t\t\tCDEV_LOG_ERR(\"Invalid mempool\");\n \t\t\treturn -EINVAL;\n \t\t}\n \t}\n@@ -1787,7 +1787,7 @@ rte_cryptodev_sym_session_pool_create(const char *name, uint32_t nb_elts,\n \n \tobj_sz = rte_cryptodev_sym_get_header_session_size() + user_data_size;\n \tif (obj_sz > elt_size)\n-\t\tCDEV_LOG_INFO(\"elt_size %u is expanded to %u\\n\", elt_size,\n+\t\tCDEV_LOG_INFO(\"elt_size %u is expanded to %u\", elt_size,\n \t\t\t\tobj_sz);\n \telse\n \t\tobj_sz = elt_size;\n@@ -1797,14 +1797,14 @@ rte_cryptodev_sym_session_pool_create(const char *name, uint32_t nb_elts,\n \t\t\tNULL, NULL, NULL, NULL,\n \t\t\tsocket_id, 0);\n \tif (mp == NULL) {\n-\t\tCDEV_LOG_ERR(\"%s(name=%s) failed, rte_errno=%d\\n\",\n+\t\tCDEV_LOG_ERR(\"%s(name=%s) failed, rte_errno=%d\",\n \t\t\t__func__, name, rte_errno);\n \t\treturn NULL;\n \t}\n \n \tpool_priv = rte_mempool_get_priv(mp);\n \tif (!pool_priv) {\n-\t\tCDEV_LOG_ERR(\"%s(name=%s) failed to get private data\\n\",\n+\t\tCDEV_LOG_ERR(\"%s(name=%s) failed to get private data\",\n \t\t\t__func__, name);\n \t\trte_mempool_free(mp);\n \t\treturn NULL;\n@@ -1835,7 +1835,7 @@ rte_cryptodev_asym_session_pool_create(const char *name, uint32_t nb_elts,\n \t\t\t\tmax_priv_sz = priv_sz;\n \t\t}\n \tif (max_priv_sz == 0) {\n-\t\tCDEV_LOG_INFO(\"Could not set max private session size\\n\");\n+\t\tCDEV_LOG_INFO(\"Could not set max private session size\");\n \t\treturn NULL;\n \t}\n \n@@ -1848,14 +1848,14 @@ rte_cryptodev_asym_session_pool_create(const char *name, uint32_t nb_elts,\n \t\t\tNULL, NULL, NULL, NULL,\n \t\t\tsocket_id, 0);\n \tif (mp == NULL) {\n-\t\tCDEV_LOG_ERR(\"%s(name=%s) failed, rte_errno=%d\\n\",\n+\t\tCDEV_LOG_ERR(\"%s(name=%s) failed, rte_errno=%d\",\n \t\t\t__func__, name, rte_errno);\n \t\treturn NULL;\n \t}\n \n \tpool_priv = rte_mempool_get_priv(mp);\n \tif (!pool_priv) {\n-\t\tCDEV_LOG_ERR(\"%s(name=%s) failed to get private data\\n\",\n+\t\tCDEV_LOG_ERR(\"%s(name=%s) failed to get private data\",\n \t\t\t__func__, name);\n \t\trte_mempool_free(mp);\n \t\treturn NULL;\n@@ -1902,7 +1902,7 @@ rte_cryptodev_sym_session_create(struct rte_mempool *mp)\n \tstruct rte_cryptodev_sym_session_pool_private_data *pool_priv;\n \n \tif (!rte_cryptodev_sym_is_valid_session_pool(mp)) {\n-\t\tCDEV_LOG_ERR(\"Invalid mempool\\n\");\n+\t\tCDEV_LOG_ERR(\"Invalid mempool\");\n \t\treturn NULL;\n \t}\n \n@@ -1952,7 +1952,7 @@ rte_cryptodev_asym_session_create(uint8_t dev_id,\n \t\treturn -EINVAL;\n \n \tif (!mp) {\n-\t\tCDEV_LOG_ERR(\"invalid mempool\\n\");\n+\t\tCDEV_LOG_ERR(\"invalid mempool\");\n \t\treturn -EINVAL;\n \t}\n \n@@ -2404,7 +2404,7 @@ rte_crypto_op_pool_create(const char *name, enum rte_crypto_op_type type,\n \t\telt_size += RTE_MAX(sizeof(struct rte_crypto_sym_op),\n \t\t sizeof(struct rte_crypto_asym_op));\n \t} else {\n-\t\tCDEV_LOG_ERR(\"Invalid op_type\\n\");\n+\t\tCDEV_LOG_ERR(\"Invalid op_type\");\n \t\treturn NULL;\n \t}\n \n", "prefixes": [] }