Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117138/?format=api
{ "id": 117138, "url": "http://patchwork.dpdk.org/api/patches/117138/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220929120901.639-2-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220929120901.639-2-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220929120901.639-2-olivier.matz@6wind.com", "date": "2022-09-29T12:09:00", "name": "[1/2] net/ixgbe: fix bcast packets Rx on VF after promisc removal", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "12f1ea5461147b880fe858c1929e251f36dee7b0", "submitter": { "id": 8, "url": "http://patchwork.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220929120901.639-2-olivier.matz@6wind.com/mbox/", "series": [ { "id": 24915, "url": "http://patchwork.dpdk.org/api/series/24915/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=24915", "date": "2022-09-29T12:08:59", "name": "net/ixgbe: fixes related to promiscuous mode in VFs", "version": 1, "mbox": "http://patchwork.dpdk.org/series/24915/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/117138/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/117138/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AD7A7A00C4;\n\tThu, 29 Sep 2022 14:09:25 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EFFB4427F5;\n\tThu, 29 Sep 2022 14:09:22 +0200 (CEST)", "from mail-wr1-f48.google.com (mail-wr1-f48.google.com\n [209.85.221.48]) by mails.dpdk.org (Postfix) with ESMTP id BAC2B40694\n for <dev@dpdk.org>; Thu, 29 Sep 2022 14:09:20 +0200 (CEST)", "by mail-wr1-f48.google.com with SMTP id u10so1749885wrq.2\n for <dev@dpdk.org>; Thu, 29 Sep 2022 05:09:20 -0700 (PDT)", "from gojira.dev.6wind.com ([185.13.181.2])\n by smtp.gmail.com with ESMTPSA id\n n14-20020a5d420e000000b0022cc895cc11sm3798999wrq.104.2022.09.29.05.09.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Sep 2022 05:09:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date;\n bh=Yd3RHcszu/6nM65OKeCQZYqrhcUP1PLO5u9JKTD45dU=;\n b=hsYuZ78LfBuMtOzQLz6h6pQ4IVCCg249XHe8Rz8IfhibWITBrs7ErIEn0R6Flrk8KV\n 2bRWoC4m/NjVrKud7tOIoq0ez7N0pbO7AYnuYcPTHmKP9xIEXiZFgUVqnJT6WJtF/TtK\n Ws3l/uYplcX7ggcD3tnFgaIvZ86GATsuWQ1tGBppvXNnWe59AKG6u5Oi1kAbuAbr1rA8\n ozaKvEDMVD8boQi1iqbcB+DUAZLYDjpOiod8WR2MvWbS8QoOtvOR5SEPIbDIcREbgSod\n W4iAXWTJ19OKeiAfF3QwEI2nIHpOD8FBExZ+rrs0W7njEgeAArdPV9wFdOVY1U7K6Q3y\n DKsg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date;\n bh=Yd3RHcszu/6nM65OKeCQZYqrhcUP1PLO5u9JKTD45dU=;\n b=8BqsxNqhNpwfMkrkGIdhY6mch0Ri5cq2pojy0iJoTPavrA7Vb1syNvMGIoUKzOQBfO\n df6DfiwfbrkeaXn1hB+sCG0Ju2YzQun01qX2SNrTpmg8vtQewk7BBqYVOa/1ka9olUqM\n anohUg/Mzu7tC/4ywjVl34jMIBHrBpTyKgwEG2GebeEBgM0ElNqEGov9ER/ZrxLM37dd\n Yz2gdAVakn6wfsUbQ4Yr/xNbRV4SbAb8o68n+QBqSICdC59sVSjuQECLYKwW7ahypo7l\n wY/qqKUurVGKHv39t3RYPF2DghrkA9+/6a6ueguvgnXE6b0kHMaZeAj5fbsS8vjsU2qo\n Rg7A==", "X-Gm-Message-State": "ACrzQf0kSS4WaAOGPZM/rvcBdkVS5Z8pmM14X8q72OKdZqNTndWCjeKC\n d1nYAIy+++mamTVgaLgh67JHCUlxPk/aQ05Y", "X-Google-Smtp-Source": "\n AMsMyM4CRj5pbohHHOD6w//XLCmup8b69tuGrF74IuMwuG7A2HAOPgUsTMrg7qDadoGv2B0e05PbZQ==", "X-Received": "by 2002:a05:6000:982:b0:229:79e5:6a96 with SMTP id\n by2-20020a056000098200b0022979e56a96mr1996197wrb.469.1664453360442;\n Thu, 29 Sep 2022 05:09:20 -0700 (PDT)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "Qiming Yang <qiming.yang@intel.com>, Wenjun Wu <wenjun1.wu@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>, Wei Zhao <wei.zhao1@intel.com>,\n stable@dpdk.org", "Subject": "[PATCH 1/2] net/ixgbe: fix bcast packets Rx on VF after promisc\n removal", "Date": "Thu, 29 Sep 2022 14:09:00 +0200", "Message-Id": "<20220929120901.639-2-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220929120901.639-1-olivier.matz@6wind.com>", "References": "<20220929120901.639-1-olivier.matz@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "After a VF requested to remove the promiscuous flag on an interface, the\nbroadcast packets are not received anymore. This breaks some protocols\nlike ARP.\n\nIn ixgbe_update_vf_xcast_mode(), we should keep the IXGBE_VMOLR_BAM\nbit (Broadcast Accept) on promiscuous removal. This flag is already set\nby default in ixgbe_vf_reset_event() on VF reset.\n\nA similar patch was accepted in Linux kernel (see link).\n\nFixes: 0355c379b71f (\"net/ixgbe: support VF promiscuous by PF driver\")\nLink: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=803e9895ea2b\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n drivers/net/ixgbe/ixgbe_pf.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c\nindex c73833b7ae..c5ef940533 100644\n--- a/drivers/net/ixgbe/ixgbe_pf.c\n+++ b/drivers/net/ixgbe/ixgbe_pf.c\n@@ -747,9 +747,9 @@ ixgbe_set_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)\n \n \tswitch (xcast_mode) {\n \tcase IXGBEVF_XCAST_MODE_NONE:\n-\t\tdisable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE |\n+\t\tdisable = IXGBE_VMOLR_ROMPE |\n \t\t\t IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE;\n-\t\tenable = 0;\n+\t\tenable = IXGBE_VMOLR_BAM;\n \t\tbreak;\n \tcase IXGBEVF_XCAST_MODE_MULTI:\n \t\tdisable = IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE;\n", "prefixes": [ "1/2" ] }