Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117139/?format=api
{ "id": 117139, "url": "http://patchwork.dpdk.org/api/patches/117139/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220929120901.639-3-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220929120901.639-3-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220929120901.639-3-olivier.matz@6wind.com", "date": "2022-09-29T12:09:01", "name": "[2/2] net/ixgbe: fix unexpected VLAN Rx in promisc mode on VF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "281b3f8063747debc7d2f7bd83d78ee0b95b2949", "submitter": { "id": 8, "url": "http://patchwork.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220929120901.639-3-olivier.matz@6wind.com/mbox/", "series": [ { "id": 24915, "url": "http://patchwork.dpdk.org/api/series/24915/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=24915", "date": "2022-09-29T12:08:59", "name": "net/ixgbe: fixes related to promiscuous mode in VFs", "version": 1, "mbox": "http://patchwork.dpdk.org/series/24915/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/117139/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/117139/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 409F6A00C4;\n\tThu, 29 Sep 2022 14:09:31 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D421D42825;\n\tThu, 29 Sep 2022 14:09:23 +0200 (CEST)", "from mail-wm1-f49.google.com (mail-wm1-f49.google.com\n [209.85.128.49]) by mails.dpdk.org (Postfix) with ESMTP id 7AD5E41140\n for <dev@dpdk.org>; Thu, 29 Sep 2022 14:09:21 +0200 (CEST)", "by mail-wm1-f49.google.com with SMTP id\n e10-20020a05600c4e4a00b003b4eff4ab2cso3095043wmq.4\n for <dev@dpdk.org>; Thu, 29 Sep 2022 05:09:21 -0700 (PDT)", "from gojira.dev.6wind.com ([185.13.181.2])\n by smtp.gmail.com with ESMTPSA id\n n14-20020a5d420e000000b0022cc895cc11sm3798999wrq.104.2022.09.29.05.09.20\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Sep 2022 05:09:20 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date;\n bh=UiWXTLHm7wHLigsDLNT/qflXGby4Na9TSGMdETwa7zY=;\n b=HnUQCXoM5Xn+j8FLNHJ+8vstzYDL2y8dABjFyLxVCKGtoaQW4qb+4eX6b2AKn03O1q\n kQrN27C20s9DLSAUqmQOF4sXEcqgvCor4ljbkcufoChYyxnDrU6GMY7SaZK4EuVq5k24\n hteEtvvrac3Gx9HMsVv7pUgX1eW9SfIsQNLv2ZXrRiNIRIFobTF9kAl1PPi3IjaIVLma\n RbbQBazEILyNdjUTVy7NiH04fRXwDD4z1D5xI9ga7g5d6ADczf9DWTxhqmLxD8BK29Ei\n ViX+A6dDkJqsYVbS6UnBlc49LRC61j1+y0zJDjv0eeiL/ht8Miq6oJk1pcUo6+DJMJQf\n jJ7A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date;\n bh=UiWXTLHm7wHLigsDLNT/qflXGby4Na9TSGMdETwa7zY=;\n b=yoTUBkhKD+ATVYRgzG6Z1WehKp1eyvlgqWwL056ZH4+0W3bhXTBav7oYIxrnrrusYG\n ecGzmObgybfkcitQyoio26GBB0M46ftAYO9DjsSsdMQ04FbJlxJ8B8yrk+hNOBdPga5R\n oRXdU6aotkXL5rbvy+aWmdvCkcqNytL0Ss3uSP/0HMpjQokvFEveHlBiKn89qhucVV23\n F9G66yVnEU7qCq7Z5Gj+PLBfJpx6uulloksjL9uLt5OwT8jslldMhWgMGgLSwBtg0B9W\n lV6DDFB6HWJpvAD2NDgHGSIpjJIzz5bMGQEXAGyL+e9cZt837gsjPlixhVCkVcJUaIv+\n /aOg==", "X-Gm-Message-State": "ACrzQf1yLO60baNMMQCQxeUdV+KfiNrvqh8z651H89hFU8ZxxNXR4tgp\n t0jjcKW1Ahwef1H1QVBqPf9Mu8Av4zDLkAIW", "X-Google-Smtp-Source": "\n AMsMyM4pASSw3XxzfzFYIoMJ+ivUpO2QPURBwz92my8RKU43qRiP01Sbr8iGV9dCjuDzap4XwJNvVA==", "X-Received": "by 2002:a05:600c:524d:b0:3b4:91ee:933e with SMTP id\n fc13-20020a05600c524d00b003b491ee933emr2144949wmb.80.1664453361180;\n Thu, 29 Sep 2022 05:09:21 -0700 (PDT)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "Qiming Yang <qiming.yang@intel.com>, Wenjun Wu <wenjun1.wu@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>, Wei Zhao <wei.zhao1@intel.com>,\n stable@dpdk.org", "Subject": "[PATCH 2/2] net/ixgbe: fix unexpected VLAN Rx in promisc mode on VF", "Date": "Thu, 29 Sep 2022 14:09:01 +0200", "Message-Id": "<20220929120901.639-3-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20220929120901.639-1-olivier.matz@6wind.com>", "References": "<20220929120901.639-1-olivier.matz@6wind.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When the promiscuous mode is enabled on a VF, the IXGBE_VMOLR_VPE\nbit (VLAN Promiscuous Enable) is set. This means that the VF will\nreceive packets whose VLAN is not the same as the VLAN of the VF.\n\nFor instance, in this situation:\n\n┌────────┐ ┌────────┐ ┌────────┐\n│ │ │ │ │ │\n│ │ │ │ │ │\n│ VF0├────┤VF1 VF2├────┤VF3 │\n│ │ │ │ │ │\n└────────┘ └────────┘ └────────┘\n VM1 VM2 VM3\n\nvf 0: vlan 1000\nvf 1: vlan 1000\nvf 2: vlan 1001\nvf 3: vlan 1001\n\nIf we tcpdump on VF3, we see all the packets, even those transmitted\non vlan 1000.\n\nThis behavior prevents to bridge VF1 and VF2 in VM2, because it will\ncreate a loop: packets transmitted on VF1 will be received by VF2 and\nvice-versa, and bridged again through the software bridge.\n\nThis patch remove the activation of VLAN Promiscuous when a VF enables\nthe promiscuous mode. However, the IXGBE_VMOLR_UPE bit (Unicast\nPromiscuous) is kept, so that a VF receives all packets that has the\nsame VLAN, whatever the destination MAC address.\n\nA similar patch was accepted in Linux kernel (see link).\n\nFixes: 0355c379b71f (\"net/ixgbe: support VF promiscuous by PF driver\")\nLink: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7bb0fb7c63df\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n drivers/net/ixgbe/ixgbe_pf.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c\nindex c5ef940533..0a0f639e39 100644\n--- a/drivers/net/ixgbe/ixgbe_pf.c\n+++ b/drivers/net/ixgbe/ixgbe_pf.c\n@@ -771,9 +771,9 @@ ixgbe_set_vf_mc_promisc(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf)\n \t\t\treturn -1;\n \t\t}\n \n-\t\tdisable = 0;\n+\t\tdisable = IXGBE_VMOLR_VPE;\n \t\tenable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE |\n-\t\t\t IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE;\n+\t\t\t IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE;\n \t\tbreak;\n \tdefault:\n \t\treturn -1;\n", "prefixes": [ "2/2" ] }