Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117140/?format=api
{ "id": 117140, "url": "http://patchwork.dpdk.org/api/patches/117140/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20220929122155.816-1-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20220929122155.816-1-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20220929122155.816-1-olivier.matz@6wind.com", "date": "2022-09-29T12:21:55", "name": "net/ixgbevf: fix promiscuous and allmulti", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2bea8593826d98dc3073523efb21d63e71da9806", "submitter": { "id": 8, "url": "http://patchwork.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20220929122155.816-1-olivier.matz@6wind.com/mbox/", "series": [ { "id": 24916, "url": "http://patchwork.dpdk.org/api/series/24916/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=24916", "date": "2022-09-29T12:21:55", "name": "net/ixgbevf: fix promiscuous and allmulti", "version": 1, "mbox": "http://patchwork.dpdk.org/series/24916/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/117140/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/117140/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D73D3A00C4;\n\tThu, 29 Sep 2022 14:22:09 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BFE5840694;\n\tThu, 29 Sep 2022 14:22:09 +0200 (CEST)", "from mail-wr1-f41.google.com (mail-wr1-f41.google.com\n [209.85.221.41]) by mails.dpdk.org (Postfix) with ESMTP id 3B0DA40395\n for <dev@dpdk.org>; Thu, 29 Sep 2022 14:22:09 +0200 (CEST)", "by mail-wr1-f41.google.com with SMTP id r6so1911404wru.8\n for <dev@dpdk.org>; Thu, 29 Sep 2022 05:22:09 -0700 (PDT)", "from gojira.dev.6wind.com ([185.13.181.2])\n by smtp.gmail.com with ESMTPSA id\n r9-20020adfda49000000b002258235bda3sm6777219wrl.61.2022.09.29.05.22.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 29 Sep 2022 05:22:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date;\n bh=Zbo6clz1xbdTFlfKjs/cp1Gn4EcEmqPYvc2NJOis0kE=;\n b=XYEqI7ML+VaqGl2zrMqqfpOsBVoexlgb+1bNh+EW0ukmWg/wXgO2gnuTiUGqsWnq5H\n jGe1CPfzLoiks2E0URl/2Lo+Tqcync6TcsO5Thvj9j0Pz0r/zJ6764+WNDYDf4aW6n2P\n gnOsi7OUic+OIZ+UoXn8qiefXY6fwVnGiy2s9k6oJhN7HJs2NAP84YKycieo5gsVmSox\n cJjXkKUBkjYr+g2lDhbEViVIN4+duaRdiunbIiMvdz9rfXSbRNWLiL2joGrH78Z4zuju\n /nbr+yzOl8/BoFFv3xaFk9xK36RXz0+7Oh0kkPOHaI4efFzhsoAhBxhOLlxPltUjQ7UC\n cTMw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date;\n bh=Zbo6clz1xbdTFlfKjs/cp1Gn4EcEmqPYvc2NJOis0kE=;\n b=FjC1/aAmnKqhkvMHaNFjxeANCwOsrtiZFQkxzDdGvhceMS7XeTl3nas81guK2e4UNQ\n 5jOBAsTlYigUAC3C4vWLNwkSxHF7OR0ukwJh3dz3YrX8eNyjyf0VXKf3Pu7xbMa55H1T\n 1KGt1zbIOsmMtuT2WquitEpKcNPSZlEm06mBV2YzXOasNaeUZcCB0azKqWTqYTU1im7I\n RX97XrZAmH/xjTmIjnNGIf9b91IXeNQvIwy0gZ0h5UlXFdpqHrZM9ghT6EXzqCGUgTkv\n jwpoxTMj6X7IfX3O8lMrAio8rW2JgR0jmvYGpNSFd+D5EqsZNq/yGDXw8zlsAwNqNIGQ\n nM/w==", "X-Gm-Message-State": "ACrzQf0mjwCxsMPH9wuF9rUo1V5aXtIuoMgPNO+t9G2c/3czL1IwruSY\n 1OkvZ8zI5wThIfv83jx/gI2m6VqqJ79tgX98", "X-Google-Smtp-Source": "\n AMsMyM6t8CJ0LUTO+JZi8tF8Uk1wMK8Ou0h/SqHx0wn7DADkwId/Mqfof0+SVKceqMrQZ1WirstkjQ==", "X-Received": "by 2002:adf:d209:0:b0:228:6298:f288 with SMTP id\n j9-20020adfd209000000b002286298f288mr2041224wrh.386.1664454128898;\n Thu, 29 Sep 2022 05:22:08 -0700 (PDT)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "Qiming Yang <qiming.yang@intel.com>, Wenjun Wu <wenjun1.wu@intel.com>,\n Wei Zhao <wei.zhao1@intel.com>", "Subject": "[PATCH] net/ixgbevf: fix promiscuous and allmulti", "Date": "Thu, 29 Sep 2022 14:21:55 +0200", "Message-Id": "<20220929122155.816-1-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The configuration of allmulti and promiscuous modes conflicts\ntogether. For instance, if we enable promiscuous mode, then enable and\ndisable allmulti, then the promiscuous mode is wrongly disabled.\n\nFix this behavior by:\n- doing nothing when we set/unset allmulti if promiscuous mode is on\n- restorting the proper mode (none or allmulti) when we disable\n promiscuous mode\n\nFixes: 1f4564ed7696 (\"net/ixgbevf: enable promiscuous mode\")\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n\nHi,\n\nFor reference, this was tested with this plan:\n\necho 8 > \"/sys/bus/pci/devices/0000:01:00.1/sriov_numvfs\"\nip link set dev eno2 up\nip link set dev eno2 promisc on\nbridge link set dev eno2 hwmode veb\nip link set dev eno2 mtu 9000\n\nip link set dev eno2 vf 0 mac ac:1f:6b:fe:ba:b0\nip link set dev eno2 vf 0 spoofchk off\nip link set dev eno2 vf 0 trust on\n\nip link set dev eno2 vf 1 mac ac:1f:6b:fe:ba:b1\nip link set dev eno2 vf 1 spoofchk off\nip link set dev eno2 vf 1 trust on\n\npython3 usertools/dpdk-devbind.py -s\npython3 usertools/dpdk-devbind.py -b vfio-pci 0000:01:10.1 # vf 0\npython3 usertools/dpdk-devbind.py -b ixgbevf 0000:01:10.3 # vf 1\n\n\n# in another terminal\nscapy\nwhile True:\n sendp(Ether(dst='ac:1f:6b:00:00:00'), iface='eno2v1') # wrong mac\n sendp(Ether(dst='ac:1f:6b:fe:ba:b0'), iface='eno2v1') # correct mac\n time.sleep(1)\n\n\n./build/app/dpdk-testpmd -l 1,2 -a 0000:01:10.1 -- -i --total-num-mbufs=32768\nshow port info all\nset fwd rxonly\nset verbose 1\nset promisc all off\nset allmulti all off\nstart\n\n# ok, only packets to dst='ac:1f:6b:fe:ba:b0' are received\n\n\n# ok, both packets are received\nset promisc all on\n\n\n# nok, only packets to dst='ac:1f:6b:fe:ba:b0' are received\nset allmulti all on\nset allmulti all off\n\n\n drivers/net/ixgbe/ixgbe_ethdev.c | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 8cec951d94..cc8383c5a9 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -7785,9 +7785,13 @@ static int\n ixgbevf_dev_promiscuous_disable(struct rte_eth_dev *dev)\n {\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tint mode = IXGBEVF_XCAST_MODE_NONE;\n \tint ret;\n \n-\tswitch (hw->mac.ops.update_xcast_mode(hw, IXGBEVF_XCAST_MODE_NONE)) {\n+\tif (dev->data->all_multicast)\n+\t\tmode = IXGBEVF_XCAST_MODE_ALLMULTI;\n+\n+\tswitch (hw->mac.ops.update_xcast_mode(hw, mode)) {\n \tcase IXGBE_SUCCESS:\n \t\tret = 0;\n \t\tbreak;\n@@ -7809,6 +7813,9 @@ ixgbevf_dev_allmulticast_enable(struct rte_eth_dev *dev)\n \tint ret;\n \tint mode = IXGBEVF_XCAST_MODE_ALLMULTI;\n \n+\tif (dev->data->promiscuous)\n+\t\treturn 0;\n+\n \tswitch (hw->mac.ops.update_xcast_mode(hw, mode)) {\n \tcase IXGBE_SUCCESS:\n \t\tret = 0;\n@@ -7830,6 +7837,9 @@ ixgbevf_dev_allmulticast_disable(struct rte_eth_dev *dev)\n \tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tint ret;\n \n+\tif (dev->data->promiscuous)\n+\t\treturn 0;\n+\n \tswitch (hw->mac.ops.update_xcast_mode(hw, IXGBEVF_XCAST_MODE_MULTI)) {\n \tcase IXGBE_SUCCESS:\n \t\tret = 0;\n", "prefixes": [] }