Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117601/?format=api
{ "id": 117601, "url": "http://patchwork.dpdk.org/api/patches/117601/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20221007174336.54354-22-andrew.boyer@amd.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221007174336.54354-22-andrew.boyer@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221007174336.54354-22-andrew.boyer@amd.com", "date": "2022-10-07T17:43:22", "name": "[21/35] net/ionic: add support for mbuf fast free", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d27da9be729e62485800691f8282d1dee0ca0594", "submitter": { "id": 2861, "url": "http://patchwork.dpdk.org/api/people/2861/?format=api", "name": "Andrew Boyer", "email": "Andrew.Boyer@amd.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20221007174336.54354-22-andrew.boyer@amd.com/mbox/", "series": [ { "id": 25037, "url": "http://patchwork.dpdk.org/api/series/25037/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=25037", "date": "2022-10-07T17:43:01", "name": "net/ionic: updates for 22.11 release", "version": 1, "mbox": "http://patchwork.dpdk.org/series/25037/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/117601/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/117601/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BD010A04FD;\n\tFri, 7 Oct 2022 19:46:45 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 06EF442BA0;\n\tFri, 7 Oct 2022 19:44:58 +0200 (CEST)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2081.outbound.protection.outlook.com [40.107.223.81])\n by mails.dpdk.org (Postfix) with ESMTP id 4635042BC3\n for <dev@dpdk.org>; Fri, 7 Oct 2022 19:44:56 +0200 (CEST)", "from MW4PR03CA0339.namprd03.prod.outlook.com (2603:10b6:303:dc::14)\n by MN0PR12MB6318.namprd12.prod.outlook.com (2603:10b6:208:3c1::17)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28; Fri, 7 Oct\n 2022 17:44:54 +0000", "from CO1NAM11FT068.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:dc:cafe::46) by MW4PR03CA0339.outlook.office365.com\n (2603:10b6:303:dc::14) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.28 via Frontend\n Transport; Fri, 7 Oct 2022 17:44:53 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CO1NAM11FT068.mail.protection.outlook.com (10.13.175.142) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.5709.10 via Frontend Transport; Fri, 7 Oct 2022 17:44:53 +0000", "from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 7 Oct\n 2022 12:44:51 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=fiIKm+AZqH7ywv45iFcu9sIfIb3eox/r7Vmc32RBzv/RL+6aoQeaBpgL9UqjYGMKXmdC/irWiruEe0AaftakTtyVuIcQImukGekZAt+8qvfHLo9j77WcP7xFUSV4ZgwVombCiB9hspmjLDV3DltiGDDukJrQAIqzjNYrNh2IanhA/APgSbeDDdiWyA2tkcqWmm3Bgo7c14fa2qahRPOAswfUZvd7PWDrv6GV5Cc3MaFpb3iy9LtPKuldPokbjsGrghJkXsogfiolGZTAkY5EdJV7hBtE+Gg7xNBtSZM31ot1T6w8gPkVz8UCrr3FIFySEvo4AOK0J5SddA9DRi2Ovg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=+b1E+uDUsWGI/Q6G2fa4WQmHCcxh6U2YHL0jzWNhS4Y=;\n b=DXNLmAxlqYKFND7UCocfWbg/kwT7uME1hrwcuYGoEptqqEV9w5IOP+ZFSjO8G0V60DBgC10L9/FwDPvmFbjG2RxQQs8nWSYc8qJ3dbFVh8fp4jY52+YbnyBcTwJX+8HIfvgUIhLLkGS+AJSMeT/xDDr5bxMru+ubzNTUChKxN+lsDOJIkugD/zKmtChtwH+8hd+NM0dLwPiI+BBLBljxHD0ygGKcbm/BHoPI5bN3VieDQvN1FA/nHuuOw0bCfvdJ8vOZ7/02Skb5i+9egtQ7BJQS6+ro7QD2+MZCHbnBGk+I4YuAXO5/EkmsaX56As12t53vTCwooYaHYPOFdW/6EQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=+b1E+uDUsWGI/Q6G2fa4WQmHCcxh6U2YHL0jzWNhS4Y=;\n b=uW+EacYzIxDqiNu2gmBS9mMivLUDcluQDxBFuAmItMMBqLaMkUAI9AMmLu8YYc0G/P2q0LDIu1GHJXVmqVsk+66GRPaahSFiU5UcfdUsDFGfhUyY4OPuIEsQ9+KjEjMZTIqKQAzP7CBvEfljoVdzCJKfg5qpJHFFr5BWdiJfezY=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Andrew Boyer <andrew.boyer@amd.com>", "To": "<dev@dpdk.org>", "CC": "Andrew Boyer <andrew.boyer@amd.com>", "Subject": "[PATCH 21/35] net/ionic: add support for mbuf fast free", "Date": "Fri, 7 Oct 2022 10:43:22 -0700", "Message-ID": "<20221007174336.54354-22-andrew.boyer@amd.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20221007174336.54354-1-andrew.boyer@amd.com>", "References": "<20221007174336.54354-1-andrew.boyer@amd.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT068:EE_|MN0PR12MB6318:EE_", "X-MS-Office365-Filtering-Correlation-Id": "fb5a63c0-6ec1-44aa-8912-08daa88ba411", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n wXEDeuO/6auzLnCCfdq9TpvsLsrp/yEIZ6nxhEqW224ANz7bWrZIMdQKqr445miFCe6R+Og6bkN1KgHGfFur1cBPPbgDl6GFVH3I2jQq3CvAo8y+SP/OtAzjsI0Jj2x8Bedo5cc5epUvxjZ8B+ITcq0dPoZWdHcvU/GQ5tGOoMqIneqM20gyEIPIYRtSyAAZfCda1yFTaGMXH4vtj5fdjf5U5eFUL1p6dFul21VTA9mMyWKjgSQ6FCtHS0F4TDW4s67njMpZpqS2+wH9KqRzFZ6i0+tqvyPDoH2zGTiKq5KW/TI/VWDEzYaRlPZD83xhdkmCOc5DHGvQBwSFXCanT7X1b0tyMAiZnHxrlScPhV7NSR3QHcJbMmGjfS4q7Ej3/4zT4m3N+9mSzzd8ckm85cEjtmR9c80/CwRit1WgL+Gs946mHwF/sghpVb9eyCq0thyIeMFiFSiGZe2hpbcNdV65x2Y8v1qRNKVZRdamor3GOOZ7VwXjWXbRLO0GakgV1NIceXEEcQBpzSvz+UCrPBRqhJxmFNbKvS5+GBkyQHJfrUIy1OOM8Ue84IbkL7KO4GsMkW8bb1m+/tB4jxBuwfc4esNczRNAyLPbppFPF0kKcjh59wvkioLxUuIlOJVHY5jqSbRQwuWiU1yuW6DVuvgCjW7tLSF4dUV/8hDBLdUvAsUHuZSh8gr07TMg4/IyKPkX4Gq1aTfVqaaewbQvzUXf21sBCBRRI/g2vPR/o0emN6A6FYyM+Z1+9HmA5NCA8A60wS0lwrmGFfwsO9gu22bwVTNF04jRt0SlSb71Z3040xUEWFskajX1nymw4W5I", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230022)(4636009)(396003)(376002)(136003)(39860400002)(346002)(451199015)(40470700004)(46966006)(36840700001)(186003)(40480700001)(36860700001)(356005)(40460700003)(36756003)(70206006)(83380400001)(86362001)(82740400003)(8676002)(6916009)(4326008)(82310400005)(2906002)(26005)(41300700001)(44832011)(316002)(2616005)(8936002)(16526019)(478600001)(426003)(47076005)(81166007)(1076003)(336012)(6666004)(70586007)(5660300002)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "07 Oct 2022 17:44:53.1161 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n fb5a63c0-6ec1-44aa-8912-08daa88ba411", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT068.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN0PR12MB6318", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use a put() rather than a free() in the optimized case.\n\nSigned-off-by: Andrew Boyer <andrew.boyer@amd.com>\n---\n doc/guides/nics/features/ionic.ini | 1 +\n doc/guides/rel_notes/release_22_11.rst | 1 +\n drivers/net/ionic/ionic_ethdev.c | 2 +-\n drivers/net/ionic/ionic_lif.h | 1 +\n drivers/net/ionic/ionic_rxtx.c | 9 ++++++++-\n 5 files changed, 12 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/nics/features/ionic.ini b/doc/guides/nics/features/ionic.ini\nindex 5bd18e39e9..77947bfd22 100644\n--- a/doc/guides/nics/features/ionic.ini\n+++ b/doc/guides/nics/features/ionic.ini\n@@ -7,6 +7,7 @@\n Speed capabilities = Y\n Link status = Y\n Link status event = Y\n+Fast mbuf free = Y\n Queue start/stop = Y\n MTU update = Y\n Scattered Rx = Y\ndiff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst\nindex d7eced510e..0c962f9637 100644\n--- a/doc/guides/rel_notes/release_22_11.rst\n+++ b/doc/guides/rel_notes/release_22_11.rst\n@@ -84,6 +84,7 @@ New Features\n \n * Updated to reflect that Pensando has been acquired by AMD.\n * Enhanced data path to provide substantial performance improvements.\n+ * Added support for mbuf fast free.\n \n Removed Items\n -------------\ndiff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c\nindex 186cde8330..38241d41ec 100644\n--- a/drivers/net/ionic/ionic_ethdev.c\n+++ b/drivers/net/ionic/ionic_ethdev.c\n@@ -396,7 +396,7 @@ ionic_dev_info_get(struct rte_eth_dev *eth_dev,\n \t */\n \n \tdev_info->rx_queue_offload_capa = 0;\n-\tdev_info->tx_queue_offload_capa = 0;\n+\tdev_info->tx_queue_offload_capa = RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;\n \n \t/*\n \t * Per-port capabilities\ndiff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h\nindex b0bd721b06..4fb1f213ff 100644\n--- a/drivers/net/ionic/ionic_lif.h\n+++ b/drivers/net/ionic/ionic_lif.h\n@@ -50,6 +50,7 @@ struct ionic_rx_stats {\n #define IONIC_QCQ_F_CSUM_L3\tBIT(7)\n #define IONIC_QCQ_F_CSUM_UDP\tBIT(8)\n #define IONIC_QCQ_F_CSUM_TCP\tBIT(9)\n+#define IONIC_QCQ_F_FAST_FREE\tBIT(10)\n \n /* Queue / Completion Queue */\n struct ionic_qcq {\ndiff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c\nindex 53b0add228..30f7ce9fc6 100644\n--- a/drivers/net/ionic/ionic_rxtx.c\n+++ b/drivers/net/ionic/ionic_rxtx.c\n@@ -94,6 +94,8 @@ ionic_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id,\n \n \tqinfo->nb_desc = q->num_descs;\n \tqinfo->conf.offloads = dev->data->dev_conf.txmode.offloads;\n+\tif (txq->flags & IONIC_QCQ_F_FAST_FREE)\n+\t\tqinfo->conf.offloads |= RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;\n \tqinfo->conf.tx_deferred_start = txq->flags & IONIC_QCQ_F_DEFERRED;\n }\n \n@@ -136,7 +138,10 @@ ionic_tx_flush(struct ionic_tx_qcq *txq)\n \t\t\t\tif (!txm)\n \t\t\t\t\tbreak;\n \n-\t\t\t\trte_pktmbuf_free_seg(txm);\n+\t\t\t\tif (txq->flags & IONIC_QCQ_F_FAST_FREE)\n+\t\t\t\t\trte_mempool_put(txm->pool, txm);\n+\t\t\t\telse\n+\t\t\t\t\trte_pktmbuf_free_seg(txm);\n \n \t\t\t\tinfo[i] = NULL;\n \t\t\t}\n@@ -240,6 +245,8 @@ ionic_dev_tx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id,\n \t\ttxq->flags |= IONIC_QCQ_F_CSUM_TCP;\n \tif (offloads & RTE_ETH_TX_OFFLOAD_UDP_CKSUM)\n \t\ttxq->flags |= IONIC_QCQ_F_CSUM_UDP;\n+\tif (offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE)\n+\t\ttxq->flags |= IONIC_QCQ_F_FAST_FREE;\n \n \teth_dev->data->tx_queues[tx_queue_id] = txq;\n \n", "prefixes": [ "21/35" ] }