Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117689/?format=api
{ "id": 117689, "url": "http://patchwork.dpdk.org/api/patches/117689/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20221008105353.18195-8-liudongdong3@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221008105353.18195-8-liudongdong3@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221008105353.18195-8-liudongdong3@huawei.com", "date": "2022-10-08T10:53:52", "name": "[v9,7/8] app/procinfo: support descriptor dump", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6415477f87a384273333da80b41bf29233528842", "submitter": { "id": 2718, "url": "http://patchwork.dpdk.org/api/people/2718/?format=api", "name": "Dongdong Liu", "email": "liudongdong3@huawei.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20221008105353.18195-8-liudongdong3@huawei.com/mbox/", "series": [ { "id": 25048, "url": "http://patchwork.dpdk.org/api/series/25048/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=25048", "date": "2022-10-08T10:53:45", "name": "app/procinfo: add some extended features", "version": 9, "mbox": "http://patchwork.dpdk.org/series/25048/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/117689/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/117689/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B341DA0542;\n\tSat, 8 Oct 2022 12:56:29 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0645E42BCE;\n\tSat, 8 Oct 2022 12:55:55 +0200 (CEST)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id B156142BA0\n for <dev@dpdk.org>; Sat, 8 Oct 2022 12:55:51 +0200 (CEST)", "from kwepemi500017.china.huawei.com (unknown [172.30.72.53])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Ml26J4Tyhz1P6gY;\n Sat, 8 Oct 2022 18:51:20 +0800 (CST)", "from localhost.localdomain (10.28.79.22) by\n kwepemi500017.china.huawei.com (7.221.188.110) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2375.31; Sat, 8 Oct 2022 18:55:49 +0800" ], "From": "Dongdong Liu <liudongdong3@huawei.com>", "To": "<dev@dpdk.org>, <reshma.pattan@intel.com>, <thomas@monjalon.net>,\n <ferruh.yigit@xilinx.com>, <andrew.rybchenko@oktetlabs.ru>", "CC": "Dongdong Liu <liudongdong3@huawei.com>, Min Hu <humin29@huawei.com>,\n Maryam Tahhan <maryam.tahhan@intel.com>", "Subject": "[PATCH v9 7/8] app/procinfo: support descriptor dump", "Date": "Sat, 8 Oct 2022 18:53:52 +0800", "Message-ID": "<20221008105353.18195-8-liudongdong3@huawei.com>", "X-Mailer": "git-send-email 2.22.0", "In-Reply-To": "<20221008105353.18195-1-liudongdong3@huawei.com>", "References": "<20220722091236.15469-1-liudongdong3@huawei.com>\n <20221008105353.18195-1-liudongdong3@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.28.79.22]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemi500017.china.huawei.com (7.221.188.110)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch support Rx/Tx descriptor dump\n\nThe command is like:\ndpdk-proc-info -a xxxx:xx:xx.x --file-prefix=xxx --\n--show-rx-descriptor queue_id:offset:num\n\ndpdk-proc-info -a xxxx:xx:xx.x --file-prefix=xxx --\n--show-tx-descriptor queue_id:offset:num\n\nqueue_id: A queue identifier on this port.\noffset: The offset of the descriptor starting from tail.\nnum: The number of the descriptors to dump.\n\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n app/proc-info/main.c | 80 ++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 80 insertions(+)", "diff": "diff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex fe8285d2ce..3ab97a0127 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -54,6 +54,9 @@\n #define STATS_BDR_STR(w, s) printf(\"%.*s%s%.*s\\n\", w, \\\n \tSTATS_BDR_FMT, s, w, STATS_BDR_FMT)\n \n+typedef int (*desc_dump_t)(uint16_t port_id, uint16_t queue_id,\n+\t\t\t uint16_t offset, uint16_t num, FILE *file);\n+\n /* mask of enabled ports */\n static unsigned long enabled_port_mask;\n /* Enable stats. */\n@@ -117,6 +120,21 @@ static uint32_t enable_shw_rss_reta;\n /* Enable show module eeprom information. */\n static uint32_t enable_shw_module_eeprom;\n \n+/* Enable dump Rx/Tx descriptor. */\n+static uint32_t enable_shw_rx_desc_dump;\n+static uint32_t enable_shw_tx_desc_dump;\n+\n+#define DESC_PARAM_NUM 3\n+\n+struct desc_param {\n+\tuint16_t queue_id; /* A queue identifier on this port. */\n+\tuint16_t offset; /* The offset of the descriptor starting from tail. */\n+\tuint16_t num; /* The number of the descriptors to dump. */\n+};\n+\n+static struct desc_param rx_desc_param;\n+static struct desc_param tx_desc_param;\n+\n /* display usage */\n static void\n proc_info_usage(const char *prgname)\n@@ -148,6 +166,14 @@ proc_info_usage(const char *prgname)\n \t\t\" --firmware-version: to display ethdev firmware version\\n\"\n \t\t\" --show-rss-reta: to display ports redirection table\\n\"\n \t\t\" --show-module-eeprom: to display ports module eeprom information\\n\"\n+\t\t\" --show-rx-descriptor queue_id:offset:num to display ports Rx descriptor information. \"\n+\t\t\t\"queue_id: A Rx queue identifier on this port. \"\n+\t\t\t\"offset: The offset of the descriptor starting from tail. \"\n+\t\t\t\"num: The number of the descriptors to dump.\\n\"\n+\t\t\" --show-tx-descriptor queue_id:offset:num to display ports Tx descriptor information. \"\n+\t\t\t\"queue_id: A Tx queue identifier on this port. \"\n+\t\t\t\"offset: The offset of the descriptor starting from tail. \"\n+\t\t\t\"num: The number of the descriptors to dump.\\n\"\n \t\t\" --iter-mempool=name: iterate mempool elements to display content\\n\"\n \t\t\" --dump-regs=file-prefix: dump registers to file with the file-prefix\\n\",\n \t\tprgname);\n@@ -200,6 +226,19 @@ parse_xstats_ids(char *list, uint64_t *ids, int limit) {\n \treturn length;\n }\n \n+static int\n+parse_descriptor_param(char *list, struct desc_param *desc)\n+{\n+\tint ret;\n+\n+\tret = sscanf(list, \"%hu:%hu:%hu\", &desc->queue_id, &desc->offset,\n+\t\t &desc->num);\n+\tif (ret != DESC_PARAM_NUM)\n+\t\treturn -EINVAL;\n+\n+\treturn 0;\n+}\n+\n static int\n proc_info_preparse_args(int argc, char **argv)\n {\n@@ -264,6 +303,8 @@ proc_info_parse_args(int argc, char **argv)\n \t\t{\"firmware-version\", 0, NULL, 0},\n \t\t{\"show-rss-reta\", 0, NULL, 0},\n \t\t{\"show-module-eeprom\", 0, NULL, 0},\n+\t\t{\"show-rx-descriptor\", required_argument, NULL, 1},\n+\t\t{\"show-tx-descriptor\", required_argument, NULL, 1},\n \t\t{NULL, 0, 0, 0}\n \t};\n \n@@ -367,6 +408,24 @@ proc_info_parse_args(int argc, char **argv)\n \t\t\t\t\treturn -1;\n \t\t\t\t}\n \t\t\t\tnb_xstats_ids = ret;\n+\t\t\t} else if (!strncmp(long_option[option_index].name,\n+\t\t\t\t\"show-rx-descriptor\", MAX_LONG_OPT_SZ)) {\n+\t\t\t\tint ret = parse_descriptor_param(optarg,\n+\t\t\t\t\t\t\t&rx_desc_param);\n+\t\t\t\tif (ret < 0) {\n+\t\t\t\t\tprintf(\"Rx descriptor param parse error.\\n\");\n+\t\t\t\t\treturn -1;\n+\t\t\t\t}\n+\t\t\t\tenable_shw_rx_desc_dump = 1;\n+\t\t\t} else if (!strncmp(long_option[option_index].name,\n+\t\t\t\t\"show-tx-descriptor\", MAX_LONG_OPT_SZ)) {\n+\t\t\t\tint ret = parse_descriptor_param(optarg,\n+\t\t\t\t\t\t\t&tx_desc_param);\n+\t\t\t\tif (ret < 0) {\n+\t\t\t\t\tprintf(\"Tx descriptor param parse error.\\n\");\n+\t\t\t\t\treturn -1;\n+\t\t\t\t}\n+\t\t\t\tenable_shw_tx_desc_dump = 1;\n \t\t\t}\n \t\t\tbreak;\n \t\tdefault:\n@@ -1644,6 +1703,21 @@ show_module_eeprom_info(void)\n \t}\n }\n \n+static void\n+nic_descriptor_display(uint16_t port_id, struct desc_param *desc,\n+\t\t desc_dump_t desc_dump)\n+{\n+\tstatic const char *nic_desc_border = \"###\";\n+\tuint16_t queue_id = desc->queue_id;\n+\tuint16_t offset = desc->offset;\n+\tuint16_t num = desc->num;\n+\n+\tprintf(\"%s NIC descriptor for port %u %s\\n\",\n+\t\t nic_desc_border, port_id, nic_desc_border);\n+\n+\tdesc_dump(port_id, queue_id, offset, num, stdout);\n+}\n+\n int\n main(int argc, char **argv)\n {\n@@ -1732,6 +1806,12 @@ main(int argc, char **argv)\n \t\t\tmetrics_display(i);\n #endif\n \n+\t\tif (enable_shw_rx_desc_dump)\n+\t\t\tnic_descriptor_display(i, &rx_desc_param,\n+\t\t\t\t\t rte_eth_rx_descriptor_dump);\n+\t\tif (enable_shw_tx_desc_dump)\n+\t\t\tnic_descriptor_display(i, &tx_desc_param,\n+\t\t\t\t\t rte_eth_tx_descriptor_dump);\n \t}\n \n #ifdef RTE_LIB_METRICS\n", "prefixes": [ "v9", "7/8" ] }