Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/117910/?format=api
{ "id": 117910, "url": "http://patchwork.dpdk.org/api/patches/117910/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20221011120135.45846-3-ndabilpuram@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221011120135.45846-3-ndabilpuram@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221011120135.45846-3-ndabilpuram@marvell.com", "date": "2022-10-11T12:01:25", "name": "[03/13] net/cnxk: fix later skip to include mbuf priv", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9b47e3d69c4bcef697161bea9b7e8b31f38e7038", "submitter": { "id": 1202, "url": "http://patchwork.dpdk.org/api/people/1202/?format=api", "name": "Nithin Dabilpuram", "email": "ndabilpuram@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20221011120135.45846-3-ndabilpuram@marvell.com/mbox/", "series": [ { "id": 25145, "url": "http://patchwork.dpdk.org/api/series/25145/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=25145", "date": "2022-10-11T12:01:23", "name": "[01/13] common/cnxk: set MTU size on SDP based on SoC type", "version": 1, "mbox": "http://patchwork.dpdk.org/series/25145/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/117910/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/117910/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9A1DAA0545;\n\tTue, 11 Oct 2022 14:01:54 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A07D542DC1;\n\tTue, 11 Oct 2022 14:01:51 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 58B8542D42;\n Tue, 11 Oct 2022 14:01:49 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id\n 29BA3Alj015818;\n Tue, 11 Oct 2022 05:01:48 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3k40g4y26s-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 11 Oct 2022 05:01:48 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Tue, 11 Oct 2022 05:01:46 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Tue, 11 Oct 2022 05:01:46 -0700", "from localhost.localdomain (unknown [10.29.52.204])\n by maili.marvell.com (Postfix) with ESMTP id 202813F7040;\n Tue, 11 Oct 2022 05:01:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=Ntc489pNC7JjSUMQoYBkkzSAzqmE6yJxhwiU9B1tDrk=;\n b=RQxUaJrVTYcMb8DOsc2+nwHgm022PU6QCLLLg2Vjw8KjxP4jRBxy6sGDwvHJWeeSEuEl\n oUsyW4wMewM12kfJtyeYqItiOxI3zWyt0shku/EgL3LKj7V4oinc5wkTNKdseu6IkvEQ\n 4Dg23ivtLzf18pwDHi3PAsP1qw672YcXmkUKmH98wGcUuZtH1cSUMlK970uTkPFlfTXa\n m1Y31WwK53bE100kz/d2UA6KhK0uTIypq9lq25rmxnYul9MssjsX05FYwiUFVSin/SJc\n veUJhm6NOybAJq0vbrEpW+D3qEtMh1/ocKzUnqdb+nqGbDhGStuIQy1PJzdzgc41iaNl LA==", "From": "Nithin Dabilpuram <ndabilpuram@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<jerinj@marvell.com>, <dev@dpdk.org>, <stable@dpdk.org>", "Subject": "[PATCH 03/13] net/cnxk: fix later skip to include mbuf priv", "Date": "Tue, 11 Oct 2022 17:31:25 +0530", "Message-ID": "<20221011120135.45846-3-ndabilpuram@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20221011120135.45846-1-ndabilpuram@marvell.com>", "References": "<20221011120135.45846-1-ndabilpuram@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "FclyulrGNngZApqFW869Mt1X_G4fRPVO", "X-Proofpoint-GUID": "FclyulrGNngZApqFW869Mt1X_G4fRPVO", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1\n definitions=2022-10-11_07,2022-10-11_02,2022-06-22_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix later skip to include mbuf priv data as mbuf->buf_addr\nis populated based on calculation including per-mbuf priv area.\n\nFixes: 706eeae60757 (\"net/cnxk: add multi-segment Rx for CN10K\")\ncc: stable@dpdk.org\n\nSigned-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>\n---\n drivers/net/cnxk/cn10k_rx.h | 4 +++-\n drivers/net/cnxk/cnxk_ethdev.c | 2 +-\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/cnxk/cn10k_rx.h b/drivers/net/cnxk/cn10k_rx.h\nindex 46488d442e..cf390a0361 100644\n--- a/drivers/net/cnxk/cn10k_rx.h\n+++ b/drivers/net/cnxk/cn10k_rx.h\n@@ -682,6 +682,7 @@ nix_cqe_xtract_mseg(const union nix_rx_parse_u *rx, struct rte_mbuf *mbuf,\n \t\t uint64_t rearm, const uint16_t flags)\n {\n \tconst rte_iova_t *iova_list;\n+\tuint16_t later_skip = 0;\n \tstruct rte_mbuf *head;\n \tconst rte_iova_t *eol;\n \tuint8_t nb_segs;\n@@ -720,10 +721,11 @@ nix_cqe_xtract_mseg(const union nix_rx_parse_u *rx, struct rte_mbuf *mbuf,\n \tnb_segs--;\n \n \trearm = rearm & ~0xFFFF;\n+\tlater_skip = (uintptr_t)mbuf->buf_addr - (uintptr_t)mbuf;\n \n \thead = mbuf;\n \twhile (nb_segs) {\n-\t\tmbuf->next = ((struct rte_mbuf *)*iova_list) - 1;\n+\t\tmbuf->next = (struct rte_mbuf *)(*iova_list - later_skip);\n \t\tmbuf = mbuf->next;\n \n \t\tRTE_MEMPOOL_CHECK_COOKIES(mbuf->pool, (void **)&mbuf, 1, 1);\ndiff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c\nindex 2cb48ba152..8fe996b2d9 100644\n--- a/drivers/net/cnxk/cnxk_ethdev.c\n+++ b/drivers/net/cnxk/cnxk_ethdev.c\n@@ -620,7 +620,7 @@ cnxk_nix_rx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t qid,\n \tfirst_skip += RTE_PKTMBUF_HEADROOM;\n \tfirst_skip += rte_pktmbuf_priv_size(mp);\n \trq->first_skip = first_skip;\n-\trq->later_skip = sizeof(struct rte_mbuf);\n+\trq->later_skip = sizeof(struct rte_mbuf) + rte_pktmbuf_priv_size(mp);\n \trq->lpb_size = mp->elt_size;\n \tif (roc_errata_nix_no_meta_aura())\n \t\trq->lpb_drop_ena = !(dev->rx_offloads & RTE_ETH_RX_OFFLOAD_SECURITY);\n", "prefixes": [ "03/13" ] }