Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118073/?format=api
{ "id": 118073, "url": "http://patchwork.dpdk.org/api/patches/118073/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20221012144704.77973-1-markus.theil@tu-ilmenau.de/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221012144704.77973-1-markus.theil@tu-ilmenau.de>", "list_archive_url": "https://inbox.dpdk.org/dev/20221012144704.77973-1-markus.theil@tu-ilmenau.de", "date": "2022-10-12T14:47:03", "name": "[1/2] build: allow to conditionally build apps", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b17bfff9867692ac2b2bd7316afedf8606bea2ac", "submitter": { "id": 747, "url": "http://patchwork.dpdk.org/api/people/747/?format=api", "name": "Markus Theil", "email": "markus.theil@tu-ilmenau.de" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20221012144704.77973-1-markus.theil@tu-ilmenau.de/mbox/", "series": [ { "id": 25189, "url": "http://patchwork.dpdk.org/api/series/25189/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=25189", "date": "2022-10-12T14:47:03", "name": "[1/2] build: allow to conditionally build apps", "version": 1, "mbox": "http://patchwork.dpdk.org/series/25189/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/118073/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/118073/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 87C1EA0543;\n\tWed, 12 Oct 2022 16:47:09 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3CBEA43027;\n\tWed, 12 Oct 2022 16:47:09 +0200 (CEST)", "from smail.rz.tu-ilmenau.de (smail.rz.tu-ilmenau.de [141.24.186.67])\n by mails.dpdk.org (Postfix) with ESMTP id AB97442EF7\n for <dev@dpdk.org>; Wed, 12 Oct 2022 16:47:07 +0200 (CEST)", "from localhost.localdomain (dialin-ip-23-165.ilmenau.net\n [80.88.23.165])\n by smail.rz.tu-ilmenau.de (Postfix) with ESMTPA id 55CF0580098;\n Wed, 12 Oct 2022 16:47:07 +0200 (CEST)" ], "From": "Markus Theil <markus.theil@tu-ilmenau.de>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Markus Theil <markus.theil@tu-ilmenau.de>", "Subject": "[PATCH 1/2] build: allow to conditionally build apps", "Date": "Wed, 12 Oct 2022 16:47:03 +0200", "Message-Id": "<20221012144704.77973-1-markus.theil@tu-ilmenau.de>", "X-Mailer": "git-send-email 2.38.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Makes apps configureable from meson, like already\npossible for drivers.\n\nSigned-off-by: Markus Theil <markus.theil@tu-ilmenau.de>\n---\n app/meson.build | 17 ++++++++++++-----\n meson_options.txt | 4 ++++\n 2 files changed, 16 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/meson.build b/app/meson.build\nindex 93d8c15032..4d9c8ee814 100644\n--- a/app/meson.build\n+++ b/app/meson.build\n@@ -1,6 +1,9 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017-2019 Intel Corporation\n \n+enabled_apps = get_option('enable_apps')\n+disabled_apps = get_option('disable_apps')\n+\n apps = [\n 'dumpcap',\n 'pdump',\n@@ -27,7 +30,11 @@ if get_option('default_library') == 'static' and not is_windows\n endif\n \n foreach app:apps\n- build = true\n+ build = enabled_apps == '' or enabled_apps.contains(app)\n+ # let disabled_apps override enabled_apps\n+ if disabled_apps != ''\n+ build = build and not disabled_apps.contains(app)\n+ endif\n name = app\n sources = []\n includes = []\n@@ -41,6 +48,10 @@ foreach app:apps\n ext_deps = []\n deps = []\n \n+ if not build\n+ continue\n+ endif\n+\n subdir(name)\n \n if build\n@@ -56,10 +67,6 @@ foreach app:apps\n endforeach\n endif\n \n- if not build\n- continue\n- endif\n-\n link_libs = []\n if get_option('default_library') == 'static'\n link_libs = dpdk_static_libraries + dpdk_drivers\ndiff --git a/meson_options.txt b/meson_options.txt\nindex 0574dd0fff..9f032d454d 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -6,6 +6,8 @@ option('cpu_instruction_set', type: 'string', value: 'auto',\n \tdescription: 'Set the target machine ISA (instruction set architecture). Will be set according to the platform option by default.')\n option('developer_mode', type: 'feature', description:\n 'turn on additional build checks relevant for DPDK developers')\n+option('disable_apps', type: 'string', value: '', description:\n+ 'Comma-separated list of apps to explicitly disable.')\n option('disable_drivers', type: 'string', value: '', description:\n 'Comma-separated list of drivers to explicitly disable.')\n option('disable_libs', type: 'string', value: 'kni', description:\n@@ -14,6 +16,8 @@ option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>', d\n 'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.')\n option('enable_docs', type: 'boolean', value: false, description:\n 'build documentation')\n+option('enable_apps', type: 'string', value: '', description:\n+ 'Comma-separated list of apps to build. If unspecified, build all apps.')\n option('enable_drivers', type: 'string', value: '', description:\n 'Comma-separated list of drivers to build. If unspecified, build all drivers.')\n option('enable_driver_sdk', type: 'boolean', value: false, description:\n", "prefixes": [ "1/2" ] }