Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/118224/?format=api
http://patchwork.dpdk.org/api/patches/118224/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20221014203325.32418-1-arshdeep.kaur@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221014203325.32418-1-arshdeep.kaur@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221014203325.32418-1-arshdeep.kaur@intel.com", "date": "2022-10-14T20:33:25", "name": "[v1] dumpcap: fix select interface", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e4cdf4435fe10f70d496d80d27c75fe6996f2ee2", "submitter": { "id": 2844, "url": "http://patchwork.dpdk.org/api/people/2844/?format=api", "name": "Kaur, Arshdeep", "email": "arshdeep.kaur@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20221014203325.32418-1-arshdeep.kaur@intel.com/mbox/", "series": [ { "id": 25239, "url": "http://patchwork.dpdk.org/api/series/25239/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=25239", "date": "2022-10-14T20:33:25", "name": "[v1] dumpcap: fix select interface", "version": 1, "mbox": "http://patchwork.dpdk.org/series/25239/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/118224/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/118224/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 576FEA00C2;\n\tFri, 14 Oct 2022 22:35:01 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E59CA400D4;\n\tFri, 14 Oct 2022 22:35:00 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 32C7C4003C\n for <dev@dpdk.org>; Fri, 14 Oct 2022 22:34:58 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Oct 2022 13:34:55 -0700", "from unknown (HELO skx-5gnr-sd6.localdomain) ([10.233.180.92])\n by orsmga007.jf.intel.com with ESMTP; 14 Oct 2022 13:34:54 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1665779699; x=1697315699;\n h=from:to:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=fBT7MS0Kx2GMjLzu0UDGQtCVg6GwMY0nsyYhpxWSk/o=;\n b=MT0sbLKcNsASCxA7zefdhCJFoU/Zdgwyvi2+s5V7M+WMT+cnrkAh9QbF\n KylfB9ssj5smGcN1X9rZ8J/ENcMC6X2tBpVvneARnVP60k/WU1n0yQE/r\n Zd1s9PKEOg1hUMgEqHnGZpn0H95YQsiq+1b5kyfM0k9pPVI+RiNL6GTi6\n gx7DvZKxpn445PT8vT2qlcXSscPPN/WZUuMpfjXcPFTy4SusLWLD1/jMW\n WZTe20kCS2KXfGErHKsusJbL3WhwRFOo3/rDbWrbr1e5xtIBk0ttijzjj\n xxDJkvWlI+xORPVx+SeIplkzQWyXtn6nILyZ8nwa2TC90ceYImMViztbL w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10500\"; a=\"285857248\"", "E=Sophos;i=\"5.95,185,1661842800\"; d=\"scan'208\";a=\"285857248\"", "E=McAfee;i=\"6500,9779,10500\"; a=\"622650099\"", "E=Sophos;i=\"5.95,185,1661842800\"; d=\"scan'208\";a=\"622650099\"" ], "X-ExtLoop1": "1", "From": "Arshdeep Kaur <arshdeep.kaur@intel.com>", "To": "dev@dpdk.org", "Subject": "[PATCH v1] dumpcap: fix select interface", "Date": "Fri, 14 Oct 2022 13:33:25 -0700", "Message-Id": "<20221014203325.32418-1-arshdeep.kaur@intel.com>", "X-Mailer": "git-send-email 2.37.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The change to do argument process before EAL init broke\nthe support of select-interface option. Fix by setting flag\nand doing select-interface later.\n\nFixes: cbb44143be74 (\"app/dumpcap: add new packet capture application\")\n\nSigned-off-by: Arshdeep Kaur <arshdeep.kaur@intel.com>\n---\n app/dumpcap/main.c | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c\nindex e0a3477d91..11a44ecce4 100644\n--- a/app/dumpcap/main.c\n+++ b/app/dumpcap/main.c\n@@ -64,6 +64,8 @@ static const char *capture_comment;\n static uint32_t snaplen = RTE_MBUF_DEFAULT_BUF_SIZE;\n static bool dump_bpf;\n static bool show_interfaces;\n+static bool select_interfaces;\n+const char *interface_arg;\n \n static struct {\n \tuint64_t duration;\t/* nanoseconds */\n@@ -370,7 +372,8 @@ static void parse_opts(int argc, char **argv)\n \t\t\tusage();\n \t\t\texit(0);\n \t\tcase 'i':\n-\t\t\tselect_interface(optarg);\n+\t\t\tselect_interfaces = true;\n+\t\t\tinterface_arg = optarg;\n \t\t\tbreak;\n \t\tcase 'n':\n \t\t\tuse_pcapng = true;\n@@ -796,6 +799,9 @@ int main(int argc, char **argv)\n \tif (rte_eth_dev_count_avail() == 0)\n \t\trte_exit(EXIT_FAILURE, \"No Ethernet ports found\\n\");\n \n+\tif (select_interface)\n+\t\tselect_interface(interface_arg);\n+\n \tif (filter_str)\n \t\tcompile_filter();\n \n", "prefixes": [ "v1" ] }{ "id": 118224, "url": "