Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/119200/?format=api
{ "id": 119200, "url": "http://patchwork.dpdk.org/api/patches/119200/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20221027054505.1369248-6-junfeng.guo@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20221027054505.1369248-6-junfeng.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20221027054505.1369248-6-junfeng.guo@intel.com", "date": "2022-10-27T05:44:52", "name": "[v13,05/18] net/idpf: add support for device start and stop", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "aa9b5aed172d903f3aa52c162366263beb0fc4ea", "submitter": { "id": 1785, "url": "http://patchwork.dpdk.org/api/people/1785/?format=api", "name": "Junfeng Guo", "email": "junfeng.guo@intel.com" }, "delegate": { "id": 3961, "url": "http://patchwork.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20221027054505.1369248-6-junfeng.guo@intel.com/mbox/", "series": [ { "id": 25450, "url": "http://patchwork.dpdk.org/api/series/25450/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=25450", "date": "2022-10-27T05:44:47", "name": "add support for idpf PMD in DPDK", "version": 13, "mbox": "http://patchwork.dpdk.org/series/25450/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/119200/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/119200/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0D0CFA00C5;\n\tThu, 27 Oct 2022 07:47:33 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B284442BDF;\n\tThu, 27 Oct 2022 07:47:06 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 3BA2942B9D\n for <dev@dpdk.org>; Thu, 27 Oct 2022 07:47:02 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Oct 2022 22:47:01 -0700", "from dpdk-jf-ntb-one.sh.intel.com ([10.67.111.104])\n by orsmga003.jf.intel.com with ESMTP; 26 Oct 2022 22:46:59 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1666849622; x=1698385622;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=eSLwv/X8Htsh516ovsOtWiC+vH3TE76BlAeLa2Y9bdE=;\n b=gDB/VJkGOeIVHYehctMmyHiTLj6DiU/nLQVU8T/et3xw4YtW0OGh1UqF\n RzGg42JdKRzrUV3pCyY1DvTVOKpOFkLtxXCOiZRPGVofajRyR3K27V10b\n ++OkuRePdR+PHpXUEpDtxoluiuSLd8y8IMCUR8Ipxi92T4nNFEYfEAcDy\n li85YLhWli/VBt2JV2QeVj/P/F7qJC3f4wks3MHVLCCO59ws0y94oa/aT\n 1iKLwqFT2pNJ4Vrpx0hiwGGVOY2yTbmgiopFbluOwDz9kJSLWpiMFdz86\n 19k59NGRBJlZfD/GbVGUKeESf7tlUg+w2Gex5enE4qmaUzOIUJMODLS5l g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10512\"; a=\"309831061\"", "E=Sophos;i=\"5.95,215,1661842800\"; d=\"scan'208\";a=\"309831061\"", "E=McAfee;i=\"6500,9779,10512\"; a=\"583429229\"", "E=Sophos;i=\"5.95,215,1661842800\"; d=\"scan'208\";a=\"583429229\"" ], "X-ExtLoop1": "1", "From": "Junfeng Guo <junfeng.guo@intel.com>", "To": "andrew.rybchenko@oktetlabs.ru, qi.z.zhang@intel.com,\n jingjing.wu@intel.com,\n beilei.xing@intel.com", "Cc": "dev@dpdk.org, Junfeng Guo <junfeng.guo@intel.com>,\n Xiaoyun Li <xiaoyun.li@intel.com>", "Subject": "[PATCH v13 05/18] net/idpf: add support for device start and stop", "Date": "Thu, 27 Oct 2022 13:44:52 +0800", "Message-Id": "<20221027054505.1369248-6-junfeng.guo@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221027054505.1369248-1-junfeng.guo@intel.com>", "References": "<20221026101027.240583-2-junfeng.guo@intel.com>\n <20221027054505.1369248-1-junfeng.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add dev ops dev_start, dev_stop and link_update.\n\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\nSigned-off-by: Xiaoyun Li <xiaoyun.li@intel.com>\nSigned-off-by: Junfeng Guo <junfeng.guo@intel.com>\n---\n drivers/net/idpf/idpf_ethdev.c | 55 ++++++++++++++++++++++++++++++++++\n drivers/net/idpf/idpf_rxtx.c | 20 +++++++++++++\n 2 files changed, 75 insertions(+)", "diff": "diff --git a/drivers/net/idpf/idpf_ethdev.c b/drivers/net/idpf/idpf_ethdev.c\nindex 0585153f69..3430d00e92 100644\n--- a/drivers/net/idpf/idpf_ethdev.c\n+++ b/drivers/net/idpf/idpf_ethdev.c\n@@ -30,17 +30,38 @@ static const char * const idpf_valid_args[] = {\n };\n \n static int idpf_dev_configure(struct rte_eth_dev *dev);\n+static int idpf_dev_start(struct rte_eth_dev *dev);\n+static int idpf_dev_stop(struct rte_eth_dev *dev);\n static int idpf_dev_close(struct rte_eth_dev *dev);\n static int idpf_dev_info_get(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_dev_info *dev_info);\n static void idpf_adapter_rel(struct idpf_adapter *adapter);\n \n+static int\n+idpf_dev_link_update(struct rte_eth_dev *dev,\n+\t\t __rte_unused int wait_to_complete)\n+{\n+\tstruct rte_eth_link new_link;\n+\n+\tmemset(&new_link, 0, sizeof(new_link));\n+\n+\tnew_link.link_speed = RTE_ETH_SPEED_NUM_NONE;\n+\tnew_link.link_duplex = RTE_ETH_LINK_FULL_DUPLEX;\n+\tnew_link.link_autoneg = !(dev->data->dev_conf.link_speeds &\n+\t\t\t\t RTE_ETH_LINK_SPEED_FIXED);\n+\n+\treturn rte_eth_linkstatus_set(dev, &new_link);\n+}\n+\n static const struct eth_dev_ops idpf_eth_dev_ops = {\n \t.dev_configure\t\t\t= idpf_dev_configure,\n+\t.dev_start\t\t\t= idpf_dev_start,\n+\t.dev_stop\t\t\t= idpf_dev_stop,\n \t.dev_close\t\t\t= idpf_dev_close,\n \t.rx_queue_setup\t\t\t= idpf_rx_queue_setup,\n \t.tx_queue_setup\t\t\t= idpf_tx_queue_setup,\n \t.dev_infos_get\t\t\t= idpf_dev_info_get,\n+\t.link_update\t\t\t= idpf_dev_link_update,\n };\n \n static int\n@@ -284,6 +305,40 @@ idpf_dev_configure(struct rte_eth_dev *dev)\n \treturn 0;\n }\n \n+static int\n+idpf_dev_start(struct rte_eth_dev *dev)\n+{\n+\tstruct idpf_vport *vport = dev->data->dev_private;\n+\n+\tif (dev->data->mtu > vport->max_mtu) {\n+\t\tPMD_DRV_LOG(ERR, \"MTU should be less than %d\", vport->max_mtu);\n+\t\treturn -1;\n+\t}\n+\n+\tvport->max_pkt_len = dev->data->mtu + IDPF_ETH_OVERHEAD;\n+\n+\t/* TODO: start queues */\n+\n+\tif (idpf_vc_ena_dis_vport(vport, true) != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to enable vport\");\n+\t\treturn -1;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+idpf_dev_stop(struct rte_eth_dev *dev)\n+{\n+\tstruct idpf_vport *vport = dev->data->dev_private;\n+\n+\tidpf_vc_ena_dis_vport(vport, false);\n+\n+\t/* TODO: stop queues */\n+\n+\treturn 0;\n+}\n+\n static int\n idpf_dev_close(struct rte_eth_dev *dev)\n {\ndiff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_rxtx.c\nindex 25dd5d85d5..3528d2f2c7 100644\n--- a/drivers/net/idpf/idpf_rxtx.c\n+++ b/drivers/net/idpf/idpf_rxtx.c\n@@ -334,6 +334,11 @@ idpf_rx_split_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \tif (check_rx_thresh(nb_desc, rx_free_thresh) != 0)\n \t\treturn -EINVAL;\n \n+\tif (rx_conf->rx_deferred_start) {\n+\t\tPMD_INIT_LOG(ERR, \"Queue start is not supported currently.\");\n+\t\treturn -EINVAL;\n+\t}\n+\n \t/* Setup Rx description queue */\n \trxq = rte_zmalloc_socket(\"idpf rxq\",\n \t\t\t\t sizeof(struct idpf_rx_queue),\n@@ -465,6 +470,11 @@ idpf_rx_single_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \tif (check_rx_thresh(nb_desc, rx_free_thresh) != 0)\n \t\treturn -EINVAL;\n \n+\tif (rx_conf->rx_deferred_start) {\n+\t\tPMD_INIT_LOG(ERR, \"Queue start is not supported currently.\");\n+\t\treturn -EINVAL;\n+\t}\n+\n \t/* Setup Rx description queue */\n \trxq = rte_zmalloc_socket(\"idpf rxq\",\n \t\t\t\t sizeof(struct idpf_rx_queue),\n@@ -569,6 +579,11 @@ idpf_tx_split_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \tif (check_tx_thresh(nb_desc, tx_rs_thresh, tx_free_thresh) != 0)\n \t\treturn -EINVAL;\n \n+\tif (tx_conf->tx_deferred_start) {\n+\t\tPMD_INIT_LOG(ERR, \"Queue start is not supported currently.\");\n+\t\treturn -EINVAL;\n+\t}\n+\n \t/* Allocate the TX queue data structure. */\n \ttxq = rte_zmalloc_socket(\"idpf split txq\",\n \t\t\t\t sizeof(struct idpf_tx_queue),\n@@ -691,6 +706,11 @@ idpf_tx_single_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \tif (check_tx_thresh(nb_desc, tx_rs_thresh, tx_free_thresh) != 0)\n \t\treturn -EINVAL;\n \n+\tif (tx_conf->tx_deferred_start) {\n+\t\tPMD_INIT_LOG(ERR, \"Queue start is not supported currently.\");\n+\t\treturn -EINVAL;\n+\t}\n+\n \t/* Allocate the TX queue data structure. */\n \ttxq = rte_zmalloc_socket(\"idpf txq\",\n \t\t\t\t sizeof(struct idpf_tx_queue),\n", "prefixes": [ "v13", "05/18" ] }